D28686: [Battery Monitor] Choose better wording

2020-07-17 Thread Shubham 
shubham abandoned this revision.
shubham added a comment.


  Pushed here 38ebcf09b1631175d5a1b4d857622c5313146a60

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D28686

To: shubham, #vdg, ngraham, ognarb
Cc: ognarb, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28686: [Battery Monitor] Choose better wording

2020-07-16 Thread Nathaniel Graham 
ngraham removed a reviewer: broulik.
ngraham added a comment.
This revision is now accepted and ready to land.


  Go ahead and land this.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D28686

To: shubham, #vdg, ngraham, ognarb, broulik
Cc: ognarb, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28686: [Battery Monitor] Choose better wording

2020-07-16 Thread Carl Schwan 
ognarb accepted this revision.
ognarb added a comment.


  Change makes sense to me, IIRC Kai doesn't have much time for KDE anymore

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D28686

To: shubham, broulik, #vdg, ngraham, ognarb
Cc: ognarb, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28686: [Battery Monitor] Choose better wording

2020-07-16 Thread Shubham 
shubham added a comment.


  @broulik Ping?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D28686

To: shubham, broulik, #vdg, ngraham
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28686: [Battery Monitor] Choose better wording

2020-06-03 Thread Shubham 
shubham added a comment.


  @broulik Ping??

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D28686

To: shubham, broulik, #vdg, ngraham
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28686: [Battery Monitor] Choose better wording

2020-05-01 Thread Shubham 
shubham added a comment.


  @broulik Friendly ping?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D28686

To: shubham, broulik, #vdg, ngraham
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28686: [Battery Monitor] Choose better wording

2020-04-18 Thread Shubham 
shubham added a comment.


  @broulik Ping?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D28686

To: shubham, broulik, #vdg, ngraham
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28686: [Battery Monitor] Choose better wording

2020-04-09 Thread Nathaniel Graham 
ngraham accepted this revision.
ngraham added 1 blocking reviewer(s): broulik.
ngraham added a comment.


  LGTM. @broulik?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D28686

To: shubham, broulik, #vdg, ngraham
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28686: [Battery Monitor] Choose better wording

2020-04-09 Thread Shubham 
shubham updated this revision to Diff 79686.

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28686?vs=79662=79686

REVISION DETAIL
  https://phabricator.kde.org/D28686

AFFECTED FILES
  applets/batterymonitor/package/contents/ui/logic.js

To: shubham, broulik, #vdg, ngraham
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28686: [Battery Monitor] Choose better wording

2020-04-09 Thread Kai Uwe Broulik 
broulik added a comment.


  "Life remaining" sounds as if it blows up any minute. Perhaps "Remaining 
time"?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D28686

To: shubham, broulik, #vdg, ngraham
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28686: [Battery Monitor] Choose better wording

2020-04-08 Thread Shubham 
shubham created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
shubham requested review of this revision.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  fix-wording

REVISION DETAIL
  https://phabricator.kde.org/D28686

AFFECTED FILES
  applets/batterymonitor/package/contents/ui/logic.js

To: shubham
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart