D28818: Identify output according to current applied position, not an unapplied position

[Roman Gilg]

romangg requested changes to this revision.
romangg removed reviewers: meven, ervin.
romangg added a comment.
This revision now requires changes to proceed.


  Message guideline must be adhered. Summary must be more extensive.

REPOSITORY
  R104 KScreen

REVISION DETAIL
  https://phabricator.kde.org/D28818

To: bport, #plasma, romangg, meven, ervin
Cc: romangg, davidedmundson, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28818: Identify output according to current applied position, not an unapplied position

[Benjamin Port]

bport updated this revision to Diff 80086.
bport added a comment.


  update commit message

REPOSITORY
  R104 KScreen

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28818?vs=80083=80086

REVISION DETAIL
  https://phabricator.kde.org/D28818

AFFECTED FILES
  kcm/config_handler.h
  kcm/kcm.cpp

To: bport, #plasma, meven, ervin
Cc: davidedmundson, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28818: Identify output according to current applied position, not an unapplied position

[David Edmundson]

davidedmundson added a comment.


  Seems very sensible. +1
  
  Note that kscreen has a commit message schema different to every other KDE 
policy. See CONTRIBUTING.md at the root level.

REPOSITORY
  R104 KScreen

REVISION DETAIL
  https://phabricator.kde.org/D28818

To: bport, #plasma, meven, ervin
Cc: davidedmundson, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28818: Identify output according to current applied position, not an unapplied position

[Benjamin Port]

bport created this revision.
bport added reviewers: Plasma, meven, ervin.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
bport requested review of this revision.

REVISION SUMMARY
  Depends on D28817 .

REPOSITORY
  R104 KScreen

REVISION DETAIL
  https://phabricator.kde.org/D28818

AFFECTED FILES
  kcm/config_handler.h
  kcm/kcm.cpp

To: bport, #plasma, meven, ervin
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart