D28830: Don't set a custom palette if we have the same palette as the currently active one

2020-04-17 Thread David Redondo 
This revision was automatically updated to reflect the committed changes.
Closed by commit R31:66d0b0b4e3e1: Don't set a custom palette if we have 
the same palette as the currently active… (authored by davidre).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D28830?vs=80127&id=80356#toc

REPOSITORY
  R31 Breeze

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28830?vs=80127&id=80356

REVISION DETAIL
  https://phabricator.kde.org/D28830

AFFECTED FILES
  kstyle/breezehelper.cpp

To: davidre, broulik, ngraham
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28830: Don't set a custom palette if we have the same palette as the currently active one

2020-04-17 Thread Kai Uwe Broulik 
broulik accepted this revision.
broulik added a comment.


  Fixes the Dolphin toolbar icon color and KWrite save dialog button icon color.

INLINE COMMENTS

> breezehelper.cpp:1608
> +if (changePalette) {
> +if(activePalette == QPalette()) {
> +KIconLoader::global()->resetPalette();

Coding style

REPOSITORY
  R31 Breeze

BRANCH
  ffs (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28830

To: davidre, broulik, ngraham
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28830: Don't set a custom palette if we have the same palette as the currently active one

2020-04-14 Thread Nathaniel Graham 
ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  This fixes that weird icon coloration issue I was having in Dolphin that I 
had just started to investigate. :)

REPOSITORY
  R31 Breeze

BRANCH
  ffs (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28830

To: davidre, broulik, ngraham
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28830: Don't set a custom palette if we have the same palette as the currently active one

2020-04-14 Thread David Redondo 
davidre created this revision.
davidre added a reviewer: broulik.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
davidre requested review of this revision.

REVISION SUMMARY
  Caused some icons not be colored correctly

TEST PLAN
  Close KWrite with unsaved changes, all icons should be colored correctly

REPOSITORY
  R31 Breeze

BRANCH
  ffs (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28830

AFFECTED FILES
  kstyle/breezehelper.cpp

To: davidre, broulik
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart