D28888: Fix navigation regressions

This revision was automatically updated to reflect the committed changes. Closed by commit R1014:f98e5d33f46b: Fix navigation regressions (authored by cblack). REPOSITORY R1014 Kirigami Gallery CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2?vs=81713=81889 REVISION DETAIL

D28888: Fix navigation regressions

ndavis added a comment. Thanks, this fixes the navigation issue after a page has been selected. The main grid view is still annoying though. REPOSITORY R1014 Kirigami Gallery BRANCH cblack/better-navigation (branched from master) REVISION DETAIL https://phabricator.kde.org/D2

D28888: Fix navigation regressions

cblack updated this revision to Diff 81713. cblack added a comment. Use normal list delegates REPOSITORY R1014 Kirigami Gallery CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2?vs=81214=81713 BRANCH cblack/better-navigation (branched from master) REVISION DETAIL

D28888: Fix navigation regressions

cblack updated this revision to Diff 81214. cblack added a comment. Rebase REPOSITORY R1014 Kirigami Gallery CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2?vs=81132=81214 BRANCH cblack/better-navigation (branched from master) REVISION DETAIL

D28888: Fix navigation regressions

ndavis added a comment. This needs to be rebased REPOSITORY R1014 Kirigami Gallery REVISION DETAIL https://phabricator.kde.org/D2 To: cblack, #vdg, #kirigami Cc: mart, ndavis, ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2,

D28888: Fix navigation regressions

ngraham added a comment. That works, but wouldn't it be nicer if the border of the card just clipped the image? Also I just noticed that Sidebar Drawer view is a mess. REPOSITORY R1014 Kirigami Gallery REVISION DETAIL https://phabricator.kde.org/D2 To: cblack, #vdg, #kirigami

D28888: Fix navigation regressions

cblack updated this revision to Diff 81132. cblack added a comment. Add left margin to image REPOSITORY R1014 Kirigami Gallery CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2?vs=81130=81132 BRANCH cblack/better-navigation (branched from master) REVISION DETAIL

D28888: Fix navigation regressions

ngraham added a comment. Much better. But the left corners of the cards aren't rounded. REPOSITORY R1014 Kirigami Gallery REVISION DETAIL https://phabricator.kde.org/D2 To: cblack, #vdg, #kirigami Cc: mart, ndavis, ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack,

D28888: Fix navigation regressions

cblack updated this revision to Diff 81130. cblack added a comment. Address feedback REPOSITORY R1014 Kirigami Gallery CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2?vs=81129=81130 BRANCH cblack/better-navigation (branched from master) REVISION DETAIL

D28888: Fix navigation regressions

ngraham added a comment. Much nicer! There appear to be issues with the left margin and the color of the search field's toolbar background though: F8258252: Screenshot_20200424_130114.png Also the text in the cards seems a too large to me.

D28888: Fix navigation regressions

cblack updated this revision to Diff 81129. cblack added a comment. Swap collapsed header and image REPOSITORY R1014 Kirigami Gallery CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2?vs=81127=81129 BRANCH cblack/better-navigation (branched from master) REVISION DETAIL

D28888: Fix navigation regressions

cblack updated this revision to Diff 81127. cblack added a comment. Adjust listview REPOSITORY R1014 Kirigami Gallery CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2?vs=80822=81127 BRANCH cblack/better-navigation (branched from master) REVISION DETAIL

D28888: Fix navigation regressions

ngraham added a comment. Close. There's extra spacing on the right for some reason, and I think the sidebar's background used to be white. F8252517: Screenshot_20200421_191722.png REPOSITORY R1014 Kirigami Gallery REVISION DETAIL

D28888: Fix navigation regressions

cblack updated this revision to Diff 80822. cblack added a comment. Switch between ListView and CardsLayout REPOSITORY R1014 Kirigami Gallery CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2?vs=80291=80822 BRANCH cblack/better-navigation (branched from master) REVISION

D28888: Fix navigation regressions

mart added a comment. btw may be worth trying to have a stackview that switches between this view and the one before based on page with (wideMode property of pagerow) REPOSITORY R1014 Kirigami Gallery REVISION DETAIL https://phabricator.kde.org/D2 To: cblack, #vdg, #kirigami Cc:

D28888: Fix navigation regressions

mart added a comment. if there can't be a super smooth transition between a listview and this thing (perhaps with a stackview, but i'm not sold) then there should always be just the cardlayout with the same cards look, just as a single column REPOSITORY R1014 Kirigami Gallery REVISION

D28888: Fix navigation regressions

ndavis added a comment. In D2#649712 , @cblack wrote: > In D2#649710 , @ngraham wrote: > > > Hmm, now the cards collapse into weird pseudo-list-items in the sidebar. Could they just go back

D28888: Fix navigation regressions

ngraham added a comment. I can understand that there are technical challenges, but, not to put too fine a point on it, this doesn't look very good: F8241927: Screenshot_20200416_101220.png REPOSITORY R1014 Kirigami Gallery REVISION DETAIL

D28888: Fix navigation regressions

cblack added a comment. In D2#649710 , @ngraham wrote: > Hmm, now the cards collapse into weird pseudo-list-items in the sidebar. Could they just go back to using real list items instead? That's what I initially attempted, but

D28888: Fix navigation regressions

ngraham added a comment. Hmm, now the cards collapse into weird pseudo-list-items in the sidebar. Could they just go back to using real list items instead? REPOSITORY R1014 Kirigami Gallery REVISION DETAIL https://phabricator.kde.org/D2 To: cblack, #vdg, #kirigami Cc: ngraham,

D28888: Fix navigation regressions

cblack created this revision. cblack added reviewers: VDG, Kirigami. Herald added projects: Plasma, Kirigami. Herald added a subscriber: plasma-devel. cblack requested review of this revision. REVISION SUMMARY This patch fixes navigation regressions caused by larger cards in the gallery. -