D28893: Detect Vivaldi based on binary name
This revision was automatically updated to reflect the committed changes. Closed by commit R856:97981b214ab6: Detect Vivaldi based on binary name (authored by broulik). REPOSITORY R856 Plasma Browser Integration CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28893?vs=80316=80347 REVISION DETAIL https://phabricator.kde.org/D28893 AFFECTED FILES CMakeLists.txt host/CMakeLists.txt host/settings.cpp To: broulik, #plasma, fvogt Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
D28893: Detect Vivaldi based on binary name
fvogt accepted this revision. fvogt added a comment. This revision is now accepted and ready to land. Tested, works. I didn't even notice that it broke... Will probably have to be refactored later to look at `environmentDescriptions` or `environmentNames` though. > Should be good for 5.18 - coreaddons should have been an implicit dependency anyway? Yup. > Its icon doesn't show up and I have no idea where the "vivadi" icon file it specifies in its desktop file is located Here it used `xdg-icon-resource install ...` to install the icon in an rpm %post script, so I've got `/usr/share/icons/hicolor/*x*/apps/vivaldi.png` as usual. REPOSITORY R856 Plasma Browser Integration REVISION DETAIL https://phabricator.kde.org/D28893 To: broulik, #plasma, fvogt Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
D28893: Detect Vivaldi based on binary name
broulik created this revision. broulik added reviewers: Plasma, fvogt. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY Vivaldi no longer includes its name in the User Agent, see [1]. Try detecting it based on binary name instead. This could perhaps also be used to detect other chromium-based browsers such as Brave. [1] https://www.google.de/search?q=vivaldi+user+agent+change TEST PLAN Should be good for 5.18 - coreaddons should have been an implicit dependency anyway? - MPRIS identifies it as Vivaldi again. - Its icon doesn't show up and I have no idea where the "vivadi" icon file it specifies in its desktop file is located REPOSITORY R856 Plasma Browser Integration REVISION DETAIL https://phabricator.kde.org/D28893 AFFECTED FILES CMakeLists.txt host/CMakeLists.txt host/settings.cpp To: broulik, #plasma, fvogt Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
