D28908: Use the same icon mode calculation for comboboxes as for buttons

This revision was automatically updated to reflect the committed changes. Closed by commit R31:5a62232415bc: Use the same icon mode calculation for comboboxes as for buttons (authored by davidre). REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE

D28908: Use the same icon mode calculation for comboboxes as for buttons

ndavis accepted this revision. ndavis added a comment. This revision is now accepted and ready to land. Ok, it took me a while to fully understand what this patch does, but it seems to be working fine. REPOSITORY R31 Breeze BRANCH combobox (branched from master) REVISION DETAIL

D28908: Use the same icon mode calculation for comboboxes as for buttons

ndavis added a comment. In D28908#651314 , @davidre wrote: > In D28908#651078 , @ndavis wrote: > > > Oddly, I can't reproduce the bug this fixes in all comboboxes. KSysGuard's process filtering and

D28908: Use the same icon mode calculation for comboboxes as for buttons

davidre added a comment. In D28908#651078 , @ndavis wrote: > Oddly, I can't reproduce the bug this fixes in all comboboxes. KSysGuard's process filtering and tools comboboxes are right next to each other and have different behavior. > >

D28908: Use the same icon mode calculation for comboboxes as for buttons

ndavis added a comment. Oddly, I can't reproduce the bug this fixes in all comboboxes. KSysGuard's process filtering and tools comboboxes are right next to each other and have different behavior. This causes another problem with all monochrome icons on the Breeze colorscheme though:

D28908: Use the same icon mode calculation for comboboxes as for buttons

davidre added a comment. I don't understand. The palette doesn't change when a widget is selected, does it? The selected state is used by KIconLoader to decide which color to use for text color, or highlight state == KIconLoader::SelectedState ? pal.highlightedText().color().name()

D28908: Use the same icon mode calculation for comboboxes as for buttons

broulik added a comment. Now that we can properly recolorize all the icons, maybe we should drop the `State_Selected` handling altogether? REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D28908 To: davidre, broulik, #breeze Cc: plasma-devel, Orage, LeGast00n,

D28908: Use the same icon mode calculation for comboboxes as for buttons

davidre created this revision. davidre added reviewers: broulik, Breeze. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. davidre requested review of this revision. REVISION SUMMARY When hovering a focused combobox the icon was in Selected state resulting in a wrong