D28922: Port Sensor Face loading from plasmoid
mart closed this revision. REPOSITORY R111 KSysguard Library REVISION DETAIL https://phabricator.kde.org/D28922 To: mart, #plasma, ahiemstra, #vdg Cc: zzag, ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
D28922: Port Sensor Face loading from plasmoid
mart updated this revision to Diff 82289. mart added a comment. - Merge branch 'sensors_lib' into mart/sensor_face REPOSITORY R111 KSysguard Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28922?vs=82279=82289 BRANCH mart/sensor_face REVISION DETAIL https://phabricator.kde.org/D28922 AFFECTED FILES CMakeLists.txt faces/CMakeLists.txt faces/ConfigAppearance.qml faces/ConfigSensors.qml faces/FaceDetailsConfig.qml faces/SensorFace.cpp faces/SensorFaceController.cpp faces/SensorFaceController.h faces/SensorFaceController_p.h faces/SensorFace_p.h faces/UsedSensorsView.qml faces/facepackages/CMakeLists.txt faces/facepackages/barchart/contents/config/main.xml faces/facepackages/barchart/contents/faceproperties faces/facepackages/barchart/contents/ui/BarChart.qml faces/facepackages/barchart/contents/ui/CompactRepresentation.qml faces/facepackages/barchart/contents/ui/Config.qml faces/facepackages/barchart/contents/ui/FullRepresentation.qml faces/facepackages/barchart/metadata.desktop faces/facepackages/linechart/contents/config/main.xml faces/facepackages/linechart/contents/faceproperties faces/facepackages/linechart/contents/ui/CompactRepresentation.qml faces/facepackages/linechart/contents/ui/Config.qml faces/facepackages/linechart/contents/ui/FullRepresentation.qml faces/facepackages/linechart/contents/ui/LineChart.qml faces/facepackages/linechart/metadata.desktop faces/facepackages/piechart/contents/config/main.xml faces/facepackages/piechart/contents/faceproperties faces/facepackages/piechart/contents/ui/CompactRepresentation.qml faces/facepackages/piechart/contents/ui/Config.qml faces/facepackages/piechart/contents/ui/FullRepresentation.qml faces/facepackages/piechart/contents/ui/PieChart.qml faces/facepackages/piechart/metadata.desktop faces/facepackages/textonly/contents/faceproperties faces/facepackages/textonly/contents/ui/CompactRepresentation.qml faces/facepackages/textonly/contents/ui/FullRepresentation.qml faces/facepackages/textonly/metadata.desktop faces/import/CMakeLists.txt faces/import/ExtendedLegend.qml faces/import/FacesPlugin.cpp faces/import/FacesPlugin.h faces/import/SensorFace.qml faces/import/qmldir faces/packagestructure/CMakeLists.txt faces/packagestructure/sensorface-packagestructure.json faces/packagestructure/sensorfacepackage.cpp faces/resources.qrc processcore/extended_process_list.cpp sensors/CMakeLists.txt sensors/SensorQuery.cpp sensors/declarative/CMakeLists.txt sensors/declarative/ExtendedLegend.qml sensors/declarative/qmldir To: mart, #plasma, ahiemstra, #vdg Cc: zzag, ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
D28922: Port Sensor Face loading from plasmoid
mart updated this revision to Diff 82279. mart added a comment. - sensorColors is now a map - fix preset uninstall REPOSITORY R111 KSysguard Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28922?vs=82223=82279 BRANCH mart/sensor_face REVISION DETAIL https://phabricator.kde.org/D28922 AFFECTED FILES CMakeLists.txt faces/CMakeLists.txt faces/ConfigAppearance.qml faces/ConfigSensors.qml faces/FaceDetailsConfig.qml faces/SensorFace.cpp faces/SensorFaceController.cpp faces/SensorFaceController.h faces/SensorFaceController_p.h faces/SensorFace_p.h faces/UsedSensorsView.qml faces/facepackages/CMakeLists.txt faces/facepackages/barchart/contents/config/main.xml faces/facepackages/barchart/contents/faceproperties faces/facepackages/barchart/contents/ui/BarChart.qml faces/facepackages/barchart/contents/ui/CompactRepresentation.qml faces/facepackages/barchart/contents/ui/Config.qml faces/facepackages/barchart/contents/ui/FullRepresentation.qml faces/facepackages/barchart/metadata.desktop faces/facepackages/linechart/contents/config/main.xml faces/facepackages/linechart/contents/faceproperties faces/facepackages/linechart/contents/ui/CompactRepresentation.qml faces/facepackages/linechart/contents/ui/Config.qml faces/facepackages/linechart/contents/ui/FullRepresentation.qml faces/facepackages/linechart/contents/ui/LineChart.qml faces/facepackages/linechart/metadata.desktop faces/facepackages/piechart/contents/config/main.xml faces/facepackages/piechart/contents/faceproperties faces/facepackages/piechart/contents/ui/CompactRepresentation.qml faces/facepackages/piechart/contents/ui/Config.qml faces/facepackages/piechart/contents/ui/FullRepresentation.qml faces/facepackages/piechart/contents/ui/PieChart.qml faces/facepackages/piechart/metadata.desktop faces/facepackages/textonly/contents/faceproperties faces/facepackages/textonly/contents/ui/CompactRepresentation.qml faces/facepackages/textonly/contents/ui/FullRepresentation.qml faces/facepackages/textonly/metadata.desktop faces/import/CMakeLists.txt faces/import/ExtendedLegend.qml faces/import/FacesPlugin.cpp faces/import/FacesPlugin.h faces/import/SensorFace.qml faces/import/qmldir faces/packagestructure/CMakeLists.txt faces/packagestructure/sensorface-packagestructure.json faces/packagestructure/sensorfacepackage.cpp faces/resources.qrc processcore/extended_process_list.cpp sensors/CMakeLists.txt sensors/SensorInfo_p.h sensors/SensorQuery.cpp sensors/declarative/CMakeLists.txt sensors/declarative/ExtendedLegend.qml sensors/declarative/qmldir To: mart, #plasma, ahiemstra, #vdg Cc: zzag, ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
D28922: Port Sensor Face loading from plasmoid
zzag added inline comments.
INLINE COMMENTS
> SensorFaceController.cpp:177
> +if (component->status() != QQmlComponent::Ready) {
> +qCritical() << "Error creating component:";
> +for (auto err : component->errors()) {
One could argue that "Error creating component" is a pretty common error
message. Categorized logging can be useful for resolving such ambiguities.
REPOSITORY
R111 KSysguard Library
BRANCH
mart/sensor_face
REVISION DETAIL
https://phabricator.kde.org/D28922
To: mart, #plasma, ahiemstra, #vdg
Cc: zzag, ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack,
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai,
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
D28922: Port Sensor Face loading from plasmoid
ngraham added a comment. Hmm, this doesn't seem to apply cleanly on top of current master. REPOSITORY R111 KSysguard Library BRANCH mart/sensor_face REVISION DETAIL https://phabricator.kde.org/D28922 To: mart, #plasma, ahiemstra, #vdg Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
D28922: Port Sensor Face loading from plasmoid
mart updated this revision to Diff 82223. mart added a comment. - use QJsonArrays for sensors REPOSITORY R111 KSysguard Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28922?vs=82188=82223 BRANCH mart/sensor_face REVISION DETAIL https://phabricator.kde.org/D28922 AFFECTED FILES CMakeLists.txt faces/CMakeLists.txt faces/ConfigAppearance.qml faces/ConfigSensors.qml faces/FaceDetailsConfig.qml faces/SensorFace.cpp faces/SensorFaceController.cpp faces/SensorFaceController.h faces/SensorFaceController_p.h faces/SensorFace_p.h faces/UsedSensorsView.qml faces/facepackages/CMakeLists.txt faces/facepackages/barchart/contents/config/main.xml faces/facepackages/barchart/contents/faceproperties faces/facepackages/barchart/contents/ui/BarChart.qml faces/facepackages/barchart/contents/ui/CompactRepresentation.qml faces/facepackages/barchart/contents/ui/Config.qml faces/facepackages/barchart/contents/ui/FullRepresentation.qml faces/facepackages/barchart/metadata.desktop faces/facepackages/linechart/contents/config/main.xml faces/facepackages/linechart/contents/faceproperties faces/facepackages/linechart/contents/ui/CompactRepresentation.qml faces/facepackages/linechart/contents/ui/Config.qml faces/facepackages/linechart/contents/ui/FullRepresentation.qml faces/facepackages/linechart/contents/ui/LineChart.qml faces/facepackages/linechart/metadata.desktop faces/facepackages/piechart/contents/config/main.xml faces/facepackages/piechart/contents/faceproperties faces/facepackages/piechart/contents/ui/CompactRepresentation.qml faces/facepackages/piechart/contents/ui/Config.qml faces/facepackages/piechart/contents/ui/FullRepresentation.qml faces/facepackages/piechart/contents/ui/PieChart.qml faces/facepackages/piechart/metadata.desktop faces/facepackages/textonly/contents/faceproperties faces/facepackages/textonly/contents/ui/CompactRepresentation.qml faces/facepackages/textonly/contents/ui/FullRepresentation.qml faces/facepackages/textonly/metadata.desktop faces/import/CMakeLists.txt faces/import/ExtendedLegend.qml faces/import/FacesPlugin.cpp faces/import/FacesPlugin.h faces/import/SensorFace.qml faces/import/qmldir faces/packagestructure/CMakeLists.txt faces/packagestructure/sensorface-packagestructure.json faces/packagestructure/sensorfacepackage.cpp faces/resources.qrc processcore/extended_process_list.cpp sensors/CMakeLists.txt sensors/SensorInfo_p.h sensors/SensorQuery.cpp sensors/declarative/CMakeLists.txt sensors/declarative/ExtendedLegend.qml sensors/declarative/qmldir To: mart, #plasma, ahiemstra, #vdg Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
D28922: Port Sensor Face loading from plasmoid
mart updated this revision to Diff 82188. mart added a comment. - remove extra debug REPOSITORY R111 KSysguard Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28922?vs=82185=82188 BRANCH mart/sensor_face REVISION DETAIL https://phabricator.kde.org/D28922 AFFECTED FILES CMakeLists.txt faces/CMakeLists.txt faces/ConfigAppearance.qml faces/ConfigSensors.qml faces/FaceDetailsConfig.qml faces/SensorFace.cpp faces/SensorFaceController.cpp faces/SensorFaceController.h faces/SensorFaceController_p.h faces/SensorFace_p.h faces/UsedSensorsView.qml faces/facepackages/CMakeLists.txt faces/facepackages/barchart/contents/config/main.xml faces/facepackages/barchart/contents/faceproperties faces/facepackages/barchart/contents/ui/BarChart.qml faces/facepackages/barchart/contents/ui/CompactRepresentation.qml faces/facepackages/barchart/contents/ui/Config.qml faces/facepackages/barchart/contents/ui/FullRepresentation.qml faces/facepackages/barchart/metadata.desktop faces/facepackages/linechart/contents/config/main.xml faces/facepackages/linechart/contents/faceproperties faces/facepackages/linechart/contents/ui/CompactRepresentation.qml faces/facepackages/linechart/contents/ui/Config.qml faces/facepackages/linechart/contents/ui/FullRepresentation.qml faces/facepackages/linechart/contents/ui/LineChart.qml faces/facepackages/linechart/metadata.desktop faces/facepackages/piechart/contents/config/main.xml faces/facepackages/piechart/contents/faceproperties faces/facepackages/piechart/contents/ui/CompactRepresentation.qml faces/facepackages/piechart/contents/ui/Config.qml faces/facepackages/piechart/contents/ui/FullRepresentation.qml faces/facepackages/piechart/contents/ui/PieChart.qml faces/facepackages/piechart/metadata.desktop faces/facepackages/textonly/contents/faceproperties faces/facepackages/textonly/contents/ui/CompactRepresentation.qml faces/facepackages/textonly/contents/ui/FullRepresentation.qml faces/facepackages/textonly/metadata.desktop faces/import/CMakeLists.txt faces/import/ExtendedLegend.qml faces/import/FacesPlugin.cpp faces/import/FacesPlugin.h faces/import/SensorFace.qml faces/import/qmldir faces/packagestructure/CMakeLists.txt faces/packagestructure/sensorface-packagestructure.json faces/packagestructure/sensorfacepackage.cpp faces/resources.qrc processcore/extended_process_list.cpp sensors/CMakeLists.txt sensors/SensorInfo_p.h sensors/SensorQuery.cpp sensors/declarative/CMakeLists.txt sensors/declarative/ExtendedLegend.qml sensors/declarative/qmldir To: mart, #plasma, ahiemstra, #vdg Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
D28922: Port Sensor Face loading from plasmoid
mart updated this revision to Diff 82185. mart added a comment. - use regexp for multiple sensors - left-alignlegends when they are too wide REPOSITORY R111 KSysguard Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28922?vs=82119=82185 BRANCH mart/sensor_face REVISION DETAIL https://phabricator.kde.org/D28922 AFFECTED FILES CMakeLists.txt faces/CMakeLists.txt faces/ConfigAppearance.qml faces/ConfigSensors.qml faces/FaceDetailsConfig.qml faces/SensorFace.cpp faces/SensorFaceController.cpp faces/SensorFaceController.h faces/SensorFaceController_p.h faces/SensorFace_p.h faces/UsedSensorsView.qml faces/facepackages/CMakeLists.txt faces/facepackages/barchart/contents/config/main.xml faces/facepackages/barchart/contents/faceproperties faces/facepackages/barchart/contents/ui/BarChart.qml faces/facepackages/barchart/contents/ui/CompactRepresentation.qml faces/facepackages/barchart/contents/ui/Config.qml faces/facepackages/barchart/contents/ui/FullRepresentation.qml faces/facepackages/barchart/metadata.desktop faces/facepackages/linechart/contents/config/main.xml faces/facepackages/linechart/contents/faceproperties faces/facepackages/linechart/contents/ui/CompactRepresentation.qml faces/facepackages/linechart/contents/ui/Config.qml faces/facepackages/linechart/contents/ui/FullRepresentation.qml faces/facepackages/linechart/contents/ui/LineChart.qml faces/facepackages/linechart/metadata.desktop faces/facepackages/piechart/contents/config/main.xml faces/facepackages/piechart/contents/faceproperties faces/facepackages/piechart/contents/ui/CompactRepresentation.qml faces/facepackages/piechart/contents/ui/Config.qml faces/facepackages/piechart/contents/ui/FullRepresentation.qml faces/facepackages/piechart/contents/ui/PieChart.qml faces/facepackages/piechart/metadata.desktop faces/facepackages/textonly/contents/faceproperties faces/facepackages/textonly/contents/ui/CompactRepresentation.qml faces/facepackages/textonly/contents/ui/FullRepresentation.qml faces/facepackages/textonly/metadata.desktop faces/import/CMakeLists.txt faces/import/ExtendedLegend.qml faces/import/FacesPlugin.cpp faces/import/FacesPlugin.h faces/import/SensorFace.qml faces/import/qmldir faces/packagestructure/CMakeLists.txt faces/packagestructure/sensorface-packagestructure.json faces/packagestructure/sensorfacepackage.cpp faces/resources.qrc processcore/extended_process_list.cpp sensors/CMakeLists.txt sensors/SensorInfo_p.h sensors/SensorQuery.cpp sensors/declarative/CMakeLists.txt sensors/declarative/ExtendedLegend.qml sensors/declarative/qmldir To: mart, #plasma, ahiemstra, #vdg Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
D28922: Port Sensor Face loading from plasmoid
mart updated this revision to Diff 82119. mart marked 5 inline comments as done. mart added a comment. - add space REPOSITORY R111 KSysguard Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28922?vs=82116=82119 BRANCH mart/sensor_face REVISION DETAIL https://phabricator.kde.org/D28922 AFFECTED FILES CMakeLists.txt faces/CMakeLists.txt faces/ConfigAppearance.qml faces/ConfigSensors.qml faces/FaceDetailsConfig.qml faces/SensorFace.cpp faces/SensorFaceController.cpp faces/SensorFaceController.h faces/SensorFaceController_p.h faces/SensorFace_p.h faces/UsedSensorsView.qml faces/facepackages/CMakeLists.txt faces/facepackages/barchart/contents/config/main.xml faces/facepackages/barchart/contents/faceproperties faces/facepackages/barchart/contents/ui/BarChart.qml faces/facepackages/barchart/contents/ui/CompactRepresentation.qml faces/facepackages/barchart/contents/ui/Config.qml faces/facepackages/barchart/contents/ui/FullRepresentation.qml faces/facepackages/barchart/metadata.desktop faces/facepackages/linechart/contents/config/main.xml faces/facepackages/linechart/contents/faceproperties faces/facepackages/linechart/contents/ui/CompactRepresentation.qml faces/facepackages/linechart/contents/ui/Config.qml faces/facepackages/linechart/contents/ui/FullRepresentation.qml faces/facepackages/linechart/contents/ui/LineChart.qml faces/facepackages/linechart/metadata.desktop faces/facepackages/piechart/contents/config/main.xml faces/facepackages/piechart/contents/faceproperties faces/facepackages/piechart/contents/ui/CompactRepresentation.qml faces/facepackages/piechart/contents/ui/Config.qml faces/facepackages/piechart/contents/ui/FullRepresentation.qml faces/facepackages/piechart/contents/ui/PieChart.qml faces/facepackages/piechart/metadata.desktop faces/facepackages/textonly/contents/faceproperties faces/facepackages/textonly/contents/ui/CompactRepresentation.qml faces/facepackages/textonly/contents/ui/FullRepresentation.qml faces/facepackages/textonly/metadata.desktop faces/import/CMakeLists.txt faces/import/ExtendedLegend.qml faces/import/FacesPlugin.cpp faces/import/FacesPlugin.h faces/import/SensorFace.qml faces/import/qmldir faces/packagestructure/CMakeLists.txt faces/packagestructure/sensorface-packagestructure.json faces/packagestructure/sensorfacepackage.cpp faces/resources.qrc processcore/extended_process_list.cpp sensors/CMakeLists.txt sensors/SensorInfo_p.h sensors/declarative/CMakeLists.txt sensors/declarative/ExtendedLegend.qml sensors/declarative/qmldir To: mart, #plasma, ahiemstra, #vdg Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
D28922: Port Sensor Face loading from plasmoid
mart updated this revision to Diff 82116. mart added a comment. - move face properties in own file - move face config in own file REPOSITORY R111 KSysguard Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28922?vs=82089=82116 BRANCH mart/sensor_face REVISION DETAIL https://phabricator.kde.org/D28922 AFFECTED FILES CMakeLists.txt faces/CMakeLists.txt faces/ConfigAppearance.qml faces/ConfigSensors.qml faces/FaceDetailsConfig.qml faces/SensorFace.cpp faces/SensorFaceController.cpp faces/SensorFaceController.h faces/SensorFaceController_p.h faces/SensorFace_p.h faces/UsedSensorsView.qml faces/facepackages/CMakeLists.txt faces/facepackages/barchart/contents/config/main.xml faces/facepackages/barchart/contents/faceproperties faces/facepackages/barchart/contents/ui/BarChart.qml faces/facepackages/barchart/contents/ui/CompactRepresentation.qml faces/facepackages/barchart/contents/ui/Config.qml faces/facepackages/barchart/contents/ui/FullRepresentation.qml faces/facepackages/barchart/metadata.desktop faces/facepackages/linechart/contents/config/main.xml faces/facepackages/linechart/contents/faceproperties faces/facepackages/linechart/contents/ui/CompactRepresentation.qml faces/facepackages/linechart/contents/ui/Config.qml faces/facepackages/linechart/contents/ui/FullRepresentation.qml faces/facepackages/linechart/contents/ui/LineChart.qml faces/facepackages/linechart/metadata.desktop faces/facepackages/piechart/contents/config/main.xml faces/facepackages/piechart/contents/faceproperties faces/facepackages/piechart/contents/ui/CompactRepresentation.qml faces/facepackages/piechart/contents/ui/Config.qml faces/facepackages/piechart/contents/ui/FullRepresentation.qml faces/facepackages/piechart/contents/ui/PieChart.qml faces/facepackages/piechart/metadata.desktop faces/facepackages/textonly/contents/faceproperties faces/facepackages/textonly/contents/ui/CompactRepresentation.qml faces/facepackages/textonly/contents/ui/FullRepresentation.qml faces/facepackages/textonly/metadata.desktop faces/import/CMakeLists.txt faces/import/ExtendedLegend.qml faces/import/FacesPlugin.cpp faces/import/FacesPlugin.h faces/import/SensorFace.qml faces/import/qmldir faces/packagestructure/CMakeLists.txt faces/packagestructure/sensorface-packagestructure.json faces/packagestructure/sensorfacepackage.cpp faces/resources.qrc processcore/extended_process_list.cpp sensors/CMakeLists.txt sensors/SensorInfo_p.h sensors/declarative/CMakeLists.txt sensors/declarative/ExtendedLegend.qml sensors/declarative/qmldir To: mart, #plasma, ahiemstra, #vdg Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
D28922: Port Sensor Face loading from plasmoid
ahiemstra accepted this revision. ahiemstra added a comment. This revision is now accepted and ready to land. Let's get this in and fix anything broken in follow ups. REPOSITORY R111 KSysguard Library BRANCH mart/sensor_face REVISION DETAIL https://phabricator.kde.org/D28922 To: mart, #plasma, ahiemstra, #vdg Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
D28922: Port Sensor Face loading from plasmoid
mart updated this revision to Diff 82089. mart added a comment. - default to linechart - default to textonly - sensorIds highPrioritySensorIds - kill table visualization - TotalSensor->TotalSensors list - SupportsTotalSensor->SupportsTotalSensors REPOSITORY R111 KSysguard Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28922?vs=81882=82089 BRANCH mart/sensor_face REVISION DETAIL https://phabricator.kde.org/D28922 AFFECTED FILES CMakeLists.txt faces/CMakeLists.txt faces/ConfigAppearance.qml faces/ConfigSensors.qml faces/FaceDetailsConfig.qml faces/SensorFace.cpp faces/SensorFaceController.cpp faces/SensorFaceController.h faces/SensorFaceController_p.h faces/SensorFace_p.h faces/UsedSensorsView.qml faces/facepackages/CMakeLists.txt faces/facepackages/barchart/contents/config/main.xml faces/facepackages/barchart/contents/ui/BarChart.qml faces/facepackages/barchart/contents/ui/CompactRepresentation.qml faces/facepackages/barchart/contents/ui/Config.qml faces/facepackages/barchart/contents/ui/FullRepresentation.qml faces/facepackages/barchart/metadata.desktop faces/facepackages/linechart/contents/config/main.xml faces/facepackages/linechart/contents/ui/CompactRepresentation.qml faces/facepackages/linechart/contents/ui/Config.qml faces/facepackages/linechart/contents/ui/FullRepresentation.qml faces/facepackages/linechart/contents/ui/LineChart.qml faces/facepackages/linechart/metadata.desktop faces/facepackages/piechart/contents/config/main.xml faces/facepackages/piechart/contents/ui/CompactRepresentation.qml faces/facepackages/piechart/contents/ui/Config.qml faces/facepackages/piechart/contents/ui/FullRepresentation.qml faces/facepackages/piechart/contents/ui/PieChart.qml faces/facepackages/piechart/metadata.desktop faces/facepackages/textonly/contents/ui/CompactRepresentation.qml faces/facepackages/textonly/contents/ui/FullRepresentation.qml faces/facepackages/textonly/metadata.desktop faces/import/CMakeLists.txt faces/import/ExtendedLegend.qml faces/import/FacesPlugin.cpp faces/import/FacesPlugin.h faces/import/SensorFace.qml faces/import/qmldir faces/packagestructure/CMakeLists.txt faces/packagestructure/sensorface-packagestructure.json faces/packagestructure/sensorfacepackage.cpp faces/resources.qrc processcore/extended_process_list.cpp sensors/CMakeLists.txt sensors/SensorInfo_p.h sensors/declarative/CMakeLists.txt sensors/declarative/ExtendedLegend.qml sensors/declarative/qmldir To: mart, #plasma, ahiemstra, #vdg Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
D28922: Port Sensor Face loading from plasmoid
ahiemstra added inline comments. INLINE COMMENTS > mart wrote in SensorFaceController.h:47 > how would that work in current faces that have this binded to that single big > number inside graphs? You'd use the first one from the list? If we want to limit it I think we need to limit it in the UI, not in the backend, since that leads to a complete inability to do anything different. REPOSITORY R111 KSysguard Library REVISION DETAIL https://phabricator.kde.org/D28922 To: mart, #plasma, ahiemstra, #vdg Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
D28922: Port Sensor Face loading from plasmoid
ngraham added inline comments.
INLINE COMMENTS
> ConfigAppearance.qml:24
> +import QtQuick.Layouts 1.2
> +import QtQuick.Controls 2.2 as Controls
> +
`as QQC2`
> ConfigAppearance.qml:69
> +delegate: Kirigami.SwipeListItem {
> +contentItem: Controls.Label {
> +Layout.fillWidth: true
swipeListItem has its own label property; can we use that instead of overriding
the contentItem?
> ConfigSensors.qml:24
> +import QtQuick.Layouts 1.2
> +import QtQuick.Controls 2.2 as Controls
> +import QtQml.Models 2.12
`as QQC2`
> FaceDetailsConfig.qml:24
> +import QtQuick.Layouts 1.2
> +import QtQuick.Controls 2.2 as Controls
> +
`as QQC2`
> FaceDetailsConfig.qml:45
> +if (item.hasOwnProperty("cfg_" + key)) {
> +root.controller.faceConfiguration[key] = item["cfg_"+key]
> +}
`"cfg_" + key`
> UsedSensorsView.qml:24
> +import QtQuick.Layouts 1.2
> +import QtQuick.Controls 2.2 as Controls
> +import QtQml.Models 2.12
`as QQC2`
> CompactRepresentation.qml:24
> import QtQuick 2.9
> +import QtQuick.Controls 2.2 as Controls
> import QtQuick.Layouts 1.1
`as QQC2`
> Config.qml:23
> +import QtQuick.Layouts 1.1
> +import QtQuick.Controls 2.2 as Controls
> +
`as QQC2`
> CompactRepresentation.qml:24
> import QtQuick 2.9
> +import QtQuick.Controls 2.2 as Controls
> import QtQuick.Layouts 1.1
`as QQC2`
> Config.qml:22
> +import QtQuick.Layouts 1.1
> +import QtQuick.Controls 2.2 as Controls
> +
`as QQC2`
> LineChart.qml:47
> +//TODO: Have a central heading here too?
> +//TODO: Have a plasmoid config value for line thickness?
> +
Well, should we? :)
> CompactRepresentation.qml:24
> import QtQuick 2.9
> +import QtQuick.Controls 2.2 as Controls
> import QtQuick.Layouts 1.1
`as QQC2`
> Config.qml:22
> +import QtQuick.Layouts 1.1
> +import QtQuick.Controls 2.2 as Controls
> +
`as QQC2`
> Config.qml:22
> +import QtQuick.Layouts 1.1
> +import QtQuick.Controls 2.2 as Controls
> +import org.kde.ksysguard.faces 1.0 as Faces
`as QQC2`
> Config.qml:45
> +sourceModel: Sensors.SensorDataModel {
> +// FIXME: unqualified property
> +sensors: controller.sensorIds
fixit :)
> Config.qml:53
> +id: sortDescendingCheckBox
> +// or do a ComboBox like in Dolphin with pretty names "highest
> first"<->"lowest first"?
> +text: i18nc("Sort descending", "Descending")
That would be nice, yes. :) Nobody can ever figure out what "ascending" and
"descending" means in the context of sort ordering.
> FullRepresentation.qml:24
> +import QtQuick 2.12
> +import QtQuick.Controls 2.2
> +import QtQuick.Layouts 1.2
`import QtQuick.Controls 2.2 as QQC2`
> FullRepresentation.qml:102
> +//FIXME: why +2 is necessary?
> +Layout.preferredWidth: metrics.width+2
> +Layout.maximumWidth: x > 0 ? metrics.width+2 : -1
Ugh, I don't like any of this :(
> FullRepresentation.qml:141
> +
> +//See
> https://codereview.qt-project.org/c/qt/qtdeclarative/+/262876
> +onWidthChanged: Qt.callLater(function() {if (tableView.columns >
> 0) {
this was merged almost a year ago; probably not needed anymore
> FullRepresentation.qml:159
> +onSensorsChanged: {
> +//note: this re sets the models in order to make the
> table work with any new role
> +tableView.model = null;
`resets the models`
REPOSITORY
R111 KSysguard Library
REVISION DETAIL
https://phabricator.kde.org/D28922
To: mart, #plasma, ahiemstra, #vdg
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack,
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai,
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
D28922: Port Sensor Face loading from plasmoid
mart added inline comments. INLINE COMMENTS > ahiemstra wrote in SensorFaceController.h:47 > I think it would be a good idea to make this a list of ids as well. My > current use case would be the "used/total" version of the pie chart that is > used in KSysGuardQML, which would need two "total" sensors. how would that work in current faces that have this binded to that single big number inside graphs? REPOSITORY R111 KSysguard Library REVISION DETAIL https://phabricator.kde.org/D28922 To: mart, #plasma, ahiemstra, #vdg Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
D28922: Port Sensor Face loading from plasmoid
ahiemstra added inline comments. INLINE COMMENTS > mart wrote in SensorFaceController.cpp:247 > perhaps line chart? I was more thinking something along the lines of a new face that's either completely empty or displays a "not configured" message. REPOSITORY R111 KSysguard Library REVISION DETAIL https://phabricator.kde.org/D28922 To: mart, #plasma, ahiemstra Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
D28922: Port Sensor Face loading from plasmoid
mart added inline comments. INLINE COMMENTS > ahiemstra wrote in SensorFaceController.cpp:77 > Similar to above, does it still make sense to use "Plasma/Applet" here? it kinda has to, as the original idea is to be able to use any preset as it was a standalone applet, so creating a preset means you can find it directly in the widget explorer. If presets are moved somewhere else, it needs somthing that synchronizes them for the extra plasmoids to still work, which it addsa new brittle level of complexity. it is a bit annoying that is depending indirectly from libplasma for the package plugin, perhaps it could have an internal, non-plugin replacement for this package structure to have it working also when plasma is not installed > ahiemstra wrote in SensorFaceController.cpp:182 > This seems to be unused? it's used in the component->beginCreate(context); next line > ahiemstra wrote in SensorFaceController.cpp:247 > I think we should have a "default face" for when no specfic face has been set > yet, that isn't a pie chart. At least for ksysguard the default pie chart > feels weird. perhaps line chart? REPOSITORY R111 KSysguard Library REVISION DETAIL https://phabricator.kde.org/D28922 To: mart, #plasma, ahiemstra Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
D28922: Port Sensor Face loading from plasmoid
mart updated this revision to Diff 81882. mart marked 7 inline comments as done. mart added a comment. - start to port other faces - port faces to new api - add missing file - adapt to api changes - adress a part of comments REPOSITORY R111 KSysguard Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28922?vs=81078=81882 BRANCH mart/sensor_face REVISION DETAIL https://phabricator.kde.org/D28922 AFFECTED FILES CMakeLists.txt faces/CMakeLists.txt faces/ConfigAppearance.qml faces/ConfigSensors.qml faces/FaceDetailsConfig.qml faces/SensorFace.cpp faces/SensorFaceController.cpp faces/SensorFaceController.h faces/SensorFaceController_p.h faces/SensorFace_p.h faces/UsedSensorsView.qml faces/facepackages/CMakeLists.txt faces/facepackages/barchart/contents/config/main.xml faces/facepackages/barchart/contents/ui/BarChart.qml faces/facepackages/barchart/contents/ui/CompactRepresentation.qml faces/facepackages/barchart/contents/ui/Config.qml faces/facepackages/barchart/contents/ui/FullRepresentation.qml faces/facepackages/barchart/metadata.desktop faces/facepackages/linechart/contents/config/main.xml faces/facepackages/linechart/contents/ui/CompactRepresentation.qml faces/facepackages/linechart/contents/ui/Config.qml faces/facepackages/linechart/contents/ui/FullRepresentation.qml faces/facepackages/linechart/contents/ui/LineChart.qml faces/facepackages/linechart/metadata.desktop faces/facepackages/piechart/contents/config/main.xml faces/facepackages/piechart/contents/ui/CompactRepresentation.qml faces/facepackages/piechart/contents/ui/Config.qml faces/facepackages/piechart/contents/ui/FullRepresentation.qml faces/facepackages/piechart/contents/ui/PieChart.qml faces/facepackages/piechart/metadata.desktop faces/facepackages/table/contents/config/main.xml faces/facepackages/table/contents/ui/CompactRepresentation.qml faces/facepackages/table/contents/ui/Config.qml faces/facepackages/table/contents/ui/FullRepresentation.qml faces/facepackages/table/metadata.desktop faces/facepackages/textonly/contents/ui/CompactRepresentation.qml faces/facepackages/textonly/contents/ui/FullRepresentation.qml faces/facepackages/textonly/metadata.desktop faces/import/CMakeLists.txt faces/import/ExtendedLegend.qml faces/import/FacesPlugin.cpp faces/import/FacesPlugin.h faces/import/SensorFace.qml faces/import/qmldir faces/packagestructure/CMakeLists.txt faces/packagestructure/sensorface-packagestructure.json faces/packagestructure/sensorfacepackage.cpp faces/resources.qrc processcore/extended_process_list.cpp sensors/CMakeLists.txt sensors/SensorInfo_p.h sensors/declarative/CMakeLists.txt sensors/declarative/ExtendedLegend.qml sensors/declarative/qmldir To: mart, #plasma, ahiemstra Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
D28922: Port Sensor Face loading from plasmoid
ahiemstra added inline comments.
INLINE COMMENTS
> ConfigAppearance.qml:90
> +}
> +RowLayout {
> +Kirigami.FormData.label: i18n("Presets:")
It would probably be nice if we can make this a GridLayout with flow bound to
the FormLayout's wide setting. Right now, if the layout becomes less wide,
these buttons will be pushed out of bounds.
> ConfigAppearance.qml:127
> +
> +RowLayout {
> +Kirigami.FormData.label: i18n("Display Style:")
As above, these also have a tendency to get pushed out of bounds.
> SensorFaceController.cpp:43
> +
> +auto list =
> KPackage::PackageLoader::self()->listPackages(QStringLiteral("Plasma/SensorApplet"));
> +// NOTE: This will diable completely the internal in-memory cache
"Plasma/SensorApplet" should probably be changed to something non-plasma?
> SensorFaceController.cpp:77
> +clear();
> +QList plugins =
> KPackage::PackageLoader::self()->findPackages(QStringLiteral("Plasma/Applet"),
> QString(), [](const KPluginMetaData ) {
> +return plugin.value(QStringLiteral("X-Plasma-RootPath")) ==
> QStringLiteral("org.kde.plasma.systemmonitor");
Similar to above, does it still make sense to use "Plasma/Applet" here?
> SensorFaceController.cpp:182
> +//TODO: add i18n context object
> +QQmlContext *context = new QQmlContext(engine);
> +QObject *guiObject = component->beginCreate(context);
This seems to be unused?
> SensorFaceController.cpp:247
> +
> +setFaceId(d->appearanceGroup.readEntry("chartFace",
> QStringLiteral("org.kde.ksysguard.piechart")));
> +}
I think we should have a "default face" for when no specfic face has been set
yet, that isn't a pie chart. At least for ksysguard the default pie chart feels
weird.
> SensorFaceController.cpp:415
> +
> +d->faceMetadata = new KDesktopFile(d->facePackage.path() +
> QStringLiteral("metadata.desktop"));
> +
Can we define this in the package and then use filePath("metadata") or so?
> SensorFaceController.cpp:476
> +d->faceConfigUi =
> d->createConfigUi(QStringLiteral(":/FaceDetailsConfig.qml"),
> +{{QStringLiteral("controller"), QVariant::fromValue(this)},
> + {QStringLiteral("source"), d->facePackage.filePath("ui",
> QStringLiteral("Config.qml"))}});
Code style is a bit messed up here. Maybe run clang-format over the entire
thing?
> SensorFaceController.h:47
> +Q_PROPERTY(QString faceId READ faceId WRITE setFaceId NOTIFY
> faceIdChanged)
> +Q_PROPERTY(QString totalSensor READ totalSensor WRITE setTotalSensor
> NOTIFY totalSensorChanged)
> +Q_PROPERTY(QStringList sensorIds READ sensorIds WRITE setSensorIds
> NOTIFY sensorIdsChanged)
I think it would be a good idea to make this a list of ids as well. My current
use case would be the "used/total" version of the pie chart that is used in
KSysGuardQML, which would need two "total" sensors.
> SensorFaceController.h:50
> +Q_PROPERTY(QStringList sensorColors READ sensorColors WRITE
> setSensorColors NOTIFY sensorColorsChanged)
> +Q_PROPERTY(QStringList textOnlySensorIds READ textOnlySensorIds WRITE
> setTextOnlySensorIds NOTIFY textOnlySensorIdsChanged)
> +
Hmm, maybe these names are a little too use-case specific? I wonder if it would
make sense to name them "highPrioritySensorsIds", "sensorIds",
"lowPrioritySensorIds" or so.
> SensorFaceController.h:76
> +
> +//TODO: just QQuickItem
> +QQuickItem *fullRepresentation();
This seems superfluous?
> BarChart.qml:38
> +
> +stacked: plasmoid.nativeInterface.faceConfiguration.barChartStacked
> +
This should use the controller.
> Config.qml:50
> +}
> +Controls.SpinBox {
> +id: rangeFromSpin
All these are missing `editable: true` making it rather annoying to edit.
Also, we probably should set `from: -` and `to: ` or so on all
of them, the minimum and maximum range is rather undefined.
> FullRepresentation.qml:58
> +
> +Faces.ExtendedLegend {
> +Layout.fillWidth: true
This import seems to be missing?
REPOSITORY
R111 KSysguard Library
REVISION DETAIL
https://phabricator.kde.org/D28922
To: mart, #plasma, ahiemstra
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus,
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed,
jensreuterberg, abetts, sebas, apol, ahiemstra, mart
D28922: Port Sensor Face loading from plasmoid
ahiemstra added inline comments.
INLINE COMMENTS
> SensorFaceController.h:42
> +
> +class FACES_EXPORT SensorFaceController : public QObject
> +{
Can you place this class (and related classes) in the KSysGuard namespace? Then
it would match the rest of the libraries.
REPOSITORY
R111 KSysguard Library
REVISION DETAIL
https://phabricator.kde.org/D28922
To: mart, #plasma, ahiemstra
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus,
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed,
jensreuterberg, abetts, sebas, apol, ahiemstra, mart
D28922: Port Sensor Face loading from plasmoid
ahiemstra added inline comments. INLINE COMMENTS > CMakeLists.txt:52 > KF5::I18n > +KF5::Package > +KF5::ConfigCore This is no longer needed. > CMakeLists.txt:5 > > -target_link_libraries(SensorsPlugin Qt5::Qml KSysGuard::Sensors > KF5::ProcessCore) > +target_link_libraries(SensorsPlugin Qt5::Qml KSysGuard::Sensors > KF5::ProcessCore KF5::Package KF5::ConfigCore KF5::ConfigGui) > This is no longer needed. REPOSITORY R111 KSysguard Library REVISION DETAIL https://phabricator.kde.org/D28922 To: mart, #plasma, ahiemstra Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
D28922: Port Sensor Face loading from plasmoid
mart updated this revision to Diff 81078. mart added a comment. - move here faces and packagestructure REPOSITORY R111 KSysguard Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28922?vs=81019=81078 BRANCH mart/sensor_face REVISION DETAIL https://phabricator.kde.org/D28922 AFFECTED FILES CMakeLists.txt faces/ConfigAppearance.qml faces/ConfigSensors.qml faces/FaceDetailsConfig.qml faces/SensorFace.cpp faces/SensorFaceController.cpp faces/SensorFaceController.h faces/SensorFaceController_p.h faces/SensorFace_p.h faces/UsedSensorsView.qml faces/facepackages/CMakeLists.txt faces/facepackages/barchart/contents/config/main.xml faces/facepackages/barchart/contents/ui/BarChart.qml faces/facepackages/barchart/contents/ui/CompactRepresentation.qml faces/facepackages/barchart/contents/ui/Config.qml faces/facepackages/barchart/contents/ui/FullRepresentation.qml faces/facepackages/barchart/metadata.desktop faces/facepackages/linechart/contents/config/main.xml faces/facepackages/linechart/contents/ui/CompactRepresentation.qml faces/facepackages/linechart/contents/ui/Config.qml faces/facepackages/linechart/contents/ui/FullRepresentation.qml faces/facepackages/linechart/contents/ui/LineChart.qml faces/facepackages/linechart/metadata.desktop faces/facepackages/piechart/contents/config/main.xml faces/facepackages/piechart/contents/ui/CompactRepresentation.qml faces/facepackages/piechart/contents/ui/Config.qml faces/facepackages/piechart/contents/ui/FullRepresentation.qml faces/facepackages/piechart/contents/ui/PieChart.qml faces/facepackages/piechart/metadata.desktop faces/facepackages/table/contents/config/main.xml faces/facepackages/table/contents/ui/CompactRepresentation.qml faces/facepackages/table/contents/ui/Config.qml faces/facepackages/table/contents/ui/FullRepresentation.qml faces/facepackages/table/metadata.desktop faces/facepackages/textonly/contents/ui/CompactRepresentation.qml faces/facepackages/textonly/contents/ui/FullRepresentation.qml faces/facepackages/textonly/metadata.desktop faces/import/CMakeLists.txt faces/import/ExtendedLegend.qml faces/import/FacesPlugin.cpp faces/import/FacesPlugin.h faces/import/SensorFace.qml faces/import/qmldir faces/packagestructure/CMakeLists.txt faces/packagestructure/sensorface-packagestructure.json faces/packagestructure/sensorfacepackage.cpp faces/resources.qrc processcore/extended_process_list.cpp sensors/CMakeLists.txt sensors/SensorInfo_p.h sensors/declarative/CMakeLists.txt sensors/declarative/ExtendedLegend.qml sensors/declarative/qmldir To: mart, #plasma, ahiemstra Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
D28922: Port Sensor Face loading from plasmoid
mart updated this revision to Diff 81019. mart added a comment. - move all face-related stuff in own library - use the new face library REPOSITORY R111 KSysguard Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28922?vs=80982=81019 BRANCH mart/sensor_face REVISION DETAIL https://phabricator.kde.org/D28922 AFFECTED FILES CMakeLists.txt faces/ConfigAppearance.qml faces/ConfigSensors.qml faces/FaceDetailsConfig.qml faces/SensorFace.cpp faces/SensorFaceController.cpp faces/SensorFaceController.h faces/SensorFaceController_p.h faces/SensorFace_p.h faces/UsedSensorsView.qml faces/import/CMakeLists.txt faces/import/ExtendedLegend.qml faces/import/FacesPlugin.cpp faces/import/FacesPlugin.h faces/import/SensorFace.qml faces/import/qmldir faces/resources.qrc processcore/extended_process_list.cpp sensors/CMakeLists.txt sensors/SensorInfo_p.h sensors/declarative/CMakeLists.txt sensors/declarative/ExtendedLegend.qml sensors/declarative/qmldir To: mart, #plasma, ahiemstra Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
D28922: Port Sensor Face loading from plasmoid
mart updated this revision to Diff 80982. mart added a comment. - add missing file REPOSITORY R111 KSysguard Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28922?vs=80401=80982 BRANCH mart/sensor_face REVISION DETAIL https://phabricator.kde.org/D28922 AFFECTED FILES CMakeLists.txt processcore/extended_process_list.cpp sensors/CMakeLists.txt sensors/ConfigAppearance.qml sensors/ConfigSensors.qml sensors/FaceDetailsConfig.qml sensors/SensorFace.cpp sensors/SensorFaceController.cpp sensors/SensorFaceController.h sensors/SensorFaceController_p.h sensors/SensorFace_p.h sensors/SensorInfo_p.h sensors/UsedSensorsView.qml sensors/declarative/CMakeLists.txt sensors/declarative/SensorFace.qml sensors/declarative/SensorsPlugin.cpp sensors/declarative/qmldir sensors/resources.qrc To: mart, #plasma, ahiemstra Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
D28922: Port Sensor Face loading from plasmoid
ahiemstra added inline comments. INLINE COMMENTS > SensorFaceController.cpp:21 > +#include "SensorFaceController.h" > +#include "SensorFaceController_p.h" > +#include "SensorFace_p.h" This file is missing. REPOSITORY R111 KSysguard Library REVISION DETAIL https://phabricator.kde.org/D28922 To: mart, #plasma, ahiemstra Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
D28922: Port Sensor Face loading from plasmoid
mart created this revision. mart added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. mart requested review of this revision. REVISION SUMMARY The plasmoid loginc has been ported in the SensorFaceController public class it's its responsibility to instantiate the right qml files to load a face and writes all the face config in the KConfigGroup provided by the class constructor the sensorfacecontroller will always be accessible as a property from the face qml, ro read and write the config paramenters REPOSITORY R111 KSysguard Library BRANCH mart/sensor_face REVISION DETAIL https://phabricator.kde.org/D28922 AFFECTED FILES CMakeLists.txt processcore/extended_process_list.cpp sensors/CMakeLists.txt sensors/ConfigAppearance.qml sensors/ConfigSensors.qml sensors/FaceDetailsConfig.qml sensors/SensorFace.cpp sensors/SensorFaceController.cpp sensors/SensorFaceController.h sensors/SensorFace_p.h sensors/SensorInfo_p.h sensors/UsedSensorsView.qml sensors/declarative/CMakeLists.txt sensors/declarative/SensorFace.qml sensors/declarative/SensorsPlugin.cpp sensors/declarative/qmldir sensors/resources.qrc To: mart, #plasma Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
