D29081: [QStyle] Make menu titles look less like menu items

ngraham closed this revision. REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D29081 To: ngraham, #vdg, #breeze, niccolove, ndavis Cc: cblack, cfeck, ndavis, niccolove, broulik, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, ragreen,

D29081: [QStyle] Make menu titles look less like menu items

ngraham updated this revision to Diff 83066. ngraham added a comment. Compute background color in a more colorscheme-friendly way REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29081?vs=83065=83066 BRANCH menu-title-looks-less-like-a-menu-item (branched

D29081: [QStyle] Make menu titles look less like menu items

ngraham updated this revision to Diff 83065. ngraham added a comment. Fix non-rounded corners REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29081?vs=83064=83065 BRANCH menu-title-looks-less-like-a-menu-item (branched from master) REVISION DETAIL

D29081: [QStyle] Make menu titles look less like menu items

ngraham updated this revision to Diff 83064. ngraham added a comment. Rebase REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29081?vs=80924=83064 BRANCH menu-title-looks-less-like-a-menu-item (branched from master) REVISION DETAIL

D29081: [QStyle] Make menu titles look less like menu items

ndavis added a comment. In D29081#665226 , @cblack wrote: > In D29081#665203 , @ndavis wrote: > > > Big +1 to the idea, but this shouldn't use `darker()` because that won't look right in Breeze

D29081: [QStyle] Make menu titles look less like menu items

cblack added a comment. In D29081#665203 , @ndavis wrote: > Big +1 to the idea, but this shouldn't use `darker()` because that won't look right in Breeze Dark. Personally, I think this will look fine when always using `darker()`.

D29081: [QStyle] Make menu titles look less like menu items

cfeck added a comment. Instead of darker, you could use the text color with very small alpha. REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D29081 To: ngraham, #vdg, #breeze, niccolove, ndavis Cc: cfeck, ndavis, niccolove, broulik, plasma-devel, Orage, LeGast00n,

D29081: [QStyle] Make menu titles look less like menu items

cfeck added a comment. What a small difference that makes such a large difference! REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D29081 To: ngraham, #vdg, #breeze, niccolove, ndavis Cc: cfeck, ndavis, niccolove, broulik, plasma-devel, Orage, LeGast00n,

D29081: [QStyle] Make menu titles look less like menu items

ngraham planned changes to this revision. ngraham added a comment. I messed up the rounded top corner too. Will revise. REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D29081 To: ngraham, #vdg, #breeze, niccolove, ndavis Cc: ndavis, niccolove, broulik, plasma-devel,

D29081: [QStyle] Make menu titles look less like menu items

ndavis requested changes to this revision. ndavis added a comment. This revision now requires changes to proceed. Big +1 to the idea, but this shouldn't use `darker()` because that won't look right in Breeze Dark. REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D29081

D29081: [QStyle] Make menu titles look less like menu items

niccolove accepted this revision as: niccolove. niccolove added a comment. This revision is now accepted and ready to land. VDG wise, this looks good and consistent. REPOSITORY R31 Breeze BRANCH menu-title-looks-less-like-a-menu-item (branched from master) REVISION DETAIL

D29081: [QStyle] Make menu titles look less like menu items

ngraham updated this revision to Diff 80924. ngraham added a comment. Make the title look more like Kirigami section separators REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29081?vs=80834=80924 BRANCH menu-title-looks-less-like-a-menu-item (branched

D29081: [QStyle] Make menu titles look less like menu items

ngraham added a comment. In D29081#654374 , @broulik wrote: > Not a fan of making it hard to read. I agree that it makes it more obvious it's not clickable but we deliberately changed many places that used disabled menu items as sections to use

D29081: [QStyle] Make menu titles look less like menu items

broulik added a comment. Not a fan of making it hard to read. I agree that it makes it more obvious it's not clickable but we deliberately changed many places that used disabled menu items as sections to use proper sections for readability. REPOSITORY R31 Breeze REVISION DETAIL

D29081: [QStyle] Make menu titles look less like menu items

ngraham created this revision. ngraham added reviewers: VDG, Breeze. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY The look of Breeze menu titles has always slightly bothered me since they have the same