D29144: [applets/weather] Improve UX for selecting a weather station

[Nathaniel Graham]

This revision was automatically updated to reflect the committed changes.
Closed by commit R114:ef213aaa5a2c: [applets/weather] Improve UX for selecting 
a weather station (authored by ngraham).

REPOSITORY
  R114 Plasma Addons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29144?vs=81049&id=81102

REVISION DETAIL
  https://phabricator.kde.org/D29144

AFFECTED FILES
  applets/weather/package/contents/ui/config/WeatherStationPicker.qml

To: ngraham, #vdg, #plasma, broulik, spstarr, ndavis
Cc: ndavis, spstarr, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29144: [applets/weather] Improve UX for selecting a weather station

[Nathaniel Graham]

ngraham added a comment.


  In another patch, sure, I can work on that.

REPOSITORY
  R114 Plasma Addons

BRANCH
  better-weather-station-selection-ux (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29144

To: ngraham, #vdg, #plasma, broulik, spstarr
Cc: ndavis, spstarr, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29144: [applets/weather] Improve UX for selecting a weather station

[Noah Davis]

ndavis added a comment.


  Can you also make locations show up as you type so that you don't need a 
search button?

REPOSITORY
  R114 Plasma Addons

BRANCH
  better-weather-station-selection-ux (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29144

To: ngraham, #vdg, #plasma, broulik, spstarr
Cc: ndavis, spstarr, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29144: [applets/weather] Improve UX for selecting a weather station

[Shawn Starr]

spstarr requested changes to this revision.
spstarr added a comment.
This revision now requires changes to proceed.


  Hoping to get back into working on the backend as for how many, well depends 
how many weather providers will provide free API keys to use, I guess this is 
ok for now then.  +1

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D29144

To: ngraham, #vdg, #plasma, broulik, spstarr
Cc: spstarr, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29144: [applets/weather] Improve UX for selecting a weather station

[Nathaniel Graham]

ngraham added a comment.


  In D29144#656123 , @spstarr wrote:
  
  > -1 From me, what happens if we have more Weather Providers won't the dialog 
box be cluttered?  If we can sort that out then +1
  
  
  Is that in the cards? Right now we have only four. Even if it goes up to 
eight, I don't think it's really a problem. The window is quite small and 
there's room to grow if needed, and this patch is solving a usability issue 
with the current approach.

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D29144

To: ngraham, #vdg, #plasma, broulik
Cc: spstarr, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29144: [applets/weather] Improve UX for selecting a weather station

[Kai Uwe Broulik]

broulik added a comment.


  > what happens if we have more Weather Providers won't the dialog box be 
cluttered?
  
  I wonder how many we actually offer?
  Maybe the old way but with a more obvious label could work. Dunno...

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D29144

To: ngraham, #vdg, #plasma, broulik
Cc: spstarr, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29144: [applets/weather] Improve UX for selecting a weather station

[Shawn Starr]

spstarr added a comment.


  What happens if we have more Weather Providers won't the dialog box be 
cluttered?

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D29144

To: ngraham, #vdg, #plasma, broulik
Cc: spstarr, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29144: [applets/weather] Improve UX for selecting a weather station

[Friedrich W. H. Kossebau]

kossebau resigned from this revision.
kossebau added a comment.


  No time left over for Plasma currently,  sorry,

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D29144

To: ngraham, #vdg, #plasma, broulik
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29144: [applets/weather] Improve UX for selecting a weather station

[Nathaniel Graham]

ngraham updated this revision to Diff 81049.
ngraham marked 2 inline comments as done.
ngraham added a comment.


  Address review comments

REPOSITORY
  R114 Plasma Addons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29144?vs=81048&id=81049

BRANCH
  better-weather-station-selection-ux (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29144

AFFECTED FILES
  applets/weather/package/contents/ui/config/WeatherStationPicker.qml

To: ngraham, #vdg, #plasma, broulik, kossebau
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29144: [applets/weather] Improve UX for selecting a weather station

[Kai Uwe Broulik]

broulik added a comment.


  +1 that hidden flag thing always bugged me

INLINE COMMENTS

> WeatherStationPicker.qml:66
> +ColumnLayout {
> +Kirigami.FormData.label: i18n("Select weather providers:")
> +Kirigami.FormData.buddyFor: children[1] // 0 is the Repeater

Perhaps just "Weather Providers:"?

> WeatherStationPicker.qml:67
> +Kirigami.FormData.label: i18n("Select weather providers:")
> +Kirigami.FormData.buddyFor: children[1] // 0 is the Repeater
> +

How about `calendarPluginsRepeater.itemAt(0)`

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D29144

To: ngraham, #vdg, #plasma, broulik
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29144: [applets/weather] Improve UX for selecting a weather station

[Nathaniel Graham]

ngraham created this revision.
ngraham added reviewers: VDG, Plasma, broulik.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
ngraham requested review of this revision.

REVISION SUMMARY
  This patch improves the UX of selecting a weather station by re-implementing 
it a column
  o checkboxes that are visible by default at the top of the window, so that 
selecting a
  weather station is follows the local top-to-bottom flow of the page.
  
  When no weather stations are selected (as it is by default), everything else 
in the
  window is disabled so it's completely obvious what you need to do to proceed.

TEST PLAN
  F8256457: vokoscreenNG-2020-04-23_14-56-01.webm 


REPOSITORY
  R114 Plasma Addons

BRANCH
  better-weather-station-selection-ux (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29144

AFFECTED FILES
  applets/weather/package/contents/ui/config/WeatherStationPicker.qml

To: ngraham, #vdg, #plasma, broulik
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart