D29155: [Fonts KCM] Remove redundant nearestExistingFont()

This revision was automatically updated to reflect the committed changes. Closed by commit R119:0325d6981810: [Fonts KCM] Remove redundant nearestExistingFont() (authored by ahmadsamir). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

D29155: [Fonts KCM] Remove redundant nearestExistingFont()

bport accepted this revision. bport added a comment. ok then ship it REPOSITORY R119 Plasma Desktop BRANCH l-setnearest (branched from master) REVISION DETAIL https://phabricator.kde.org/D29155 To: ahmadsamir, #plasma, bport, ngraham Cc: ngraham, plasma-devel, Orage, LeGast00n,

D29155: [Fonts KCM] Remove redundant nearestExistingFont()

ahmadsamir added a comment. In D29155#663178 , @bport wrote: > I don't think we will have same behavior, we don't only check name but also size, type... > If we are ok to fallback in all case to the same font that can work. > > From your

D29155: [Fonts KCM] Remove redundant nearestExistingFont()

bport added a comment. I don't think we will have same behavior, we don't only check name but also size, type... If we are ok to fallback in all case to the same font that can work. From your test plan, something look strange you don't end with a monospaced font for fixed font as

D29155: [Fonts KCM] Remove redundant nearestExistingFont()

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Fixes the bug for me and seems like the right solution. REPOSITORY R119 Plasma Desktop BRANCH l-setnearest (branched from master) REVISION DETAIL

D29155: [Fonts KCM] Remove redundant nearestExistingFont()

ahmadsamir updated this revision to Diff 81110. ahmadsamir edited the summary of this revision. ahmadsamir removed a reviewer: ngraham. ahmadsamir added a comment. Tweak commit message REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

D29155: [Fonts KCM] Remove redundant nearestExistingFont()

ahmadsamir added a reviewer: ngraham. ahmadsamir added a comment. If that diff is a no-go, it'll have to be D27785 . REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D29155 To: ahmadsamir, #plasma, bport, ngraham Cc:

D29155: [Fonts KCM] Remove redundant nearestExistingFont()

ahmadsamir created this revision. ahmadsamir added reviewers: Plasma, bport. Herald added a project: Plasma. ahmadsamir requested review of this revision. REVISION SUMMARY It seems that nearestExistingFont() gets the same result of `fc-match font-name`, which is basically the sans serif