D29176: [GTK Subpage] Hide Breeze Dark for GTK3

2020-04-25 Thread Mikhail Zolotukhin 
This revision was automatically updated to reflect the committed changes.
Closed by commit R119:fd6f3bacc91e: [GTK Subpage] Hide Breeze Dark for GTK3 
(authored by gikari).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29176?vs=81166=81178

REVISION DETAIL
  https://phabricator.kde.org/D29176

AFFECTED FILES
  kcms/style/gtkthemesmodel.cpp

To: gikari, cblack
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29176: [GTK Subpage] Hide Breeze Dark for GTK3

2020-04-25 Thread Carson Black 
cblack added a comment.


  I'd probably like to introduce a custom "should show theme variant" attribute 
to theme indexes, but this will be fine for now.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  hide-breeze-gtk-dark (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29176

To: gikari, cblack
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29176: [GTK Subpage] Hide Breeze Dark for GTK3

2020-04-25 Thread Nathaniel Graham 
ngraham added a comment.


  +1

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D29176

To: gikari, cblack
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29176: [GTK Subpage] Hide Breeze Dark for GTK3

2020-04-25 Thread Mikhail Zolotukhin 
gikari created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
gikari requested review of this revision.

REVISION SUMMARY
  Given, that Breeze GTK grabs its colors from color scheme and Breeze
  Dark doesn't do that creating by that confusion within the users, dark
  theme should be hidden from the list of available GTK3 themes.
  
  Keeping dark variant may be useful for other desktop environments where
  there is no dynamic recoloring and there aren't any color scheme settings.
  
  CCBUG: 413198

TEST PLAN
  Check if the GTK3 combobox in Application Style > GNOME/GTK Application Style 
does not have the "Breeze-Dark" option.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  hide-breeze-gtk-dark (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29176

AFFECTED FILES
  kcms/style/gtkthemesmodel.cpp

To: gikari
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart