D29359: Add context for "Automatic" strings

2020-05-09 Thread Yuri Chornoivan
This revision was not accepted when it landed; it landed in state "Needs 
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit R116:2bf19bb7c59d: Add context for Automatic 
strings (authored by yurchor).

REPOSITORY
  R116 Plasma Network Management Applet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29359?vs=81774=82379

REVISION DETAIL
  https://phabricator.kde.org/D29359

AFFECTED FILES
  libs/editor/settings/ui/802-1x.ui
  libs/editor/settings/ui/connectionwidget.ui
  libs/editor/settings/ui/infiniband.ui
  libs/editor/settings/ui/ipv4.ui
  libs/editor/settings/ui/ipv6.ui
  libs/editor/settings/ui/wificonnectionwidget.ui
  libs/editor/settings/ui/wiredconnectionwidget.ui

To: yurchor, #plasma, jgrulich, davidedmundson, ngraham, ecuadra
Cc: ecuadra, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D29359: Add context for "Automatic" strings

2020-05-09 Thread Eloy Cuadra
ecuadra accepted this revision.
ecuadra added a comment.


  Yes. Sorry for the delay.

REPOSITORY
  R116 Plasma Network Management Applet

REVISION DETAIL
  https://phabricator.kde.org/D29359

To: yurchor, #plasma, jgrulich, davidedmundson, ngraham, ecuadra
Cc: ecuadra, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D29359: Add context for "Automatic" strings

2020-05-09 Thread Yuri Chornoivan
yurchor added a comment.


  @ecuadra Ping?

REPOSITORY
  R116 Plasma Network Management Applet

REVISION DETAIL
  https://phabricator.kde.org/D29359

To: yurchor, #plasma, jgrulich, davidedmundson, ngraham, ecuadra
Cc: ecuadra, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D29359: Add context for "Automatic" strings

2020-05-03 Thread Yuri Chornoivan
yurchor updated this revision to Diff 81774.
yurchor added a comment.


  Use "comment" instead of "context", fix extracomment according to
  
  https://tsdgeos.blogspot.com/2011/05/qt-designer-texts-disambiguation-vs.html

REPOSITORY
  R116 Plasma Network Management Applet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29359?vs=81736=81774

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D29359

AFFECTED FILES
  libs/editor/settings/ui/802-1x.ui
  libs/editor/settings/ui/connectionwidget.ui
  libs/editor/settings/ui/infiniband.ui
  libs/editor/settings/ui/ipv4.ui
  libs/editor/settings/ui/ipv6.ui
  libs/editor/settings/ui/wificonnectionwidget.ui
  libs/editor/settings/ui/wiredconnectionwidget.ui

To: yurchor, #plasma, jgrulich, davidedmundson, ngraham, ecuadra
Cc: ecuadra, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D29359: Add context for "Automatic" strings

2020-05-02 Thread Eloy Cuadra
ecuadra requested changes to this revision.
ecuadra added a comment.
This revision now requires changes to proceed.


  I think the right attribute to adding context to .ui files is "comment" 
instead of "context". The attribute "context" is only for .rc and .kcfg files 
;-)
  See https://api.kde.org/frameworks/ki18n/html/prg_guide.html#nocpp_ctxt

REPOSITORY
  R116 Plasma Network Management Applet

REVISION DETAIL
  https://phabricator.kde.org/D29359

To: yurchor, #plasma, jgrulich, davidedmundson, ngraham, ecuadra
Cc: ecuadra, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D29359: Add context for "Automatic" strings

2020-05-02 Thread Yuri Chornoivan
yurchor created this revision.
yurchor added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
Herald added a reviewer: jgrulich.
yurchor requested review of this revision.

REVISION SUMMARY
  "Some of these topics are masculine gender and others are feminine gender, as 
"automatic" should be. The result is that I can't translate "automatic" 
correctly in Spanish (and other languages)." -- Eloy Cuadra, Spanish 
translation coordinator

TEST PLAN
  Should work as is.

REPOSITORY
  R116 Plasma Network Management Applet

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D29359

AFFECTED FILES
  libs/editor/settings/ui/802-1x.ui
  libs/editor/settings/ui/connectionwidget.ui
  libs/editor/settings/ui/infiniband.ui
  libs/editor/settings/ui/ipv4.ui
  libs/editor/settings/ui/ipv6.ui
  libs/editor/settings/ui/wificonnectionwidget.ui
  libs/editor/settings/ui/wiredconnectionwidget.ui

To: yurchor, #plasma, jgrulich
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart