D29623: Fix Warning about KF5::KSysGuard target being deprecated

[Méven Car]

meven added a comment.


  Improved by D29628 

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D29623

To: meven, #plasma, ahiemstra, davidedmundson
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29623: Fix Warning about KF5::KSysGuard target being deprecated

[Arjen Hiemstra]

ahiemstra added a comment.


  Uh, I'm not sure how this fixes anything? It'll remove the warning but it 
means anything using the previous KF5:: namespaced targets is now broken. So 
this at least needs a follow up to change those usages.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D29623

To: meven, #plasma, ahiemstra, davidedmundson
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29623: Fix Warning about KF5::KSysGuard target being deprecated

[Méven Car]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:d2c57378479a: Fix Warning about KF5::KSysGuard target 
being deprecated (authored by meven).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29623?vs=82504&id=82506

REVISION DETAIL
  https://phabricator.kde.org/D29623

AFFECTED FILES
  CMakeLists.txt

To: meven, #plasma, ahiemstra, davidedmundson
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29623: Fix Warning about KF5::KSysGuard target being deprecated

[David Edmundson]

davidedmundson added a comment.


  thanks

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D29623

To: meven, #plasma, ahiemstra, davidedmundson
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29623: Fix Warning about KF5::KSysGuard target being deprecated

[Méven Car]

meven created this revision.
meven added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
meven requested review of this revision.

REVISION SUMMARY
  Warnings such as:
  
CMake Warning at 
/usr/lib/x86_64-linux-gnu/cmake/KF5SysGuard/KF5SysGuardConfig.cmake:37 (me
ssage):
  The KF5:: namespace for KSysGuard targets is deprecated.  Please use
   KSysGuard as namespace.
 Call Stack (most recent call first):
   /usr/share/ECM/find-modules/FindKF5.cmake:74 (find_package)
   CMakeLists.txt:55 (find_package)

TEST PLAN
  cmake does not output those warnings

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D29623

AFFECTED FILES
  CMakeLists.txt

To: meven, #plasma
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart