D29784: Hardcode less colorSets

[Nathaniel Graham]

ngraham added a comment.


  Fixed the Kirigami half of this in D29785 
. Just address the inline comment and then 
this is good to go!

REPOSITORY
  R134 Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D29784

To: apol, #plasma, ngraham
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29784: Hardcode less colorSets

[Nathaniel Graham]

ngraham requested changes to this revision.
ngraham added a comment.
This revision now requires changes to proceed.


  Now the tiny toolbar above the sidebar is a different color from the one 
beside it: F8323489: Screenshot_20200515_105617.png 

  
  It's appropriate for the views to have the view background color (off-white), 
but the toolbar is supposed to use the window background color (gray-ish), not 
the view background color. Why isn't that working?

INLINE COMMENTS

> SourcesPage.qml:27
>  
> +Kirigami.Theme.colorSet: Kirigami.Theme.View
> +Kirigami.Theme.inherit: false

These should not be needed at all

REPOSITORY
  R134 Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D29784

To: apol, #plasma, ngraham
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29784: Hardcode less colorSets

[Aleix Pol Gonzalez]

apol created this revision.
apol added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
apol requested review of this revision.

REVISION SUMMARY
  We were overriding them on the background only and it would play weird with 
the
  feature where the toolbar looks the same as the page.
  
  BUG: 421571

TEST PLAN
  Still feels a bit random that it keeps changing but at least it looks 
consistent.

REPOSITORY
  R134 Discover Software Store

BRANCH
  Plasma/5.19

REVISION DETAIL
  https://phabricator.kde.org/D29784

AFFECTED FILES
  discover/qml/ApplicationsListPage.qml
  discover/qml/BrowsingPage.qml
  discover/qml/SourcesPage.qml
  discover/qml/UpdatesPage.qml

To: apol, #plasma
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart