D29831: Update availableScreenRect when a panel moves to another screen
ngraham closed this revision. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D29831 To: akandaurov, #plasma, davidedmundson Cc: broulik, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
D29831: Update availableScreenRect when a panel moves to another screen
akandaurov added a comment. The cases where I can reproduce that bug don't seem to be affected by the patch. The first case is connecting the same monitor with both VGA and DVI cables and swapping the outputs relative position along with swapping the primary output at the same time, and the second one involves placing the task manager widget on the desktop and disconnecting and reconnecting the primary monitor. I also experience completely disappearing taskbar buttons in certain cases, this also doesn't seem to be affected. As a side note, all those glitches get reverted when I enter panel customization or taskbar settings, and what looks like the cause is QQmlEngine::retranslate() getting called which updates all the QML bindings as a side effect. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D29831 To: akandaurov Cc: broulik, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
D29831: Update availableScreenRect when a panel moves to another screen
broulik added a comment. Could that also mitigate task manager showing windows of the wrong screen in certain scenarios? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D29831 To: akandaurov Cc: broulik, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
D29831: Update availableScreenRect when a panel moves to another screen
akandaurov created this revision. akandaurov added a project: Plasma. Herald added a subscriber: plasma-devel. akandaurov requested review of this revision. REVISION SUMMARY When disconnecting the primary screen on a dual monitor setup and reconnecting it back, the available size of the secondary screen desktop may be reduced to the thickness of the primary screen panel, as can be seen by dragging a rubber band or trying to move some widgets. This apparently happens because the QML bindings had last been updated at the short moment when both panels were temporarily placed on the same screen. Update availableScreenRect therefore when a panel changes its screen. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D29831 AFFECTED FILES shell/shellcorona.cpp To: akandaurov Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
