D29845: Added option to change grid thickness

[Piotr Kąkol]

piotrkakol added a comment.


  In D29845#674882 , @mart wrote:
  
  > please use gitlab on invent.kde.org for new review requests
  
  
  I logged in on that page and I don't know what to do. Why don't I just add 
reviewers from my previous Binary Clock widget diffs?
  
  In D29845#674884 , @mart wrote:
  
  > couldn't also gridThickness automatically scale itself without having to 
expose it to the user?
  
  
  It could be done in another diff as it's another functionality. However, I 
would need to think of a formula that would do it. Because when you have fixed 
taskbar height and border thickness you can calculate square size (which is how 
it works after this diff), when you have fixed height and square size you can 
calculate border thickness (which is inferior idea imo). But given taskbar 
height, to calculate both square size and border thickness you would need to 
know the ratio between them or ratio on of them to the taskbar size. And I 
don't know how to choose the best ratio that is not arbitrary.

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D29845

To: piotrkakol
Cc: mart, gladhorn, ngraham, davidedmundson, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra

D29845: Added option to change grid thickness

[Marco Martin]

mart added a comment.


  couldn't also gridThickness automatically scale itself without having to 
expose it to the user?

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D29845

To: piotrkakol
Cc: mart, gladhorn, ngraham, davidedmundson, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra

D29845: Added option to change grid thickness

[Marco Martin]

mart added a comment.


  please use gitlab on invent.kde.org for new review requests

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D29845

To: piotrkakol
Cc: mart, gladhorn, ngraham, davidedmundson, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra

D29845: Added option to change grid thickness

[Piotr Kąkol]

piotrkakol added a comment.


  @ngraham It does scale smooth-ish-ly according to taskbar size. You can see 
that square size (dotSize in BinaryClock.qml) is calculated based on taskbar 
size (height for horizontal taskbar and width for vertical taskbar). When you 
change taskbar size, binary clock changes size as well.
  F8393018: Binary clock resize.gif 

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D29845

To: piotrkakol
Cc: gladhorn, ngraham, davidedmundson, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart

D29845: Added option to change grid thickness

[Nathaniel Graham]

ngraham added a comment.


  Would it make sense to have it scale smoothly according to panel size by 
default?

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D29845

To: piotrkakol
Cc: gladhorn, ngraham, davidedmundson, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart

D29845: Added option to change grid thickness

[Piotr Kąkol]

piotrkakol added a comment.


  This is probably the last diff from my initial Binary Clock rework from 
D13937 .

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D29845

To: piotrkakol
Cc: gladhorn, ngraham, davidedmundson, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart

D29845: Added option to change grid thickness

[Piotr Kąkol]

piotrkakol created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
piotrkakol requested review of this revision.

REVISION SUMMARY
  Before these changes grid took a lot of space, especially for smaller 
taskbars. Even with grid disabled there were big spaces between squares that 
was not used. Now users can decrease grid thickness which will increase squares 
size making the clock bigger and easier to read.

REPOSITORY
  R114 Plasma Addons

BRANCH
  grid-thickness-option (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29845

AFFECTED FILES
  applets/binary-clock/package/contents/config/main.xml
  applets/binary-clock/package/contents/ui/BinaryClock.qml
  applets/binary-clock/package/contents/ui/Dot.qml
  applets/binary-clock/package/contents/ui/DotColumn.qml
  applets/binary-clock/package/contents/ui/configGeneral.qml

To: piotrkakol
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart