D3790: RFC: [Lock Screen] Indicate keyboard layout when unlocking failed

[Nathaniel Graham]

ngraham added a comment.


  I liked this...
  
  Are you going to try again with a different style of notification or 
something?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D3790

To: broulik, #plasma, #vdg, ngraham
Cc: abetts, ngraham, colomar, gregormi, mart, graesslin, plasma-devel, ragreen, 
Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol

D3790: RFC: [Lock Screen] Indicate keyboard layout when unlocking failed

[Andres Betts]

abetts added a comment.


  What does this look like now after the changes? Screenshot? Video? :D

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D3790

To: broulik, #plasma, #vdg, ngraham
Cc: abetts, ngraham, colomar, gregormi, mart, graesslin, plasma-devel, ragreen, 
Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol

D3790: RFC: [Lock Screen] Indicate keyboard layout when unlocking failed

[Nathaniel Graham]

ngraham added a comment.


  Here's an idea shamelessly stolen from a blog commenter: how about showing 
the current keyboard layout next to the text field, instead of down in the 
corner? That way users would see upfront that they're using (or not using) the 
keyboard layout that they expect.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D3790

To: broulik, #plasma, #vdg, ngraham
Cc: abetts, ngraham, colomar, gregormi, mart, graesslin, plasma-devel, ragreen, 
Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol

D3790: RFC: [Lock Screen] Indicate keyboard layout when unlocking failed

[Nathaniel Graham]

ngraham added a comment.


  Shall we land this, or are there any other objections?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D3790

To: broulik, #plasma, #vdg, ngraham
Cc: abetts, ngraham, colomar, gregormi, mart, graesslin, plasma-devel, ragreen, 
Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol

D3790: RFC: [Lock Screen] Indicate keyboard layout when unlocking failed

[Kai Uwe Broulik]

broulik added a comment.


  Well, the original design also only showed it on error

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D3790

To: broulik, #plasma, #vdg, ngraham
Cc: abetts, ngraham, colomar, gregormi, mart, graesslin, plasma-devel, ragreen, 
Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol

D3790: RFC: [Lock Screen] Indicate keyboard layout when unlocking failed

[Nathaniel Graham]

ngraham added a comment.


  I know, that's what I'm saying. For Caps Lock, we actually show the status. 
For this, it seems weird not to do the same. In other words, I like your 
original wording (or something like it) better. :)

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D3790

To: broulik, #plasma, #vdg, ngraham
Cc: abetts, ngraham, colomar, gregormi, mart, graesslin, plasma-devel, ragreen, 
Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol

D3790: RFC: [Lock Screen] Indicate keyboard layout when unlocking failed

[Kai Uwe Broulik]

broulik added a comment.


  We do have a capslock indication that shows up as soon as capslock is enabled.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D3790

To: broulik, #plasma, #vdg, ngraham
Cc: abetts, ngraham, colomar, gregormi, mart, graesslin, plasma-devel, ragreen, 
Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol

D3790: RFC: [Lock Screen] Indicate keyboard layout when unlocking failed

[Nathaniel Graham]

ngraham added a comment.


  I dunno about "Check your keyboard layout". Would we say "Check your caps 
lock key?" Instead, we actually show you whether your caps lock key is pressed 
or not.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D3790

To: broulik, #plasma, #vdg, ngraham
Cc: abetts, ngraham, colomar, gregormi, mart, graesslin, plasma-devel, ragreen, 
Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol

D3790: RFC: [Lock Screen] Indicate keyboard layout when unlocking failed

[Kai Uwe Broulik]

broulik updated this revision to Diff 33013.
broulik edited the summary of this revision.
broulik edited the test plan for this revision.
broulik added a comment.


  - Simplify

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D3790?vs=9288=33013

REVISION DETAIL
  https://phabricator.kde.org/D3790

AFFECTED FILES
  lookandfeel/contents/components/KeyboardLayoutButton.qml
  lookandfeel/contents/lockscreen/LockScreenUi.qml

To: broulik, #plasma, #vdg, ngraham
Cc: abetts, ngraham, colomar, gregormi, mart, graesslin, plasma-devel, ragreen, 
Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol

D3790: RFC: [Lock Screen] Indicate keyboard layout when unlocking failed

[Nathaniel Graham]

ngraham added a comment.


  In D3790#253155 , @abetts wrote:
  
  > Also, will this message show even though there is only one keyboard layout 
enabled?
  
  
  No
  
  > Or will it only show when there are multiple layouts?
  
  Yes

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D3790

To: broulik, #plasma, #vdg, ngraham
Cc: abetts, ngraham, colomar, gregormi, mart, graesslin, plasma-devel, ragreen, 
Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol

D3790: RFC: [Lock Screen] Indicate keyboard layout when unlocking failed

[Andres Betts]

abetts added a comment.


  Can it say something like "Unlocking failed. Check your keyboard layout" ? I 
feel it is more generic. Also, will this message show even though there is only 
one keyboard layout enabled? Or will it only show when there are multiple 
layouts?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D3790

To: broulik, #plasma, #vdg, ngraham
Cc: abetts, ngraham, colomar, gregormi, mart, graesslin, plasma-devel, ragreen, 
Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol

D3790: RFC: [Lock Screen] Indicate keyboard layout when unlocking failed

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  Seems sane to me since it's only shown for the minority of users with 
multiple keyboard layouts, for whom this may be a legitimate problem.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D3790

To: broulik, #plasma, #vdg, ngraham
Cc: ngraham, colomar, gregormi, mart, graesslin, plasma-devel, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D3790: RFC: [Lock Screen] Indicate keyboard layout when unlocking failed

[Kai Uwe Broulik]

broulik added a comment.


  So, should I go forward with this now or abandon it?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D3790

To: broulik, #plasma:_design, #plasma
Cc: colomar, gregormi, mart, graesslin, plasma-devel, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

[Differential] [Commented On] D3790: RFC: [Lock Screen] Indicate keyboard layout when unlocking failed

[colomar (Thomas Pfeiffer)]

colomar added a comment.


  We always have to keep in mind that usind multiple layouts is an advanced 
feature used by a minority of users. Therefore, as long as a feature only 
becomes active when there are multiple layouts (and in this case only when 
multiple layouts are used _and_ the login failed), we do not need to worry too 
much about UI clutter.
  For that reason, I don't see mich of an issue with the patch.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D3790

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma, #plasma:_design
Cc: colomar, gregormi, mart, graesslin, plasma-devel, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas

[Differential] [Commented On] D3790: RFC: [Lock Screen] Indicate keyboard layout when unlocking failed

[gregormi (gregormi)]

gregormi added a comment.


  As I wrote here (https://bugs.kde.org/show_bug.cgi?id=373668#c14) in my 
experience a combination of different things (only one of them being the 
keyboard layout) is responsible for wrong password entry. I believe novice 
users would be happy if they were given detailed hints what might be wrong 
(especially when they are at the login screen where it is currently not 
possible to run a web search to get help). From this point of view, having this 
RFC implemented would be step in the right direction.
  
  (For experienced users the eye button Kai mentioned here 
(https://bugs.kde.org/show_bug.cgi?id=373668#c15) would be good enough.)

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D3790

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma, #plasma:_design
Cc: gregormi, mart, graesslin, plasma-devel, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas

[Differential] [Commented On] D3790: RFC: [Lock Screen] Indicate keyboard layout when unlocking failed

[mart (Marco Martin)]

mart added a comment.


  isn't this making the thing redundant?
  if the complaints about the indicator being not noticeable are valid, that 
should be solved at the root, if they aren't then there is not much need of 
this?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D3790

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma, #plasma:_design
Cc: mart, graesslin, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas

[Differential] [Commented On] D3790: RFC: [Lock Screen] Indicate keyboard layout when unlocking failed

[Martin Gräßlin]

graesslin added a comment.


  Honestly, I don't think that's needed at all. I think that is a non-issue in 
truth. Yes we have complaints about it and we adjusted the theme by making the 
selection more clear. Also we have the show password field.
  
  I don't think that having the language shown there helps anything in real 
world and just clutters up the ui for most users.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D3790

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma, #plasma:_design
Cc: graesslin, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas

[Differential] [Request, 49 lines] D3790: RFC: [Lock Screen] Indicate keyboard layout when unlocking failed

[broulik (Kai Uwe Broulik)]

broulik created this revision.
broulik added reviewers: Plasma, Plasma: Design.
broulik set the repository for this revision to R120 Plasma Workspace.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  If the user has more than one keyboard layout and not the first one ("the 
default" / "the primary"?) is used, indicate which keyboard is used with a 
clickable link to toggle to the next one.
  
  BUG: 373668

TEST PLAN
  F866599: Screenshot_20161222_141410.png 
  
  Usability: This additional link is only shown when the user has more than one 
layout and the currently selected one isn't the top-most as configured in 
keyboard layouts settings. The link switches to the next layout (as if the user 
was clicking the switcher in the bottom left corner). It can also be clicked 
multiple times to switch up until the first layout is reached.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D3790

AFFECTED FILES
  lookandfeel/contents/components/KeyboardLayoutButton.qml
  lookandfeel/contents/components/SessionManagementScreen.qml
  lookandfeel/contents/lockscreen/LockScreenUi.qml

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma, #plasma:_design
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas