D4290: [Calculator Runner] Use "approximate" approximation mode
lueck added a comment. OK from german team REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D4290 To: broulik, #plasma_workspaces, mart Cc: lueck, yurchor, kde-i18n-doc, mart, plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol
D4290: [Calculator Runner] Use "approximate" approximation mode
yurchor added a comment. In https://phabricator.kde.org/D4290#98033, @broulik wrote: > @kde-i18n-doc I'd like to ask for an exception to backport this fix to Plasma 5.8 (due mid of May) and Plasma 5.9 (due 25 April) as it is a rather severe, easily triggerable, memory leak/crash fix. > Initially it would have been without a new translation but as silently rounding results isn't ideal, I had to add a hint "Approximation" to it. No objections from Ukrainian team. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D4290 To: broulik, #plasma_workspaces, mart Cc: yurchor, kde-i18n-doc, mart, plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol
D4290: [Calculator Runner] Use "approximate" approximation mode
broulik added a subscriber: kde-i18n-doc. broulik added a comment. @kde-i18n-doc I'd like to ask for an exception to backport this fix to Plasma 5.8 (due mid of May) and Plasma 5.9 (due 25 April) as it is a rather severe, easily triggerable, memory leak/crash fix. Initially it would have been without a new translation but as silently rounding results isn't ideal, I had to add a hint "Approximation" to it. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D4290 To: broulik, #plasma_workspaces, mart Cc: kde-i18n-doc, mart, plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol
D4290: [Calculator Runner] Use "approximate" approximation mode
This revision was automatically updated to reflect the committed changes. Closed by commit R120:df7f1ed1eb7d: [Calculator Runner] Use "approximate" approximation mode (authored by broulik). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4290?vs=10979=12873 REVISION DETAIL https://phabricator.kde.org/D4290 AFFECTED FILES runners/calculator/calculatorrunner.cpp runners/calculator/calculatorrunner.h runners/calculator/qalculate_engine.cpp runners/calculator/qalculate_engine.h To: broulik, #plasma_workspaces, mart Cc: mart, plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol
D4290: [Calculator Runner] Use "approximate" approximation mode
mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D4290 To: broulik, #plasma_workspaces, mart Cc: mart, plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol
[Differential] [Commented On] D4290: [Calculator Runner] Use "approximate" approximation mode
broulik added a comment. Ping REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D4290 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, #plasma_workspaces, mart Cc: mart, plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol
[Differential] [Updated, 24 lines] D4290: [Calculator Runner] Use "approximate" approximation mode
broulik updated the summary for this revision. broulik updated this revision to Diff 10979. broulik added a comment. - Add hint when the result is an approximation REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4290?vs=10577=10979 REVISION DETAIL https://phabricator.kde.org/D4290 AFFECTED FILES runners/calculator/calculatorrunner.cpp runners/calculator/calculatorrunner.h runners/calculator/qalculate_engine.cpp runners/calculator/qalculate_engine.h EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, #plasma_workspaces, mart Cc: mart, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol
[Differential] [Requested Changes To] D4290: [Calculator Runner] Use "approximate" approximation mode
mart requested changes to this revision. mart added a reviewer: mart. mart added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > qalculate_engine.cpp:103 > +// to avoid memory overflow for seemingly innocent calculations (Bug > 277011) > +eo.approximation = APPROXIMATION_APPROXIMATE; > + add an (approximate) string in the result, then good to go REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D4290 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, #plasma_workspaces, mart Cc: mart, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
[Differential] [Commented On] D4290: [Calculator Runner] Use "approximate" approximation mode
mart added a comment. ship it with "aproximate" text (and just 5.10) REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D4290 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, #plasma_workspaces Cc: mart, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
[Differential] [Commented On] D4290: [Calculator Runner] Use "approximate" approximation mode
broulik added a comment. Probably needs some indication that the result is approximate: When `result.isApproximate()` returns true I'll add a (approximation) suffix or something like this – can't go into 5.9 then. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D4290 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, #plasma_workspaces Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
[Differential] [Updated] D4290: [Calculator Runner] Use "approximate" approximation mode
broulik updated the test plan for this revision. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D4290 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, #plasma_workspaces Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
[Differential] [Updated] D4290: [Calculator Runner] Use "approximate" approximation mode
broulik updated the test plan for this revision. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D4290 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, #plasma_workspaces Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
[Differential] [Request, 4 lines] D4290: [Calculator Runner] Use "approximate" approximation mode
broulik created this revision. broulik added a reviewer: Plasma: Workspaces. broulik set the repository for this revision to R120 Plasma Workspace. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY The runner calculator isn't entitled for being a scientifically correct calculator. This keeps seemingly innocent calculations such as "2^0.3" from eating all RAM until it crashes. BUG: 277011 FIXED-IN: 5.9.1 TEST PLAN Upstream issue https://github.com/Qalculate/libqalculate/issues/16 I'll also investigate how to have krunner cancel calculations once the runner context becomes invalid. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D4290 AFFECTED FILES runners/calculator/qalculate_engine.cpp EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, #plasma_workspaces Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
