D5853: Remove gtk+-3 build dep, install versioned gtk.css dirs unconditionally
asturmlechner added a comment. Should this be picked for 5.8 branch as well? REPOSITORY R98 Breeze for Gtk REVISION DETAIL https://phabricator.kde.org/D5853 To: asturmlechner, #plasma, mart Cc: davidedmundson, plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, lukas
D5853: Remove gtk+-3 build dep, install versioned gtk.css dirs unconditionally
This revision was automatically updated to reflect the committed changes. Closed by commit R98:0a34d8667c6e: Remove gtk+-3 build dep, install versioned gtk.css dirs unconditionally (authored by asturmlechner). REPOSITORY R98 Breeze for Gtk CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5853?vs=14510=14644 REVISION DETAIL https://phabricator.kde.org/D5853 AFFECTED FILES Breeze-dark-gtk/CMakeLists.txt Breeze-gtk/CMakeLists.txt CMakeLists.txt To: asturmlechner, #plasma, mart Cc: davidedmundson, plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, lukas
D5853: Remove gtk+-3 build dep, install versioned gtk.css dirs unconditionally
davidedmundson added a comment. Yes You should see "Differential Revision: " in the commit message before pushing. REPOSITORY R98 Breeze for Gtk BRANCH Plasma/5.10 REVISION DETAIL https://phabricator.kde.org/D5853 To: asturmlechner, #plasma, mart Cc: davidedmundson, plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, lukas
D5853: Remove gtk+-3 build dep, install versioned gtk.css dirs unconditionally
asturmlechner added a comment. Yes, I have commit access - it just happens to be my first use of arcanist instead of rbtools - can I git push straight to Plasma/5.10 branch? REPOSITORY R98 Breeze for Gtk BRANCH Plasma/5.10 REVISION DETAIL https://phabricator.kde.org/D5853 To: asturmlechner, #plasma, mart Cc: davidedmundson, plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, lukas
D5853: Remove gtk+-3 build dep, install versioned gtk.css dirs unconditionally
davidedmundson added a comment. Do you have commit access? REPOSITORY R98 Breeze for Gtk BRANCH Plasma/5.10 REVISION DETAIL https://phabricator.kde.org/D5853 To: asturmlechner, #plasma, mart Cc: davidedmundson, plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, lukas
D5853: Remove gtk+-3 build dep, install versioned gtk.css dirs unconditionally
mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY R98 Breeze for Gtk BRANCH Plasma/5.10 REVISION DETAIL https://phabricator.kde.org/D5853 To: asturmlechner, #plasma, mart Cc: plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, lukas
D5853: Remove gtk+-3 build dep, install versioned gtk.css dirs unconditionally
asturmlechner created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY GTK will search /usr/share/themes//gtk- and then earlier versions all the way back to 3.0. See also: https://developer.gnome.org/gtk3/stable/GtkCssProvider.html#GtkCssProvider.description TEST PLAN breeze-gtk installs gtk-3.x dirs to the expected location. REPOSITORY R98 Breeze for Gtk BRANCH Plasma/5.10 REVISION DETAIL https://phabricator.kde.org/D5853 AFFECTED FILES Breeze-dark-gtk/CMakeLists.txt Breeze-gtk/CMakeLists.txt CMakeLists.txt To: asturmlechner, #plasma Cc: plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, lukas
