D6175: Fix build with future glibc (major/minor macros), BSD compatible
This revision was automatically updated to reflect the committed changes. Closed by commit R108:35c278e52537: Fix build with future glibc (major/minor macros), BSD compatible (authored by asturmlechner). REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6175?vs=17180=17186 REVISION DETAIL https://phabricator.kde.org/D6175 AFFECTED FILES logind.cpp To: asturmlechner, #plasma, graesslin Cc: graesslin, plasma-devel, kwin, #kwin, adridg, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas
D6175: Fix build with future glibc (major/minor macros), BSD compatible
graesslin accepted this revision. graesslin added a comment. This revision is now accepted and ready to land. Please reference bug 376505 REPOSITORY R108 KWin BRANCH master REVISION DETAIL https://phabricator.kde.org/D6175 To: asturmlechner, #plasma, graesslin Cc: graesslin, plasma-devel, kwin, #kwin, adridg, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas
D6175: Fix build with future glibc (major/minor macros), BSD compatible
asturmlechner updated this revision to Diff 17180. asturmlechner added a comment. Restricted Application edited projects, added Plasma; removed KWin. Switch to master REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6175?vs=15332=17180 BRANCH master REVISION DETAIL https://phabricator.kde.org/D6175 AFFECTED FILES logind.cpp To: asturmlechner, #plasma Cc: graesslin, plasma-devel, kwin, #kwin, adridg, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas
D6175: Fix build with future glibc (major/minor macros), BSD compatible
graesslin added a comment. Personally I would say master only as it is for future glibc. REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D6175 To: asturmlechner, #plasma Cc: graesslin, plasma-devel, kwin, #kwin, adridg, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart, lukas
D6175: Fix build with future glibc (major/minor macros), BSD compatible
asturmlechner added a comment. In https://phabricator.kde.org/D6175#115496, @graesslin wrote: > If I understand correctly this is no longer a change suited for the 5.8 branch. Okay, then I guess 5.10 would be it? REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D6175 To: asturmlechner, #plasma Cc: graesslin, plasma-devel, kwin, #kwin, adridg, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart, lukas
D6175: Fix build with future glibc (major/minor macros), BSD compatible
graesslin added a comment. If I understand correctly this is no longer a change suited for the 5.8 branch. REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D6175 To: asturmlechner, #plasma Cc: graesslin, plasma-devel, kwin, #kwin, adridg, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart, lukas
D6175: Fix build with future glibc (major/minor macros), BSD compatible
asturmlechner created this revision. Restricted Application added a project: KWin. Restricted Application added subscribers: KWin, kwin, plasma-devel. REVISION SUMMARY Also adding sys/types.h which is not implicitly included from all over. Thanks-to: [ade] in #kde-devel See also: https://sourceware.org/ml/libc-alpha/2015-11/msg00452.html https://git.reviewboard.kde.org/r/127662/ REPOSITORY R108 KWin BRANCH Plasma/5.8 REVISION DETAIL https://phabricator.kde.org/D6175 AFFECTED FILES logind.cpp To: asturmlechner, #plasma Cc: plasma-devel, kwin, #kwin, adridg, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart, lukas
