D6628: Fix and normalize license in .desktop files

maspons added inline comments. INLINE COMMENTS > metadata.desktop:49 > X-KDE-PluginInfo-Depends= > -X-KDE-PluginInfo-License=GPL > X-KDE-PluginInfo-EnabledByDefault=true Are the changes from GPL to LGPL intended? > metadata.desktop:60 > X-KDE-PluginInfo-Depends= >

D6628: Fix and normalize license in .desktop files

mak added a comment. In D6628#676722 , @bam wrote: > Thanks for clarifying. > > In D6628#676721 , @mak wrote: > > > So, this change looks fine to me now, as it is :-) > > > And yet it was

D6628: Fix and normalize license in .desktop files

bam added a comment. Thanks for clarifying. In D6628#676721 , @mak wrote: > So, this change looks fine to me now, as it is :-) And yet it was changed again! :-D

D6628: Fix and normalize license in .desktop files

mak added a comment. In D6628#676720 , @sitter wrote: > These aren't SPDX identifiers but kaboutlicense keywords https://api.kde.org/frameworks/kcoreaddons/html/kaboutdata_8cpp_source.html#l00397 Makes sense. @bam As far as the "legacy

D6628: Fix and normalize license in .desktop files

sitter added a comment. These aren't SPDX identifiers but kaboutlicense keywords https://api.kde.org/frameworks/kcoreaddons/html/kaboutdata_8cpp_source.html#l00397 REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D6628 To: sebas, #plasma, sitter, mart, broulik

D6628: Fix and normalize license in .desktop files

bam added a comment. > Starting version 2.0, it is no longer valid to use the + operator in a license identifier should we address it? https://en.wikipedia.org/wiki/Software_Package_Data_Exchange#Deprecated_syntax REPOSITORY R119 Plasma Desktop REVISION DETAIL

D6628: Fix and normalize license in .desktop files

This revision was automatically updated to reflect the committed changes. Closed by commit R119:782cb4d27e7b: Fix and normalize license in .desktop files (authored by sebas). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6628?vs=16513=16690 REVISION

D6628: Fix and normalize license in .desktop files

sitter added a comment. Yeah, legacy reasons. I am looking into ways to change this moving forward though. Not sure if the cost-benefit will be reasonable, but it's on my radar and at a glance should be doable in some form or fashion. REPOSITORY R119 Plasma Desktop BRANCH master

D6628: Fix and normalize license in .desktop files

broulik added a comment. > Is there any reason not to use the SPDX license IDs here? The values are the ones in `KAboutLicense` from what I can tell. REPOSITORY R119 Plasma Desktop BRANCH master REVISION DETAIL https://phabricator.kde.org/D6628 To: sebas, #plasma, sitter, mart,

D6628: Fix and normalize license in .desktop files

mak added a comment. Is there any reason not to use the SPDX license IDs here? => https://spdx.org/licenses/ (e.g. `GPL-2.0+` in this case). In any case, this patch makes things way better, so +1 from me :-) REPOSITORY R119 Plasma Desktop BRANCH master REVISION DETAIL

D6628: Fix and normalize license in .desktop files

sitter accepted this revision. sitter added a comment. Thanks for doing the leg work. REPOSITORY R119 Plasma Desktop BRANCH master REVISION DETAIL https://phabricator.kde.org/D6628 To: sebas, #plasma, sitter, mart, broulik Cc: mart, plasma-devel, ZrenBot, progwolff, lesliezhai,

D6628: Fix and normalize license in .desktop files

broulik accepted this revision. REPOSITORY R119 Plasma Desktop BRANCH master REVISION DETAIL https://phabricator.kde.org/D6628 To: sebas, #plasma, sitter, mart, broulik Cc: mart, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, lukas

D6628: Fix and normalize license in .desktop files

mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY R119 Plasma Desktop BRANCH master REVISION DETAIL https://phabricator.kde.org/D6628 To: sebas, #plasma, sitter, mart Cc: mart, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed,

D6628: Fix and normalize license in .desktop files

mart added a comment. +1 for all the ones from me REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D6628 To: sebas, #plasma, sitter Cc: mart, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, lukas

D6628: Fix and normalize license in .desktop files

sebas created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY The license is often specificed as (L)GPL, which means v2, while the actual code is usually v2 or v2+. This patch reflects that. TEST PLAN