D6894: [Containment Interface] always emit contextualActionsAboutToShow for containment

2017-08-02 Thread Kai Uwe Broulik 
This revision was automatically updated to reflect the committed changes.
Closed by commit R242:7e0b719f1e71: [Containment Interface] always emit 
contextualActionsAboutToShow for containment (authored by broulik).

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D6894?vs=17163=17546

REVISION DETAIL
  https://phabricator.kde.org/D6894

AFFECTED FILES
  src/scriptengines/qml/plasmoid/containmentinterface.cpp

To: broulik, #plasma, mart
Cc: davidedmundson, plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas

D6894: [Containment Interface] always emit contextualActionsAboutToShow for containment

2017-08-01 Thread Marco Martin 
mart accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D6894

To: broulik, #plasma, mart
Cc: davidedmundson, plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas

D6894: [Containment Interface] always emit contextualActionsAboutToShow for containment

2017-07-25 Thread Kai Uwe Broulik 
broulik added a comment.


  Yes

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D6894

To: broulik, #plasma
Cc: davidedmundson, plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas

D6894: [Containment Interface] always emit contextualActionsAboutToShow for containment

2017-07-25 Thread David Edmundson 
davidedmundson added a comment.


  > Right clicked an applet
  
  so if (applet) would have been true?

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D6894

To: broulik, #plasma
Cc: davidedmundson, plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas

D6894: [Containment Interface] always emit contextualActionsAboutToShow for containment

2017-07-25 Thread Kai Uwe Broulik 
broulik created this revision.
Restricted Application added projects: Plasma, Frameworks.
Restricted Application added subscribers: Frameworks, plasma-devel.

REVISION SUMMARY
  The applet context menu contains containment actions which might be outdated 
if we don't call this.

TEST PLAN
  Right clicked an applet on my desktop, the "Folder View Settings" submenu 
containing the desktop containment actions no longer showed actions like "Empty 
Trash"

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D6894

AFFECTED FILES
  src/scriptengines/qml/plasmoid/containmentinterface.cpp

To: broulik, #plasma
Cc: plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart, lukas