This revision was automatically updated to reflect the committed changes.
Closed by commit R120:592dc9e0bc79: Add support for moving group members within
a group. (authored by hein).
REPOSITORY
R120 Plasma Workspace
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D7267?vs=18120=18128
davidedmundson accepted this revision.
davidedmundson added a comment.
This revision is now accepted and ready to land.
+2 on either patch.
REPOSITORY
R120 Plasma Workspace
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D7267
To: hein, #plasma, davidedmundson, argonel
Cc:
davidedmundson added a comment.
If you don't want to do it, don't do it.
Though I don't really understand what your concern is. If the parent is
invalid, then it's invalid. The code will be the same.
REPOSITORY
R120 Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D7267
hein updated this revision to Diff 18120.
hein added a comment.
Reduce code duplication.
A bit queasy about just passing through parent though.
REPOSITORY
R120 Plasma Workspace
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D7267?vs=18033=18120
BRANCH
master
REVISION
hein added inline comments.
INLINE COMMENTS
> davidedmundson wrote in tasksmodel.cpp:1553
> This is the only bit that's different from the new code.
>
> Can we share the above and guard this with if(!parent)
I was uncomfortable just always passing parent through in beginMoveRows without
davidedmundson added inline comments.
INLINE COMMENTS
> tasksmodel.cpp:1553
> +
> +// If we moved a group parent, consolidate sort map for children.
> +if (groupMode() != GroupDisabled &&
> d->groupingProxyModel->rowCount(groupingRowIndex)) {
This is the only bit that's
hein added a dependent revision: D7268: Use new libtm API to enable DND
reordering within group dialogs..
REPOSITORY
R120 Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D7267
To: hein, #plasma, davidedmundson, argonel
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai,
hein created this revision.
Restricted Application added a project: Plasma.
REVISION SUMMARY
BUG:383405
REPOSITORY
R120 Plasma Workspace
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D7267
AFFECTED FILES
libtaskmanager/tasksmodel.cpp
libtaskmanager/tasksmodel.h
To:
