This revision was automatically updated to reflect the committed changes.
Closed by commit R127:1b2794985361: Avoid sending data offers from an invalid
source. (authored by davidedmundson).
REPOSITORY
R127 KWayland
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D7316?vs=18213=18293
graesslin accepted this revision.
graesslin added a comment.
This revision is now accepted and ready to land.
Nevertheless I still think we should also ship my review. Rather a null check
too many than too few.
REPOSITORY
R127 KWayland
BRANCH
master
REVISION DETAIL
mart added a comment.
+1
REPOSITORY
R127 KWayland
REVISION DETAIL
https://phabricator.kde.org/D7316
To: davidedmundson, #plasma
Cc: mart, graesslin, plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai,
ali-mohamed, jensreuterberg, abetts, sebas, apol, lukas
davidedmundson marked an inline comment as done.
REPOSITORY
R127 KWayland
REVISION DETAIL
https://phabricator.kde.org/D7316
To: davidedmundson, #plasma
Cc: graesslin, plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai,
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas
davidedmundson updated this revision to Diff 18213.
davidedmundson added a comment.
Restricted Application edited projects, added Plasma; removed Plasma on Wayland.
Split into two lines
REPOSITORY
R127 KWayland
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D7316?vs=18162=18213
graesslin added inline comments.
INLINE COMMENTS
> datadevice_interface.cpp:206
> +if (!otherSelection) {
> +return sendClearSelection();
> +}
please use a dedicated line for the return here.
REPOSITORY
R127 KWayland
REVISION DETAIL
https://phabricator.kde.org/D7316
To:
davidedmundson created this revision.
Restricted Application added projects: Plasma on Wayland, Frameworks.
Restricted Application added subscribers: Frameworks, plasma-devel.
REVISION SUMMARY
A DataDevice will have a source when offers are available, but it can
also be legitimately cleared.
