This revision was automatically updated to reflect the committed changes.
Closed by commit R127:ce2ff96c5756: Wayland foreign protocol (authored by mart).
CHANGED PRIOR TO COMMIT
https://phabricator.kde.org/D7369?vs=20639=20667#toc
REPOSITORY
R127 KWayland
CHANGES SINCE LAST UPDATE
graesslin accepted this revision.
REPOSITORY
R127 KWayland
REVISION DETAIL
https://phabricator.kde.org/D7369
To: mart, #plasma, #kwin, davidedmundson, graesslin
Cc: davidedmundson, graesslin, plasma-devel, #frameworks, leezu, ZrenBot,
alexeymin, progwolff, lesliezhai, ali-mohamed,
mart updated this revision to Diff 20639.
mart marked 7 inline comments as done.
mart added a comment.
Restricted Application edited projects, added Plasma on Wayland; removed Plasma.
- more documentation
REPOSITORY
R127 KWayland
CHANGES SINCE LAST UPDATE
mart updated this revision to Diff 20638.
mart added a comment.
Restricted Application edited projects, added Plasma; removed Plasma on Wayland.
- documentation++
- name the methods exportTopLevel/importTopLevel
REPOSITORY
R127 KWayland
CHANGES SINCE LAST UPDATE
graesslin added a comment.
There is still quite some documentation missing. Especially the server side
is not yet documented enough that I would know how to use the new API and what
it does. It's totally fine to copy and adapt the documentation from the Wayland
xml protocol.
INLINE
mart added a comment.
In https://phabricator.kde.org/D7369#154153, @graesslin wrote:
> In https://phabricator.kde.org/D7369#153978, @mart wrote:
>
> > In https://phabricator.kde.org/D7369#152358, @graesslin wrote:
> >
> > > Documentation is still missing, Unstable suffix is still
mart updated this revision to Diff 20584.
mart added a comment.
Restricted Application edited projects, added Plasma on Wayland; removed Plasma.
- update to the upstream xml protocol
REPOSITORY
R127 KWayland
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D7369?vs=20553=20584
graesslin added a comment.
In https://phabricator.kde.org/D7369#153978, @mart wrote:
> In https://phabricator.kde.org/D7369#152358, @graesslin wrote:
>
> > Documentation is still missing, Unstable suffix is still in two many API
calls.
>
>
> i think the
mart updated this revision to Diff 20553.
mart added a comment.
Restricted Application edited projects, added Plasma; removed Plasma on Wayland.
- add api docs, getridof some unstable, calls with unstable follow the other
interfaces
REPOSITORY
R127 KWayland
CHANGES SINCE LAST UPDATE
mart added a comment.
In https://phabricator.kde.org/D7369#152358, @graesslin wrote:
> Documentation is still missing, Unstable suffix is still in two many API
calls.
i think the importerUnstableV2Announced exporterUnstableV2Announced should
remain with unstable and versioned?
graesslin requested changes to this revision.
graesslin added a comment.
This revision now requires changes to proceed.
Documentation is still missing, Unstable suffix is still in two many API
calls.
INLINE COMMENTS
> registry.h:527-528
> +
> +zxdg_exporter_v2
mart updated this revision to Diff 20257.
mart added a comment.
Restricted Application edited projects, added Plasma on Wayland; removed Plasma.
- move to xdg-foreign-unstable-v2
- get rid of setTransientFor
REPOSITORY
R127 KWayland
CHANGES SINCE LAST UPDATE
graesslin requested changes to this revision.
graesslin added a comment.
This revision now requires changes to proceed.
Overall lots of documentation is missing.
From API layout that looks much better now, but we still have a few places
where "Unstable" is needlessly in the API. Most
mart retitled this revision from "[WIP] Wayland foreign protocol" to "Wayland
foreign protocol".
REPOSITORY
R127 KWayland
REVISION DETAIL
https://phabricator.kde.org/D7369
To: mart, #plasma, #kwin, davidedmundson
Cc: davidedmundson, graesslin, plasma-devel, #frameworks, ZrenBot, progwolff,
14 matches
Mail list logo