D7999: Drop workaround for QQC1 QGuiApplication crashes
arojas added a comment. In https://phabricator.kde.org/D7999#158351, @arojas wrote: > Ping, can this go in? AFAIK the QGUIApplication crashes only happen now when explicitely setting the QQC*2* style to org.kde.desktop, which is unrelated to this change (and should be properly fixed instead of worked around here IMO) Scratch that, kalgebramobile still crashes with QT_QUICK_CONTROLS_1_STYLE=Desktop. Still, I don't think this is the place to workaround issues caused by users doing weird stuff - this behavior has probably been around forever since Qt5 and it was noticed only when Plasma started setting this env variable in startkde. REPOSITORY R135 Integration for Qt applications in Plasma REVISION DETAIL https://phabricator.kde.org/D7999 To: arojas, davidedmundson, fvogt Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D7999: Drop workaround for QQC1 QGuiApplication crashes
arojas added a comment. Ping, can this go in? AFAIK the QGUIApplication crashes only happen now when explicitely setting the QQC*2* style to org.kde.desktop, which is unrelated to this change (and should be properly fixed instead of worked around here IMO) REPOSITORY R135 Integration for Qt applications in Plasma REVISION DETAIL https://phabricator.kde.org/D7999 To: arojas, davidedmundson, fvogt Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D7999: Drop workaround for QQC1 QGuiApplication crashes
arojas added a comment. Actually I can't reproduce the QQC1 crashes anymore, even with QT_QUICK_CONTROLS_1_STYLE set to Desktop REPOSITORY R135 Integration for Qt applications in Plasma REVISION DETAIL https://phabricator.kde.org/D7999 To: arojas, davidedmundson, fvogt Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D7999: Drop workaround for QQC1 QGuiApplication crashes
fvogt added a comment. If Qt applications simply crash if the QT_QUICK_CONTROLS_1_STYLE env var is set, that has to be fixed or at least worked around. That the reason why it was set all the time now disappeared, does not make the bug any less valid. Is this a bug in Plasma or Qt? REPOSITORY R135 Integration for Qt applications in Plasma REVISION DETAIL https://phabricator.kde.org/D7999 To: arojas, davidedmundson, fvogt Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D7999: Drop workaround for QQC1 QGuiApplication crashes
arojas created this revision. arojas added reviewers: davidedmundson, fvogt. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Now that QT_QUICK_CONTROLS_1_STYLE is not set in startkde anymore, drop the workaround for QGuiApplication crashes. Qt already takes care of setting the QQC1 style to Desktop for QApplications, so there's no reason why this should need to be set explicitely. If someone still does, we can assume that they know what they're doing and the consequences thereof, including QGuiApplication crashes. Depends on https://phabricator.kde.org/D7998. TEST PLAN With this and https://phabricator.kde.org/D7998, run kalgebramobile -> doesn't crash REPOSITORY R135 Integration for Qt applications in Plasma REVISION DETAIL https://phabricator.kde.org/D7999 AFFECTED FILES src/platformtheme/kdeplatformtheme.cpp To: arojas, davidedmundson, fvogt Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
