guilhermesilva added a comment.
Hi guys! Sorry to "necro-bump" this issue, but I wanted to share my opinion
on this new approach of setting the device icon. From what I've been seeing in
random screenshots of the `plasma-pa` applet, most of the times they all have
the same icon:
andreask added a comment.
icons are added to breeze-icons
REPOSITORY
R115 Plasma Audio Volume Applet
REVISION DETAIL
https://phabricator.kde.org/D8054
To: antlarr, #plasma, davidedmundson, drosca
Cc: andreask, drosca, sebas, plasma-devel, ZrenBot, progwolff, lesliezhai,
ali-mohamed,
This revision was automatically updated to reflect the committed changes.
Closed by commit R115:6940b08074fd: Show headset icons for devices identifying
as Headset in Description (authored by antlarr, committed by
drosca).
REPOSITORY
R115 Plasma Audio Volume Applet
CHANGES SINCE LAST UPDATE
antlarr updated this revision to Diff 20239.
antlarr added a comment.
- Remove check for currentPort which is no longer needed
REPOSITORY
R115 Plasma Audio Volume Applet
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8054?vs=20094=20239
BRANCH
master
REVISION DETAIL
drosca accepted this revision.
drosca added inline comments.
This revision is now accepted and ready to land.
INLINE COMMENTS
> DeviceListItem.qml:29
> icon: {
> if (currentPort) {
> +switch(FormFactor) {
This check is no longer needed.
REPOSITORY
R115 Plasma Audio
antlarr added a comment.
Thanks for the hint! I didn't know I could use FormFactor directly to
reference the Device's formFactor property. Indeed now it looks much better.
REPOSITORY
R115 Plasma Audio Volume Applet
REVISION DETAIL
https://phabricator.kde.org/D8054
To: antlarr, #plasma,
antlarr marked an inline comment as done.
REPOSITORY
R115 Plasma Audio Volume Applet
REVISION DETAIL
https://phabricator.kde.org/D8054
To: antlarr, #plasma, davidedmundson, drosca
Cc: drosca, sebas, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed,
jensreuterberg, abetts, apol,
antlarr updated this revision to Diff 20094.
antlarr added a comment.
- Use the formFactor attribute of the Device directly
REPOSITORY
R115 Plasma Audio Volume Applet
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8054?vs=20090=20094
BRANCH
master
REVISION DETAIL
drosca requested changes to this revision.
drosca added a comment.
This revision now requires changes to proceed.
Perfect solution!
But why is it in Profile when it is device property? Just remove it from
Profile and leave it only in Device.
INLINE COMMENTS
> DeviceListItem.qml:30
>
antlarr updated this revision to Diff 20090.
antlarr added a comment.
- Use form_factor from device to select the icon for a profile
REPOSITORY
R115 Plasma Audio Volume Applet
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8054?vs=20082=20090
BRANCH
master
REVISION DETAIL
drosca added a comment.
`pactl list sinks`
`pactl list sources`
If pulseaudio even differentiates between headset and headphones.
REPOSITORY
R115 Plasma Audio Volume Applet
REVISION DETAIL
https://phabricator.kde.org/D8054
To: antlarr, #plasma, davidedmundson, drosca
Cc: drosca,
antlarr added a comment.
I wrote in the description the contents of the string variables we could work
with so that it's clear I couldn't find any other way to extract that
information. If you have any other idea (any other variable to use for the
match?) I'm happy to test it.
REPOSITORY
drosca requested changes to this revision.
drosca added a comment.
This revision now requires changes to proceed.
Isn't there a better way to test it without using Description (human readable
string - usually device model name)?
REPOSITORY
R115 Plasma Audio Volume Applet
REVISION DETAIL
antlarr added a comment.
Perfect, thanks, I'll do that
REPOSITORY
R115 Plasma Audio Volume Applet
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D8054
To: antlarr, #plasma, davidedmundson
Cc: sebas, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed,
sebas added a comment.
Ah okay, I guess then keep this patch in, and ask for the breeze icon. :)
REPOSITORY
R115 Plasma Audio Volume Applet
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D8054
To: antlarr, #plasma, davidedmundson
Cc: sebas, plasma-devel, ZrenBot,
antlarr added a comment.
If I move it to the end, then the player device will show a headset correctly
anyway since no other condition matches but for the capture device, a
microphone icon will be shown instead of the headset.
REPOSITORY
R115 Plasma Audio Volume Applet
BRANCH
master
sebas added a comment.
Perhaps move the conditional to the end, so it is taken if there's nothing
else, that's making "surer" that nothing that currently works is changed, and
at the same time, request a headset icon for breeze?
REPOSITORY
R115 Plasma Audio Volume Applet
BRANCH
master
antlarr added a comment.
Hmm, you're right, there's no audio-headset icon in breeze, it's inherited
from oxygen. Should we use it while we request an audio-headset icon for
breeze? or should I revert that change and use headphones in the meantime?
REPOSITORY
R115 Plasma Audio Volume
sebas added a comment.
Where is the headset icon? I can't see it in breeze...
REPOSITORY
R115 Plasma Audio Volume Applet
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D8054
To: antlarr, #plasma, davidedmundson
Cc: sebas, plasma-devel, ZrenBot, progwolff, lesliezhai,
davidedmundson accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R115 Plasma Audio Volume Applet
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D8054
To: antlarr, #plasma, davidedmundson
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai,
antlarr retitled this revision from "Show headphone icons for devices
identifying as "Headset" in Description" to "Show headset icons for devices
identifying as "Headset" in Description".
antlarr edited the summary of this revision.
antlarr edited the test plan for this revision.
REPOSITORY
21 matches
Mail list logo
