D8277: Background color for sidebar headers

This revision was automatically updated to reflect the committed changes. Closed by commit R124:c47fa0c75736: Background color for sidebar headers (authored by progwolff). REPOSITORY R124 System Settings CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8277?vs=20801&id=20934 REVISION

D8277: Background color for sidebar headers

mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY R124 System Settings BRANCH master REVISION DETAIL https://phabricator.kde.org/D8277 To: progwolff, #plasma_workspaces, mart Cc: broulik, ngraham, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mo

D8277: Background color for sidebar headers

progwolff added a comment. @mart ? REPOSITORY R124 System Settings REVISION DETAIL https://phabricator.kde.org/D8277 To: progwolff, #plasma_workspaces, mart Cc: broulik, ngraham, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D8277: Background color for sidebar headers

progwolff updated this revision to Diff 20801. progwolff added a comment. - also revert newline REPOSITORY R124 System Settings CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8277?vs=20799&id=20801 BRANCH master REVISION DETAIL https://phabricator.kde.org/D8277 AFFECTED FIL

D8277: Background color for sidebar headers

progwolff updated this revision to Diff 20799. progwolff added a comment. - revert changes to SubCategoryPage REPOSITORY R124 System Settings CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8277?vs=20688&id=20799 BRANCH master REVISION DETAIL https://phabricator.kde.org/D8277

D8277: Background color for sidebar headers

mart added a comment. ok for the top toolbar to be darker. the headers in the listviews should stay like they are now tugh INLINE COMMENTS > SubCategoryPage.qml:77 > elide: Text.ElideRight > visible: !backButton.visible > } it's still suppo

D8277: Background color for sidebar headers

progwolff updated this revision to Diff 20688. progwolff added a comment. - normal font weight REPOSITORY R124 System Settings CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8277?vs=20687&id=20688 BRANCH master REVISION DETAIL https://phabricator.kde.org/D8277 AFFECTED FILE

D8277: Background color for sidebar headers

progwolff added a comment. F5428500: systemsettings_small.png REPOSITORY R124 System Settings REVISION DETAIL https://phabricator.kde.org/D8277 To: progwolff, #plasma_workspaces, mart Cc: broulik, ngraham, plasma-devel, ZrenBot, progwolff, lesliezha

D8277: Background color for sidebar headers

progwolff updated this revision to Diff 20687. progwolff added a comment. - change opacity of secondary heading REPOSITORY R124 System Settings CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8277?vs=20684&id=20687 BRANCH master REVISION DETAIL https://phabricator.kde.org/D82

D8277: Background color for sidebar headers

progwolff added a comment. On second thought, the secondary heading acts like a button for small screens. This means, now that the background is the same as buttonBackground, it will look like a disabled button. I will change the text color to solid black. REPOSITORY R124 System Sett

D8277: Background color for sidebar headers

progwolff added a comment. They are important in the primary column to structure the list items. Yet, the list items are more important than the headings, so it is a good idea to have the headings in lower contrast, so that they create less visual attention. The heading in the second c

D8277: Background color for sidebar headers

ngraham added a comment. That begs the question: why even have headers, if they're unimportant, deliberately low-contrast, and duplicate existing status information shown elsewhere? REPOSITORY R124 System Settings REVISION DETAIL https://phabricator.kde.org/D8277 To: progwolff, #plasma

D8277: Background color for sidebar headers

progwolff added a comment. I think it is intended that the headings have low contrast. The user knows that "Schriftarten" is selected, as it is highlighted in the primary column. In the second column it is rather unimportant to have it there at all. So, giving it a solid black would be

D8277: Background color for sidebar headers

broulik added a comment. Me too. Perhaps the header in subnav ("Schriftarten") needs to be darker then to increase contrast. REPOSITORY R124 System Settings REVISION DETAIL https://phabricator.kde.org/D8277 To: progwolff, #plasma_workspaces, mart Cc: broulik, ngraham, plasma-devel,

D8277: Background color for sidebar headers

ngraham added a comment. I like it, FWIW. REPOSITORY R124 System Settings REVISION DETAIL https://phabricator.kde.org/D8277 To: progwolff, #plasma_workspaces, mart Cc: ngraham, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D8277: Background color for sidebar headers

progwolff updated this revision to Diff 20684. progwolff added a comment. rebase REPOSITORY R124 System Settings CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8277?vs=20679&id=20684 BRANCH master REVISION DETAIL https://phabricator.kde.org/D8277 AFFECTED FILES sidebar/pa

D8277: Background color for sidebar headers

progwolff planned changes to this revision. progwolff added a comment. Need to rebase, sorry... REPOSITORY R124 System Settings REVISION DETAIL https://phabricator.kde.org/D8277 To: progwolff, #plasma_workspaces, mart Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreu

D8277: Background color for sidebar headers

progwolff added a comment. Before: F5428336: systemsettings_old.png After: F5428338: systemsettings_new.png REPOSITORY R124 System Settings REVISION DETAIL https://phabricator.kde.org/D8277 To: progwol

D8277: Background color for sidebar headers

progwolff created this revision. progwolff added reviewers: Plasma: Workspaces, mart. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY kcm modules have backgroundColor as main background color. The new systemsettings side