D8444: Define default Action when we plug unknown monitor

2017-12-08 Thread Sebastian Kügler
sebas added a subscriber: jensreuterberg. sebas added a comment. @dvratil Good question. I actually have a branch that adds an OSD to kscreen. It's in sebas/osd right now and I haven't merged it since it behaves weirdly on Wayland (placement is not reliable). That should be the start. The

D8444: Define default Action when we plug unknown monitor

2017-12-06 Thread Daniel Vrátil
dvratil added a comment. @sebas suggested we approach it as an OSD that would appear on screen and allow the user to select an action they want to take. I think it's a good approach, even more flexible than an option in the KCM. And IIRC it was also what we planned long time ago when I was

D8444: Define default Action when we plug unknown monitor

2017-12-06 Thread David Edmundson
davidedmundson added a comment. It was semi broken. Behavior was arbitrary on size, but there's no ui pretending it's anything else. I'd be happy with this patch if it extended from an in-built monitor (you can't use primary here as we're the ones setting that) instead of biggest.

D8444: Define default Action when we plug unknown monitor

2017-12-06 Thread Milian Wolff
mwolff added a comment. In https://phabricator.kde.org/D8444#173635, @davidedmundson wrote: > I left a comment a month ago. It has not been addressed. > > > there's one part that's going to appear very confusing. > > > > > I have my (small) laptop. Lets say I want any new

D8444: Define default Action when we plug unknown monitor

2017-11-30 Thread David Edmundson
davidedmundson added a comment. I left a comment a month ago. It has not been addressed. > there's one part that's going to appear very confusing. > I have my (small) laptop. Lets say I want any new (big) screen to appear on the left. So I save "Extend to left". > So I'd

D8444: Define default Action when we plug unknown monitor

2017-11-30 Thread Laurent Montel
mlaurent added a comment. Ping ? REPOSITORY R104 KScreen REVISION DETAIL https://phabricator.kde.org/D8444 To: mlaurent, davidedmundson Cc: sebas, graesslin, dvratil, davidedmundson, ngraham, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, apol, mart

D8444: Define default Action when we plug unknown monitor

2017-11-27 Thread Laurent Montel
mlaurent added a comment. @sebas: What do you want as widget design ? Is it ok to add plasma dependancy in kscreen ? REPOSITORY R104 KScreen REVISION DETAIL https://phabricator.kde.org/D8444 To: mlaurent, davidedmundson Cc: sebas, graesslin, dvratil, davidedmundson, ngraham,

D8444: Define default Action when we plug unknown monitor

2017-11-27 Thread Laurent Montel
mlaurent added a comment. (I was in vacation.) Ok so I need to create an osd plasma for it. I can trash this current patch. REPOSITORY R104 KScreen REVISION DETAIL https://phabricator.kde.org/D8444 To: mlaurent, davidedmundson Cc: sebas, graesslin, dvratil, davidedmundson, ngraham,

D8444: Define default Action when we plug unknown monitor

2017-11-20 Thread Sebastian Kügler
sebas added a comment. @mlaurent What's your plan with this? REPOSITORY R104 KScreen REVISION DETAIL https://phabricator.kde.org/D8444 To: mlaurent, davidedmundson Cc: sebas, graesslin, dvratil, davidedmundson, ngraham, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed,

D8444: Define default Action when we plug unknown monitor

2017-10-31 Thread Sebastian Kügler
sebas added a comment. Ow, I might add that we wanted to address a similar thing by providing a popup when a display is connected that asks the user what do do now, and then an action can be chosen. Maybe your time is spent better working on that feature, as we already agreed that this

D8444: Define default Action when we plug unknown monitor

2017-10-31 Thread Sebastian Kügler
sebas added a comment. Once you're done with the code, please also add screenshot so usability can have a look at it. I'm not sure we should add UI for this, the screen setup is already very complex and hard to understand. Perhaps a set of clear use-cases would make this clearer? No

D8444: Define default Action when we plug unknown monitor

2017-10-31 Thread Laurent Montel
mlaurent edited the test plan for this revision. REPOSITORY R104 KScreen REVISION DETAIL https://phabricator.kde.org/D8444 To: mlaurent, davidedmundson Cc: graesslin, dvratil, davidedmundson, ngraham, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas,

D8444: Define default Action when we plug unknown monitor

2017-10-31 Thread Laurent Montel
mlaurent edited the test plan for this revision. REPOSITORY R104 KScreen REVISION DETAIL https://phabricator.kde.org/D8444 To: mlaurent, davidedmundson Cc: graesslin, dvratil, davidedmundson, ngraham, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas,

D8444: Define default Action when we plug unknown monitor

2017-10-31 Thread Laurent Montel
mlaurent edited the test plan for this revision. REPOSITORY R104 KScreen REVISION DETAIL https://phabricator.kde.org/D8444 To: mlaurent, davidedmundson Cc: graesslin, dvratil, davidedmundson, ngraham, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas,

D8444: Define default Action when we plug unknown monitor

2017-10-31 Thread Laurent Montel
mlaurent edited the test plan for this revision. REPOSITORY R104 KScreen REVISION DETAIL https://phabricator.kde.org/D8444 To: mlaurent, davidedmundson Cc: graesslin, dvratil, davidedmundson, ngraham, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas,

D8444: Define default Action when we plug unknown monitor

2017-10-31 Thread David Edmundson
davidedmundson requested changes to this revision. davidedmundson added a comment. This revision now requires changes to proceed. I don't see that my comment about extending has been addressed at all. REPOSITORY R104 KScreen REVISION DETAIL https://phabricator.kde.org/D8444 To:

D8444: Define default Action when we plug unknown monitor

2017-10-31 Thread Laurent Montel
mlaurent retitled this revision from "WIP: Define default Action when we plug unknown monitor" to "Define default Action when we plug unknown monitor". REPOSITORY R104 KScreen REVISION DETAIL https://phabricator.kde.org/D8444 To: mlaurent Cc: graesslin, dvratil, davidedmundson, ngraham,