mlaurent marked an inline comment as done.
REPOSITORY
R104 KScreen
REVISION DETAIL
https://phabricator.kde.org/D8444
To: mlaurent
Cc: graesslin, dvratil, davidedmundson, ngraham, plasma-devel, ZrenBot,
progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
mlaurent updated this revision to Diff 21288.
mlaurent added a comment.
- Don't use Q_FOREACH as it will be deprecated in the future
REPOSITORY
R104 KScreen
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8444?vs=21283=21288
BRANCH
customize_connect_unknown_monitor
REVISION
graesslin added inline comments.
INLINE COMMENTS
> generator.cpp:550
> +
> +Q_FOREACH(KScreen::OutputPtr output, connectedOutputs) {
> +output->setEnabled(true);
Please don't use qforeach in new code as Qt might deprecate it.
REPOSITORY
R104 KScreen
REVISION DETAIL
mlaurent updated this revision to Diff 21283.
mlaurent added a comment.
- Update extend to left
REPOSITORY
R104 KScreen
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8444?vs=21231=21283
BRANCH
customize_connect_unknown_monitor
REVISION DETAIL
mlaurent added a subscriber: dvratil.
REPOSITORY
R104 KScreen
REVISION DETAIL
https://phabricator.kde.org/D8444
To: mlaurent
Cc: dvratil, davidedmundson, ngraham, plasma-devel, ZrenBot, progwolff,
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
davidedmundson added a comment.
Unless I'm misreading things, I think there's one part that's going to appear
very confusing.
I have my (small) laptop. Lets say I want any new (big) screen to appear on
the left. So I save "Extend to left".
So I'd expect to see: monitor, laptop.
mlaurent added a comment.
Wierd why it created a new review ???
This one is more recent.
I will close 8442
REPOSITORY
R104 KScreen
REVISION DETAIL
https://phabricator.kde.org/D8444
To: mlaurent
Cc: ngraham, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed,
jensreuterberg,
ngraham added a comment.
Looks like this was opened by mistake; you've already got
https://phabricator.kde.org/D8442. Can this be closed?
REPOSITORY
R104 KScreen
REVISION DETAIL
https://phabricator.kde.org/D8444
To: mlaurent
Cc: ngraham, plasma-devel, ZrenBot, progwolff, lesliezhai,
mlaurent created this revision.
mlaurent added a project: Plasma.
REVISION SUMMARY
Default action when we plug unknown monitor
REPOSITORY
R104 KScreen
BRANCH
customize_connect_unknown_monitor
REVISION DETAIL
https://phabricator.kde.org/D8444
AFFECTED FILES
kcm/src/kcm_kscreen.cpp
