D8447: Add unit tests for Folder View

amantia added a comment. Sorry about that, I will fix asap (probably in the evening). REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D8447 To: amantia, #plasma, ervin, hein, mlaurent, aacid, dvratil, franckarrecot, renatoo, olivierjg Cc: lbeltrame,

D8447: Add unit tests for Folder View

lbeltrame added a comment. It looks like it broke building with `BUILD_TESTING=OFF`: /home/abuild/rpmbuild/BUILD/plasma-desktop-5.11.90git.20171028T043842~https://phabricator.kde.org/R119:44827507af3a3908ea503eddee30ebec8ca7c34e/containments/desktop/plugins/folder/foldermodel.h:74:45:

D8447: Add unit tests for Folder View

amantia added a comment. I approved and actually suggested Laurent to update the diff. Sorry for the confusion. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D8447 To: amantia, #plasma, ervin, hein, mlaurent, aacid, dvratil, franckarrecot, renatoo,

D8447: Add unit tests for Folder View

This revision was automatically updated to reflect the committed changes. Closed by commit R119:c681a2f6ef63: Add unit tests for Folder View (authored by mlaurent). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8447?vs=21377=21415 REVISION DETAIL

D8447: Add unit tests for Folder View

hein accepted this revision. hein added a comment. Please don't extend already-accepted review requests with new code without requesting more review. Otherwise the status stays "Accepted" on code that hasn't actually been reviewed, which is confusing and holds things up :) New test

D8447: Add unit tests for Folder View

mlaurent updated this revision to Diff 21377. mlaurent added a comment. - Add more autotest. Test default value. Test menu action REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8447?vs=21376=21377 BRANCH arcpatch-D8447 REVISION DETAIL

D8447: Add unit tests for Folder View

amantia updated this revision to Diff 21376. amantia added a comment. Now add back the generate_export_header for real CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8447?vs=21375=21376 REVISION DETAIL https://phabricator.kde.org/D8447 AFFECTED FILES

D8447: Add unit tests for Folder View

amantia updated this revision to Diff 21375. amantia added a comment. Add back unintentionally removed generate_export_header CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8447?vs=21287=21375 REVISION DETAIL https://phabricator.kde.org/D8447 AFFECTED FILES

D8447: Add unit tests for Folder View

mlaurent accepted this revision. This revision is now accepted and ready to land. REVISION DETAIL https://phabricator.kde.org/D8447 To: amantia, #plasma, ervin, hein, mlaurent, aacid, dvratil, franckarrecot, renatoo, olivierjg Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed,

D8447: Add unit tests for Folder View

amantia updated this revision to Diff 21287. amantia added a comment. Use QStringLiteral and nullptr CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8447?vs=21284=21287 REVISION DETAIL https://phabricator.kde.org/D8447 AFFECTED FILES

D8447: Add unit tests for Folder View

hein accepted this revision. hein added a comment. Thanks for working on this! We really need better test coverage in Plasma bits. I'm a little bit unhappy about littering headers with FOLDERPLUGIN_TESTS_EXPORT, but I guess it's the lesser evil of statically linking and building the

D8447: Add unit tests for Folder View

amantia updated this revision to Diff 21284. amantia added a comment. Added copyright notice CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8447?vs=21281=21284 REVISION DETAIL https://phabricator.kde.org/D8447 AFFECTED FILES containments/desktop/plugins/folder/CMakeLists.txt

D8447: Add unit tests for Folder View

mlaurent added inline comments. INLINE COMMENTS > folderplugin_private_export.h:1 > +#ifndef FOLDERPLUGIN_PRIVATE_EXPORT_H > +#define FOLDERPLUGIN_PRIVATE_EXPORT_H Missing copyright > foldermodeltest.cpp:1 > +#include "foldermodeltest.h" > +#include "foldermodel.h" Missing copyright >

D8447: Add unit tests for Folder View

amantia updated this revision to Diff 21281. amantia added a comment. Implement changes requested by Laurent. CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8447?vs=21235=21281 REVISION DETAIL https://phabricator.kde.org/D8447 AFFECTED FILES

D8447: Add unit tests for Folder View

mlaurent added a comment. missing copyright in new file too. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D8447 To: amantia, #plasma, ervin, hein, mlaurent, aacid, dvratil, franckarrecot, renatoo, olivierjg Cc: plasma-devel, ZrenBot, progwolff, lesliezhai,

D8447: Add unit tests for Folder View

mlaurent requested changes to this revision. This revision now requires changes to proceed. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D8447 To: amantia, #plasma, ervin, hein, mlaurent, aacid, dvratil, franckarrecot, renatoo, olivierjg Cc: plasma-devel,

D8447: Add unit tests for Folder View

mlaurent added a comment. Add in toplevel: if(BUILD_TESTING) add_definitions(-DBUILD_TESTING) endif(BUILD_TESTING) + create a folderplugin_private_export.h as #ifndef KSIEVEUIPRIVATE_EXPORT_H #define KSIEVEUIPRIVATE_EXPORT_H #include "ksieveui_export.h" /*

D8447: Add unit tests for Folder View

amantia added reviewers: franckarrecot, renatoo, olivierjg. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D8447 To: amantia, #plasma, ervin, hein, mlaurent, aacid, dvratil, franckarrecot, renatoo, olivierjg Cc: plasma-devel, ZrenBot, progwolff, lesliezhai,

D8447: Add unit tests for Folder View

amantia created this revision. amantia added reviewers: Plasma, ervin, hein, mlaurent, aacid, dvratil. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Add some tests for FolderModel and Positioner classes. REPOSITORY