D8455: Fix DBus startup notification

2017-10-27 Thread Antonio Rojas 
arojas added a comment.


  Shouldn't this come with a kconf_update script? Already existing icons will 
not be fixed by this, since they use a copy of the desktop file in 
.local/share/plamsa_icons

REPOSITORY
  R124 System Settings

REVISION DETAIL
  https://phabricator.kde.org/D8455

To: fvogt, #plasma, davidedmundson
Cc: arojas, ngraham, broulik, rikmills, plasma-devel, ZrenBot, progwolff, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D8455: Fix DBus startup notification

2017-10-24 Thread Fabian Vogt 
This revision was automatically updated to reflect the committed changes.
Closed by commit R124:149060766795: Fix DBus startup notification (authored by 
fvogt).

REPOSITORY
  R124 System Settings

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D8455?vs=21259=21279

REVISION DETAIL
  https://phabricator.kde.org/D8455

AFFECTED FILES
  app/kdesystemsettings.desktop
  app/systemsettings.desktop

To: fvogt, #plasma, davidedmundson
Cc: ngraham, broulik, rikmills, plasma-devel, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D8455: Fix DBus startup notification

2017-10-24 Thread Fabian Vogt 
fvogt added a comment.


  In https://phabricator.kde.org/D8455#159526, @davidedmundson wrote:
  
  > Urgh, Thanks
  >
  > Stable branch too please.
  
  
  Not sure what you mean by stable branch - this is diffed on top of 
Plasma/5.11 which should be enough, the change in main is not part of 5.8.

REPOSITORY
  R124 System Settings

BRANCH
  Plasma/5.11

REVISION DETAIL
  https://phabricator.kde.org/D8455

To: fvogt, #plasma, davidedmundson
Cc: ngraham, broulik, rikmills, plasma-devel, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D8455: Fix DBus startup notification

2017-10-24 Thread David Edmundson 
davidedmundson accepted this revision.
davidedmundson added a comment.
This revision is now accepted and ready to land.


  Urgh, Thanks
  
  Stable branch too please.

REPOSITORY
  R124 System Settings

BRANCH
  Plasma/5.11

REVISION DETAIL
  https://phabricator.kde.org/D8455

To: fvogt, #plasma, davidedmundson
Cc: ngraham, broulik, rikmills, plasma-devel, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D8455: Fix DBus startup notification

2017-10-24 Thread Kai Uwe Broulik 
broulik added a comment.


  This has been broken for most unique apps ever since Plasma 5.0, most 
noticeably with Kate. I once tried to look into KStartupInfo stuff but from 
what I can tell there's a "port me TODO" of some framework (KDBusAddons?) not 
being able to depend on another (KWindowSystem?) and thus a hook "should be 
created" which allows to fix this. But this never happened.

REPOSITORY
  R124 System Settings

REVISION DETAIL
  https://phabricator.kde.org/D8455

To: fvogt, #plasma, davidedmundson
Cc: broulik, rikmills, plasma-devel, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D8455: Fix DBus startup notification

2017-10-24 Thread Fabian Vogt 
fvogt added a comment.


  With this the kwin startup notification bounce does not terminate before the 
timeout if it's already running.
  How does kwin notice that the application is already there? Apparently not 
using the dbus service name.

REPOSITORY
  R124 System Settings

REVISION DETAIL
  https://phabricator.kde.org/D8455

To: fvogt, #plasma, davidedmundson
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D8455: Fix DBus startup notification

2017-10-24 Thread Fabian Vogt 
fvogt created this revision.
fvogt added reviewers: Plasma, davidedmundson.
Restricted Application added a project: Plasma.

REVISION SUMMARY
  In "Fix colours not updating in systemsettings", the application name
  got changed from "systemsettings5" (inferred from the binary name) to
  "systemsettings", which results in a change from "org.kde.systemsettings5"
  as DBus path to "org.kde.systemsettings". KLauncher uses org.kde.
  by default, so that needs to be overwritten.
  
  Fixes the "KDEInit count not launch /usr/bin/systemsettings5" message after
  closing systemsettings and likely also launching it while it's running.

TEST PLAN
  Opened it from dolphin and closed the window again. Only after
  this patch the KDEInit error message disappeared.

REPOSITORY
  R124 System Settings

BRANCH
  Plasma/5.11

REVISION DETAIL
  https://phabricator.kde.org/D8455

AFFECTED FILES
  app/kdesystemsettings.desktop
  app/systemsettings.desktop

To: fvogt, #plasma, davidedmundson
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart