D8684: text improvements for Colors, Icons, Style, and Workspace KCMs
This revision was automatically updated to reflect the committed changes. Closed by commit R119:df78989bb287: text improvements for Colors, Icons, Style, and Workspace KCMs (authored by ngraham). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8684?vs=22027=22062 REVISION DETAIL https://phabricator.kde.org/D8684 AFFECTED FILES doc/kcontrol/colors/index.docbook doc/kcontrol/icons/index.docbook doc/kcontrol/kcmstyle/index.docbook kcms/colors/scmeditoroptions.ui kcms/icons/icons.cpp kcms/style/finetuning.ui kcms/workspaceoptions/mainpage.ui To: ngraham, abetts, #vdg, #plasma, #documentation, apol Cc: lueck, apol, plasma-devel, abetts, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, sebas, mart
D8684: text improvements for Colors, Icons, Style, and Workspace KCMs
abetts accepted this revision. REPOSITORY R119 Plasma Desktop BRANCH arcpatch-D8684 REVISION DETAIL https://phabricator.kde.org/D8684 To: ngraham, abetts, #vdg, #plasma, #documentation, apol Cc: lueck, apol, plasma-devel, abetts, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, sebas, mart
D8684: text improvements for Colors, Icons, Style, and Workspace KCMs
ngraham marked 3 inline comments as done. REPOSITORY R119 Plasma Desktop BRANCH arcpatch-D8684 REVISION DETAIL https://phabricator.kde.org/D8684 To: ngraham, abetts, #vdg, #plasma, #documentation, apol Cc: lueck, apol, plasma-devel, abetts, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, sebas, mart
D8684: text improvements for Colors, Icons, Style, and Workspace KCMs
ngraham updated this revision to Diff 22027. ngraham added a comment. Update dobcook dates and release versions REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8684?vs=22015=22027 BRANCH arcpatch-D8684 REVISION DETAIL https://phabricator.kde.org/D8684 AFFECTED FILES doc/kcontrol/colors/index.docbook doc/kcontrol/icons/index.docbook doc/kcontrol/kcmstyle/index.docbook kcms/colors/scmeditoroptions.ui kcms/icons/icons.cpp kcms/style/finetuning.ui kcms/workspaceoptions/mainpage.ui To: ngraham, abetts, #vdg, #plasma, #documentation, apol Cc: lueck, apol, plasma-devel, abetts, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, sebas, mart
D8684: text improvements for Colors, Icons, Style, and Workspace KCMs
lueck added inline comments. INLINE COMMENTS > index.docbook:17-18 > > 2016-09-20 > Plasma 5.8 > Please bump date + releasinfo > index.docbook:18-19 > > 2016-09-21 > Plasma 5.8 > Please bump date + releasinfo > index.docbook:17-18 > > 2017-04-01 > Plasma 5.9 > Please bump date + releasinfo REPOSITORY R119 Plasma Desktop BRANCH arcpatch-D8684 REVISION DETAIL https://phabricator.kde.org/D8684 To: ngraham, abetts, #vdg, #plasma, #documentation, apol Cc: lueck, apol, plasma-devel, abetts, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, sebas, mart
D8684: text improvements for Colors, Icons, Style, and Workspace KCMs
ngraham updated this revision to Diff 22015. ngraham edited the test plan for this revision. ngraham added a comment. Better text for inactive selection checkbox REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8684?vs=22009=22015 BRANCH arcpatch-D8684 REVISION DETAIL https://phabricator.kde.org/D8684 AFFECTED FILES doc/kcontrol/colors/index.docbook doc/kcontrol/icons/index.docbook doc/kcontrol/kcmstyle/index.docbook kcms/colors/scmeditoroptions.ui kcms/icons/icons.cpp kcms/style/finetuning.ui kcms/workspaceoptions/mainpage.ui To: ngraham, abetts, #vdg, #plasma, #documentation, apol Cc: apol, plasma-devel, abetts, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, sebas, mart
D8684: text improvements for Colors, Icons, Style, and Workspace KCMs
ngraham edited the test plan for this revision. REPOSITORY R119 Plasma Desktop BRANCH arcpatch-D8684 REVISION DETAIL https://phabricator.kde.org/D8684 To: ngraham, abetts, #vdg, #plasma, #documentation, apol Cc: apol, plasma-devel, abetts, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, sebas, mart
D8684: text improvements for Colors, Icons, Style, and Workspace KCMs
abetts added a comment. Just on the first image "Inactive selection changes color" to "Change colors for inactive selection" Just to make sure that the checkbox starts with a verb. REPOSITORY R119 Plasma Desktop BRANCH arcpatch-D8684 REVISION DETAIL https://phabricator.kde.org/D8684 To: ngraham, abetts, #vdg, #plasma, #documentation, apol Cc: apol, plasma-devel, abetts, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, sebas, mart
D8684: text improvements for Colors, Icons, Style, and Workspace KCMs
apol accepted this revision. apol added a comment. This revision is now accepted and ready to land. Looks good! REPOSITORY R119 Plasma Desktop BRANCH arcpatch-D8684 REVISION DETAIL https://phabricator.kde.org/D8684 To: ngraham, abetts, #vdg, #plasma, #documentation, apol Cc: apol, plasma-devel, abetts, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, sebas, mart
D8684: text improvements for Colors, Icons, Style, and Workspace KCMs
ngraham edited the test plan for this revision. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D8684 To: ngraham, abetts, #vdg, #plasma, #documentation Cc: plasma-devel, abetts, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart
D8684: text improvements for Colors, Icons, Style, and Workspace KCMs
ngraham retitled this revision from "text improvements for Style, Colors, and Workspace KCMs" to "text improvements for Colors, Icons, Style, and Workspace KCMs". ngraham edited the summary of this revision. ngraham edited the test plan for this revision. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D8684 To: ngraham, abetts, #vdg, #plasma, #documentation Cc: plasma-devel, abetts, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart
