This revision was automatically updated to reflect the committed changes.
Closed by commit R31:f0709ccc26c3: [Breeze window decoration] Dont
repaint title bar if not damaged (authored by broulik).
REPOSITORY
R31 Breeze
CHANGES SINCE LAST UPDATE
hpereiradacosta accepted this revision.
REPOSITORY
R31 Breeze
REVISION DETAIL
https://phabricator.kde.org/D9114
To: broulik, #plasma, hpereiradacosta, graesslin, davidedmundson
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg,
abetts, sebas, apol, mart
graesslin accepted this revision.
REPOSITORY
R31 Breeze
REVISION DETAIL
https://phabricator.kde.org/D9114
To: broulik, #plasma, hpereiradacosta, graesslin, davidedmundson
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg,
abetts, sebas, apol, mart
broulik added inline comments.
INLINE COMMENTS
> graesslin wrote in breezedecoration.cpp:479
> are you sure contains is correct here? If repaint Region intersects the
> titleRect it should get repainted?
Only if `proper = true` is set, the rect would need to be entirely contained
inside the
graesslin added inline comments.
INLINE COMMENTS
> breezedecoration.cpp:479
>
> +if ( !titleRect.contains(repaintRegion) ) return;
> +
are you sure contains is correct here? If repaint Region intersects the
titleRect it should get repainted?
REPOSITORY
R31 Breeze
REVISION DETAIL
davidedmundson accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R31 Breeze
REVISION DETAIL
https://phabricator.kde.org/D9114
To: broulik, #plasma, hpereiradacosta, graesslin, davidedmundson
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed,
broulik updated this revision to Diff 23298.
broulik added a comment.
- Fix logic error
REPOSITORY
R31 Breeze
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D9114?vs=23297=23298
REVISION DETAIL
https://phabricator.kde.org/D9114
AFFECTED FILES
kdecoration/breezedecoration.cpp
broulik planned changes to this revision.
broulik added a comment.
Breaks rendering of title bar buttons on hover
REPOSITORY
R31 Breeze
REVISION DETAIL
https://phabricator.kde.org/D9114
To: broulik, #plasma, hpereiradacosta, graesslin
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai,
broulik created this revision.
broulik added reviewers: Plasma, hpereiradacosta, graesslin.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
TEST PLAN
Resized my windows with super large border size, painted properly. Did not
repaint the
