This revision was automatically updated to reflect the committed changes.
Closed by commit R120:84a29ef86380: [widgetexplorer] Make sure KNS download
dialog is destroyed (authored by anthonyfieroni).
REPOSITORY
R120 Plasma Workspace
CHANGES SINCE LAST UPDATE
davidedmundson accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R120 Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D9130
To: anthonyfieroni, davidedmundson, broulik, mart
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed,
anthonyfieroni added a reviewer: mart.
anthonyfieroni added a comment.
Anyone against?
REPOSITORY
R120 Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D9130
To: anthonyfieroni, davidedmundson, broulik, mart
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed,
anthonyfieroni updated this revision to Diff 23462.
anthonyfieroni added a comment.
Ability to detect delete on close.
REPOSITORY
R120 Plasma Workspace
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D9130?vs=23459=23462
REVISION DETAIL
https://phabricator.kde.org/D9130
anthonyfieroni updated this revision to Diff 23459.
anthonyfieroni added a comment.
Oh i revert patch, WidgetExplorer is not widget, what DownloadDialog expects
as parent.
REPOSITORY
R120 Plasma Workspace
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D9130?vs=23420=23459
anthonyfieroni updated this revision to Diff 23420.
anthonyfieroni added a comment.
Take ownership of DownloadDialog. Remove slot that not present.
REPOSITORY
R120 Plasma Workspace
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D9130?vs=23336=23420
REVISION DETAIL
anthonyfieroni created this revision.
anthonyfieroni added reviewers: davidedmundson, broulik.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
CCBUG: 355464
TEST PLAN
When DownloadDialog is not destroyed KNS3 engine
