This revision was automatically updated to reflect the committed changes.
Closed by commit R242:a570254e1aad: Dont update when the underlying
FrameSvg is repaint-blocked (authored by hein).
REPOSITORY
R242 Plasma Framework (Library)
CHANGES SINCE LAST UPDATE
davidedmundson accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R242 Plasma Framework (Library)
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D9138
To: hein, #plasma, davidedmundson, mart
Cc: anthonyfieroni, plasma-devel, #frameworks,
hein added inline comments.
INLINE COMMENTS
> anthonyfieroni wrote in framesvgitem.cpp:463
> It doesn't have d-pointer
(I did a git reset and then rewrote the patch, that's how this happened ...)
REPOSITORY
R242 Plasma Framework (Library)
REVISION DETAIL
https://phabricator.kde.org/D9138
hein updated this revision to Diff 23354.
hein added a comment.
Fix code
REPOSITORY
R242 Plasma Framework (Library)
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D9138?vs=23351=23354
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D9138
AFFECTED FILES
anthonyfieroni added inline comments.
INLINE COMMENTS
> framesvgitem.cpp:463
> {
> +if (d->m_frameSvg->isRepaintBlocked()) {
> +return;
It doesn't have d-pointer
REPOSITORY
R242 Plasma Framework (Library)
REVISION DETAIL
https://phabricator.kde.org/D9138
To: hein, #plasma,
hein created this revision.
hein added reviewers: Plasma, davidedmundson, mart.
Restricted Application added projects: Plasma, Frameworks.
Restricted Application added a subscriber: Frameworks.
REVISION SUMMARY
When the component completes `FrameSvg::setRepaintBlocked(false)`
is called, which
