D9197: experimental support for rcc files loading in kpackage

2017-12-14 Thread Marco Martin
This revision was automatically updated to reflect the committed changes. Closed by commit R290:63f5be21cc84: experimental support for rcc files loading in kpackage (authored by mart). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D9197?vs=23864=23892#toc REPOSITORY R290 KPackage

D9197: experimental support for rcc files loading in kpackage

2017-12-13 Thread Marco Martin
mart updated this revision to Diff 23864. mart added a comment. - ad an autotest REPOSITORY R290 KPackage CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9197?vs=23489=23864 BRANCH arcpatch-D9197 REVISION DETAIL https://phabricator.kde.org/D9197 AFFECTED FILES

D9197: experimental support for rcc files loading in kpackage

2017-12-11 Thread David Edmundson
davidedmundson requested changes to this revision. davidedmundson added a comment. This revision now requires changes to proceed. Needs tests and docs INLINE COMMENTS > package.cpp:407 > +QString path = filePath(fileType, filename); > +//consytruct a qrc:/ url or a file:/ url, the

D9197: experimental support for rcc files loading in kpackage

2017-12-10 Thread Aleix Pol Gonzalez
apol added a comment. +1 What's the plan here? INLINE COMMENTS > package.cpp:550 > + > QResource::registerResource(dir.absoluteFilePath(QStringLiteral("contents.rcc"))); > +dir = QDir(QStringLiteral(":")+defaultPackageRoot()+path); > +} QLatin1Char(':')

D9197: experimental support for rcc files loading in kpackage

2017-12-05 Thread Marco Martin
mart created this revision. mart added a reviewer: Plasma. Restricted Application added projects: Plasma, Frameworks. Restricted Application added subscribers: Frameworks, plasma-devel. REVISION SUMMARY support for the contents/ directory of kpackage to be compressed in an rcc file, new cmake