This revision was automatically updated to reflect the committed changes.
Closed by commit R119:5ae880f84626: Slightly reduce vertical gutter width.
(authored by Zren).
REPOSITORY
R119 Plasma Desktop
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D9201?vs=24677=24805
REVISION DETAIL
hein accepted this revision.
hein added a comment.
This revision is now accepted and ready to land.
Thanks Chris!
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D9201
To: Zren, #plasma, hein
Cc: ngraham, abetts, Zren, plasma-devel, ZrenBot, progwolff,
Zren updated this revision to Diff 24677.
Zren edited the summary of this revision.
REPOSITORY
R119 Plasma Desktop
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D9201?vs=23791=24677
REVISION DETAIL
https://phabricator.kde.org/D9201
AFFECTED FILES
Zren commandeered this revision.
Zren added a reviewer: hein.
Zren added a comment.
Oh I see, "Commandeer revision" is in the "Add action..." dropdown, not the
sidebar.
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D9201
To: Zren, #plasma, hein
Cc: ngraham,
hein added a comment.
I think you have to use "Commandeer revision" and then you can upload a
different diff here. Or maybe I should abandon and you refile?
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D9201
To: hein, #plasma
Cc: ngraham, abetts, Zren,
Zren added a comment.
I don't think I can attach a new diff to your differential, so here's a link
to it:
https://phabricator.kde.org/differential/diff/24677/?revisionID=9201
Here's an example without the outlines. 1080p with 32px panel on bottom and
IconSize=3 (1 smaller than
Zren added a comment.
So you removed 2 units from the overall cell height, but only 1 unit from the
frameloader height. This means you removed 1 unit from the "leftover" padding
at the bottom of the frameloader, and are overlapping the cell below by another
1 unit.
Before (cellHeight=6
hein added a comment.
ping
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D9201
To: hein, #plasma
Cc: abetts, Zren, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed,
jensreuterberg, sebas, apol, mart
hein added a comment.
In https://phabricator.kde.org/D9201#178738, @abetts wrote:
> Does the grid and spacing cover only the areas in yellow, or does it cover
the entire screen?
This is about the vertical spacing between desktop icons basically - it
covers the entire screen in
abetts added a comment.
Does the grid and spacing cover only the areas in yellow, or does it cover
the entire screen?
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D9201
To: hein, #plasma
Cc: abetts, Zren, plasma-devel, ZrenBot, progwolff, lesliezhai,
hein updated this revision to Diff 23791.
hein added a comment.
Fix overlap. Thanks for the analysis.
REPOSITORY
R119 Plasma Desktop
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D9201?vs=23499=23791
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D9201
AFFECTED
Zren added a comment.
Before patch:
- `GridView.cellHeight` was `icon.height + text.height + 6 * smallSpacing`
- `Loader {id: frameLoader }` was `icon.height + text.height + 5 *
smallSpacing`. It also has a `y offset` giving it a `1 * smallSpacing` top
margin.
After patch:
-
hein created this revision.
hein added a reviewer: Plasma.
Restricted Application added a project: Plasma.
REVISION SUMMARY
Allows more rows to fit on screen. Results in less goofy-looking
vertical gutters with the default of two text rows (as most labels
only have one, it's a lot of dead
13 matches
Mail list logo
