This revision was automatically updated to reflect the committed changes.
Closed by commit R120:d7fbe6c86377: [Notifications] Add visible menu button to
thumbnail strip (authored by broulik).
REPOSITORY
R120 Plasma Workspace
CHANGES SINCE LAST UPDATE
romangg accepted this revision.
romangg added a comment.
This revision is now accepted and ready to land.
I'll give this an ok, since the base functionality is there. I'm not sure if
I understood the reasoning completely why the context menu can't be aligned
correctly to the context menu
romangg added inline comments.
INLINE COMMENTS
> broulik wrote in ThumbnailStrip.qml:113
> The thumbnail has *always* been clickable.
>
> The open hand cursor is merely an indicator to show that it's draggable, the
> very reason this feature exists.
> The thumbnail has *always* been
broulik added a comment.
> Or should we remove the "Öffnen/Open" button?
Good idea. However, the "Open" button is created by the application itself
and there's no way of knowing to the application whether the notification
server supports that thumbnail strip that is proprietary to
romangg requested changes to this revision.
romangg added inline comments.
This revision now requires changes to proceed.
INLINE COMMENTS
> ThumbnailStrip.qml:113
> preventStealing: true
> cursorShape: Qt.OpenHandCursor
> +acceptedButtons: Qt.LeftButton | Qt.RightButton
ngraham added a comment.
After thinking about it for a while, since this is a more general patch for
all notifications with previews, I think it can be tracked separately from the
default set of buttons that Spectacle displays. That is, even with this, we
could potentially still land
ngraham added a comment.
In https://phabricator.kde.org/D9255#177665, @januz wrote:
> At least for the use-case of screenshots, opening the folder is way more
useful since you usually want to send the file to someone (and you can drag and
drop it on telegram, kmail, etc.).
Yes,
januz added a comment.
+1 for this patch. The three-line buttons happen in many other places too
(dolphin, window title bars, firefox, chrome, etc.). Users quickly learn that
pattern and recognize it as the "menu button" so I don't think that would be a
problem.
A possible tweak for
ngraham added a comment.
I'm not sure we should remove the Open button. That seems like it would be
going backwards in the usability department, because again, a lot of people
won't think to click on the picture. A visible button that //looks// like a
button and has a word in the imperitive
romangg added a comment.
In https://phabricator.kde.org/D9255#177612, @ngraham wrote:
> You can already right-click on the image to pull up the menu. The problem
is that it's a hidden UI; many will miss it because they won't think to
right-click on the image.
>
> Could we maybe make
ngraham added a comment.
You can already right-click on the image to pull up the menu. The problem is
that it's a hidden UI; many will miss it because they won't think to
right-click on the image.
Could we maybe make it a separated button under Open for the common case
where the
romangg added a comment.
Or should we remove the "Öffnen/Open" button? Left click on a preview image /
item (with tooltip what will happen) would then do this "default action". Right
click (or click on the hamburger menu) would show alternative options in the
menu.
REPOSITORY
R120 Plasma
broulik added a comment.
> put it right under the existing Open button
That'll make the code more complex as currently the `ThumbnailStrip.qml` is
fully self-contained. Also that won't really work for multiple thumbnails
further complicating things.
REPOSITORY
R120 Plasma Workspace
ngraham added a comment.
Love the idea and the feature. Not sure I'm a fan of making this a hamburger
menu with no text, and putting it inside the preview. My preference would be to
put it right under the existing Open button and give it a label
("Menu/Options/More/something else"). Let's
broulik created this revision.
broulik added reviewers: Plasma, VDG, ngraham.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
Makes it more obvious there's a menu with more options.
You can still right-click the
15 matches
Mail list logo
