D9400: use kpackage_install_bundled_package

2018-03-20 Thread Aleix Pol Gonzalez
apol added a comment. In D9400#229861 , @mart wrote: > using directly kpackage_install_bundled_package for every plasmoid one must do kpackage_install_bundled_package(analog-clock org.kde.plasma.analogclock "plasmoids"

D9400: use kpackage_install_bundled_package

2018-03-20 Thread Marco Martin
This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R242:7af18926322e: use kpackage_install_bundled_package (authored by mart). REPOSITORY R242 Plasma Framework (Library)

D9400: use kpackage_install_bundled_package

2018-03-20 Thread Marco Martin
mart updated this revision to Diff 29993. mart added a comment. 2 macros REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9400?vs=24078=29993 BRANCH phab/bundled REVISION DETAIL https://phabricator.kde.org/D9400 AFFECTED FILES

D9400: use kpackage_install_bundled_package

2018-03-20 Thread Marco Martin
mart added a comment. In D9400#229866 , @davidedmundson wrote: > My concern here is compiling lts with new frameworks gets affected, and at that point it's too late to do any applet fixes. what about doing a second plasma macro

D9400: use kpackage_install_bundled_package

2018-03-20 Thread David Edmundson
davidedmundson added a comment. My concern here is compiling lts with new frameworks gets affected, and at that point it's too late to do any applet fixes. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D9400 To: mart, #plasma Cc: davidedmundson,

D9400: use kpackage_install_bundled_package

2018-03-20 Thread Marco Martin
mart added a comment. using directly kpackage_install_bundled_package for every plasmoid one must do kpackage_install_bundled_package(analog-clock org.kde.plasma.analogclock "plasmoids" ${PLASMA_RELATIVE_DATA_INSTALL_DIR}) I would still go with this form. REPOSITORY R242 Plasma

D9400: use kpackage_install_bundled_package

2017-12-18 Thread Aleix Pol Gonzalez
apol added a comment. I'd prefer a patch that ports plasma-workspace/desktop to kpackage_install_bundled_package rather than abstracting through plasma_install_package. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D9400 To: mart, #plasma Cc:

D9400: use kpackage_install_bundled_package

2017-12-18 Thread Marco Martin
mart created this revision. mart added a reviewer: Plasma. Restricted Application added projects: Plasma, Frameworks. Restricted Application added subscribers: Frameworks, plasma-devel. REVISION SUMMARY use the new package install macro to install them as as rcc files TEST PLAN plasmashell