Re: Dataengine for browser bookmarks

2011-04-20 Thread Jan Gerrit Marker
Hello again, sadly school turned in my way so I continued developing the bookmarks engine (http://quickgit.kde.org/?p=scratch%2Fjangmarker%2Fbrowserbookmarks.gita=summary) today. I moved the code for getting bookmarks into classes. These classes are compiled in their own libraries. It works

Re: Dataengine for browser bookmarks

2011-04-20 Thread todd rme
On Wed, Apr 20, 2011 at 11:02 AM, Jan Gerrit Marker jangmar...@googlemail.com wrote: Hello again, sadly school turned in my way so I continued developing the bookmarks engine (http://quickgit.kde.org/?p=scratch%2Fjangmarker%2Fbrowserbookmarks.gita=summary) today. I moved the code for getting

Re: Dataengine for browser bookmarks

2011-02-07 Thread Aaron J. Seigo
On Saturday, February 5, 2011, Jan Gerrit José Marker wrote: If it is accepted and moved to kde-workspace I would port the runner to use this engine. i doubt you want to do this as DataEngines are not easy to use in a highly multithread application like KRunner. :) -- Aaron J. Seigo humru

Re: Dataengine for browser bookmarks

2011-02-07 Thread Aaron J. Seigo
On Saturday, February 5, 2011, Jan Gerrit Marker wrote: In order to use the engine with Synchrotron I would need to compile each class into its own shared library, install these libraries into the plug-ins directory together with a desktop file? in order to use Synchrotron, they'd have to be

Dataengine for browser bookmarks

2011-02-05 Thread Jan Gerrit José Marker
Hello, The idea was on plasma-devel some time ago: Write a dataengine which lists the bookmarks of browsers like Firefox, Konqueror or Opera. The bookmarks runner got the feature of querying Firefox' and Opera's bookmarks in KDE SC 4.4 or 4.5. I used the code of this runner to implement the

Re: Dataengine for browser bookmarks

2011-02-05 Thread Marco Martin
On Saturday 05 February 2011, Jan Gerrit José Marker wrote: Hello, The idea was on plasma-devel some time ago: Write a dataengine which lists the bookmarks of browsers like Firefox, Konqueror or Opera. The bookmarks runner got the feature of querying Firefox' and Opera's bookmarks in KDE

Re: Dataengine for browser bookmarks

2011-02-05 Thread Ivan Čukić
Hi, The first thing here I'd like to see is separation of different browsers into different classes. It would be much easier to maintain/extend later. I guess that you're copying sqlite database file to another place so that you don't run into 'database locked' issue when firefox updates the

Re: Dataengine for browser bookmarks

2011-02-05 Thread Ivan Čukić
p.s. There is no point really in doing this until the user (applet) requests a data source: /* Konqueror */ m_konquerorBookmarkManager = KBookmarkManager::userBookmarksManager(); /* Firefox 3 */ m_firefoxDbDir = QDir(KStandardDirs::locateLocal(cache, ) +

Re: Dataengine for browser bookmarks

2011-02-05 Thread Jan Gerrit Marker
I think it's a nice idea and that the engine would be welcome for sure in workspace (ah, maybe you'll want to subscribe at least for the time the discussion will go on, not sure everybody will always remember to reply to all) I'm subscribed, I used the wrong e-Mail address, sorry. quick

Re: Dataengine for browser bookmarks

2011-02-05 Thread todd rme
On Sat, Feb 5, 2011 at 10:29 AM, Jan Gerrit Marker jangmar...@googlemail.com wrote: I think it's a nice idea and that the engine would be welcome for sure in workspace (ah, maybe you'll want to subscribe at least for the time the discussion will go on, not sure everybody will always remember

Re: Dataengine for browser bookmarks

2011-02-05 Thread Jan Gerrit Marker
Hi, Is this a possible use for Synchrotron? Web browsers don't adhere to the KDE release schedule, there could easily be changes to the bookmarks format between KDE releases. The Konqueror related code can stay in the engine's code as Konqueror changes its API only with KDE releases. For the

Re: Dataengine for browser bookmarks

2011-02-05 Thread Jan Gerrit Marker
Hi, The first thing here I'd like to see is separation of different browsers into different classes. It would be much easier to maintain/extend later. I'm not sure how to make this into classes properly. I tried to understand the way the weather dataengine uses but I didn't get it. I guess

Re: Dataengine for browser bookmarks

2011-02-05 Thread todd rme
On Sat, Feb 5, 2011 at 11:35 AM, Jan Gerrit Marker jangmar...@googlemail.com wrote: Hi, Is this a possible use for Synchrotron?  Web browsers don't adhere to the KDE release schedule, there could easily be changes to the bookmarks format between KDE releases. The Konqueror related code can

Re: Dataengine for browser bookmarks

2011-02-05 Thread Ivan Čukić
I'm not sure how to make this into classes properly. I tried to understand the way the weather dataengine uses but I didn't get it. For starters, you can just create classes like KonquerorBookmarks, Firefox3Bookmarks etc. with some common abstract interface like getFolders(const QString

Re: Dataengine for browser bookmarks

2011-02-05 Thread Jan Gerrit Marker
For starters, you can just create classes like KonquerorBookmarks, Firefox3Bookmarks etc. with some common abstract interface like getFolders(const QString path) getBookmarks(const QString path) ... (or similar) then just create a QList QString pluginNames; QHash