Re: Re: DrKonqi dependencies

[Harald Sitter]

On Fri, Jul 28, 2017 at 2:27 PM, David Edmundson
 wrote:
> Please can someone review kde:scratch/davidedmundson/drkonqi

LGTM

(not split defects but: README, AUTHORS, LICENSE, ToDo and doc could
be moved into the main dir, conversely config-x11.h could be merged
into config-drkonqi.h and removed from the main dir)

HS

Re: Re: DrKonqi dependencies

[David Edmundson]

​Please can someone review kde:scratch/davidedmundson/drkonqi

David

Re: Re: DrKonqi dependencies

[David Edmundson]

This came up during akademy with someone.

I've split drkonqi into its own repo. (Not pushed). It's a git-filter
branch with all history looking neat.

I don't intend to move it outside of workspace as that's always an absolute
nightmare. Being a standalone repo will hopefully be enough, and we can
always do more later.

David

On 26 Mar 2017 11:11 a.m., "Andreas Sturmlechner" <
andreas.sturmlech...@gmail.com> wrote:

> On Sunday, 19 March 2017 at 16:22, Martin Gräßlin wrote:
> > Am 2017-03-19 14:19, schrieb Kai Uwe Broulik:
> > > I'd be fine with splitting drkonqi into its own repository, René
> > > recently brought this up as well.
> >
> > Ideally it would be part of KF5, e.g. a kcrash-runtime tier-3 repo.
>
> So how should this be tackled? Is it realistic to prepare it while part of
> plasma-workspace or (more likely) split first, then move to KF5 when ready?
>
>

Re: Re: DrKonqi dependencies

[Andreas Sturmlechner]

On Sunday, 19 March 2017 at 16:22, Martin Gräßlin wrote:
> Am 2017-03-19 14:19, schrieb Kai Uwe Broulik:
> > I'd be fine with splitting drkonqi into its own repository, René
> > recently brought this up as well.
> 
> Ideally it would be part of KF5, e.g. a kcrash-runtime tier-3 repo.

So how should this be tackled? Is it realistic to prepare it while part of 
plasma-workspace or (more likely) split first, then move to KF5 when ready?

Re: Re: DrKonqi dependencies

[Jasem Mutlaq]

On Mon, Mar 20, 2017 at 12:14 AM, Andreas Sturmlechner <
andreas.sturmlech...@gmail.com> wrote:

> On Sunday, 19 March 2017 at 14:19, Kai Uwe Broulik wrote:
> > I'd be fine with splitting drkonqi into its own repository, René recently
> > brought this up as well.
>
> Since I was pondering the idea anyway, might as well attach my patch to
> build
> drkonqi standalone from its subdir.
>

This would be great. If it has its own repository, at least I can try to
make a debian package for it in my PPA so users can use it now. Packagers
can then split it off at their own leisure

-- 
Best Regards,
Jasem Mutlaq

Re: Re: DrKonqi dependencies

[Andreas Sturmlechner]

On Sunday, 19 March 2017 at 14:19, Kai Uwe Broulik wrote:
> I'd be fine with splitting drkonqi into its own repository, René recently
> brought this up as well.

Since I was pondering the idea anyway, might as well attach my patch to build 
drkonqi standalone from its subdir.
commit 1ee858f194fd2c8dcb2cbd3f436fffe7207ba0cc
Author: Andreas Sturmlechner 
Date:   Sun Mar 19 12:54:34 2017 +0100

drkonqi: Standalone sub-project

diff --git a/drkonqi/CMakeLists.txt b/drkonqi/CMakeLists.txt
index cdae1d49..3923a8f4 100644
--- a/drkonqi/CMakeLists.txt
+++ b/drkonqi/CMakeLists.txt
@@ -1,5 +1,68 @@
+project(drkonqi)
+
 include (CheckFunctionExists)
 
+if(${CMAKE_SOURCE_DIR} STREQUAL ${drkonqi_SOURCE_DIR})
+set(PROJECT_VERSION "5.9.90")
+set(PROJECT_VERSION_MAJOR 5)
+
+cmake_minimum_required(VERSION 2.8.12 FATAL_ERROR)
+
+set(QT_MIN_VERSION "5.7.0")
+set(KF5_MIN_VERSION "5.29.0")
+find_package(Qt5 ${QT_MIN_VERSION} CONFIG REQUIRED COMPONENTS DBus Gui Widgets Xml)
+find_package(ECM 1.8.0 REQUIRED NO_MODULE)
+set(CMAKE_MODULE_PATH ${ECM_MODULE_PATH})
+
+include(KDEInstallDirs)
+include(KDECMakeSettings)
+include(KDECompilerSettings NO_POLICY_SCOPE)
+include(ECMPackageConfigHelpers)
+include(ECMMarkNonGuiExecutable)
+include(CMakePackageConfigHelpers)
+include(WriteBasicConfigVersionFile)
+include(CheckIncludeFiles)
+include(FeatureSummary)
+include(ECMOptionalAddSubdirectory)
+include(ECMQtDeclareLoggingCategory)
+include(KDEPackageAppTemplates)
+include(ECMMarkAsTest)
+
+find_package(KF5 ${KF5_MIN_VERSION} REQUIRED COMPONENTS
+Completion
+Config
+ConfigWidgets
+CoreAddons
+Crash
+I18n
+IdleTime
+JobWidgets
+KIO
+Notifications
+Service
+Wallet
+WidgetsAddons
+)
+find_package(KF5XmlRpcClient REQUIRED)
+
+find_package(X11)
+set_package_properties(X11 PROPERTIES DESCRIPTION "X11 libraries"
+URL "http://www.x.org;
+TYPE OPTIONAL
+PURPOSE "Required for X11 support")
+
+if(X11_FOUND)
+find_package(Qt5 ${QT_MIN_VERSION} CONFIG REQUIRED COMPONENTS X11Extras)
+set(HAVE_X11 1)
+endif()
+
+if(BUILD_TESTING)
+find_package(Qt5 ${QT_MIN_VERSION} CONFIG REQUIRED COMPONENTS Concurrent Test)
+endif()
+
+configure_file(../config-X11.h.cmake ${CMAKE_CURRENT_BINARY_DIR}/config-X11.h)
+endif()
+
 check_function_exists("strsignal" HAVE_STRSIGNAL)
 check_function_exists("uname" HAVE_UNAME)
 
@@ -114,3 +177,7 @@ if (HAVE_X11)
 endif()
 
 install(TARGETS drkonqi DESTINATION ${KDE_INSTALL_LIBEXECDIR})
+
+if ("${CMAKE_BINARY_DIR}" STREQUAL "${CMAKE_CURRENT_BINARY_DIR}")
+feature_summary(WHAT ALL FATAL_ON_MISSING_REQUIRED_PACKAGES)
+endif()

Re: DrKonqi dependencies

[Martin Gräßlin]

Am 2017-03-19 14:19, schrieb Kai Uwe Broulik:

I'd be fine with splitting drkonqi into its own repository, René
recently brought this up as well.


Ideally it would be part of KF5, e.g. a kcrash-runtime tier-3 repo.



It might need some adjustments to the environment it runs in, though.
In Plasma we show an SNI and an interactive notification. Other
platforms might not support interactive notifications.


*shrug* can be done by those who want to use it outside of Plasma ;-)

Cheers
Martin

Re: DrKonqi dependencies

[Kai Uwe Broulik]

I'd be fine with splitting drkonqi into its own repository, René recently 
brought this up as well.

It might need some adjustments to the environment it runs in, though. In Plasma 
we show an SNI and an interactive notification. Other platforms might not 
support interactive notifications.

Re: DrKonqi dependencies

[Andreas Sturmlechner]

On 19.03.2017 11:56, Christoph Feck wrote:
> Using openSUSE packages here, installing drkonqi does not drag in the 
> Plasma workspace, only some KF5 frameworks. So the splitting can also be 
> done by the distribution.

Them fixing it in packaging does not make it right though. Everone building 
drkonqi still has to go through all of plasma-workspace or hack around it. 
Every (?) application linking against KCrash does profit from drkonqi - to me 
this is very similar to khelpcenter, or speaking of lib-app pairs, KF5Wallet 
and kwalletmanager. The question imo is if drkonqi should rather be in 
Applications or be kept as part of Plasma, just standalone.

Regards,
Andreas

Re: DrKonqi dependencies

[Christoph Feck]

On 19.03.2017 11:52, Jasem Mutlaq wrote:

Problem is DrKonqi is now part of plasma-workspace. This makes it a *HUGE*
dependency just for crash reporting. I obviously cannot ask non-KDE users
to install plasma-workspace _just_ to have crash reporting capabilities.


Using openSUSE packages here, installing drkonqi does not drag in the 
Plasma workspace, only some KF5 frameworks. So the splitting can also be 
done by the distribution.

DrKonqi dependencies

[Jasem Mutlaq]

Hello,

I have the following issue. We have KStars, part of KDE Applications, which
is used across many desktop environments. I recently wanted to see if
DrKonqi could be used to catch crashes and report them back to bugs.kde.org

Problem is DrKonqi is now part of plasma-workspace. This makes it a *HUGE*
dependency just for crash reporting. I obviously cannot ask non-KDE users
to install plasma-workspace _just_ to have crash reporting capabilities.

So I understand DrKonqi has a lot of dependencies, but what is the proper
solution to this? Can be split into its own thing?

-- 
Best Regards,
Jasem Mutlaq