Re: Gitlab and plasma dev

2020-07-23 Thread Aleix Pol
On Thu, Jul 23, 2020 at 4:40 PM David Edmundson wrote: > > Gitlab has a new "approve" feature. I think it naturally makes sense to use > this instead of the labels as our official workflow. > > One thing to note is that (like labels) the approve button does not send any > emails to the

Re: Gitlab and plasma dev

2020-07-23 Thread David Edmundson
Gitlab has a new "approve" feature. I think it naturally makes sense to use this instead of the labels as our official workflow. One thing to note is that (like labels) the approve button does not send any emails to the recipient. David

Re: Gitlab and plasma dev

2020-05-29 Thread Arjen Hiemstra
On Wednesday, 27 May 2020 20:11:25 CEST David Edmundson wrote: > One thing I'm missing when I'm doing reviews is I don't have a nice way to > separate merge requests that need review, and merge requests that are > awaiting changes. > > I think this could be achieved with a label, that reviewers

Re: Gitlab and plasma dev

2020-05-28 Thread Marco Martin
On Wed, May 27, 2020 at 11:36 PM Kai Uwe Broulik wrote: > > > > The thing that I found annoying is that only one person can be assigned to > > review. One thing that I was on the verge of doing is to @people that I'd > > like > > to notice the review in the comment to the MR. > > Yeah, I'm

Re: Gitlab and plasma dev

2020-05-27 Thread Kai Uwe Broulik
The thing that I found annoying is that only one person can be assigned to review. One thing that I was on the verge of doing is to @people that I'd like to notice the review in the comment to the MR. Yeah, I'm annoyed by that, too. The problem with a pure mention is that there's no

Re: Gitlab and plasma dev

2020-05-27 Thread Ivan Čukić
> Somehow it's possible to create a label that covers all of Plasma as the > VDG have one already. > > Would that workflow work for other devs? Sounds cool. The thing that I found annoying is that only one person can be assigned to review. One thing that I was on the verge of doing is to

Re: Gitlab and plasma dev

2020-05-27 Thread Kai Uwe Broulik
Hi, > I think this could be achieved with a label, that reviewers can set and authors can clear when they're ready. > Somehow it's possible to create a label that covers all of Plasma as the VDG have one already. Good idea! I think having a "Needs changes" label would be very useful, even

Re: Gitlab and plasma dev

2020-05-27 Thread David Edmundson
One thing I'm missing when I'm doing reviews is I don't have a nice way to separate merge requests that need review, and merge requests that are awaiting changes. I think this could be achieved with a label, that reviewers can set and authors can clear when they're ready. Somehow it's possible to

Re: Gitlab and plasma dev

2020-05-21 Thread Marco Martin
On Mon, May 18, 2020 at 7:44 PM Ivan Čukić wrote: > A long long time ago, this (the current setup) was chosen because everyone > ignored that 'other' mailing list with the idea that at least one person on > the list should always react to some mail (bug or a review request). > > It, obviously,

Re: Gitlab and plasma dev

2020-05-18 Thread Ivan Čukić
On Monday, 18 May 2020 16:46:57 CEST Harald Sitter wrote: > On Mon, May 18, 2020 at 3:48 PM Nate Graham wrote: > > Personally I would prefer it if we don't automatically send everything > > to the mailing list. That way people can subscribe to only what they > > really care about using the web

Re: Gitlab and plasma dev

2020-05-18 Thread Nate Graham
On 5/18/20 8:46 AM, Harald Sitter wrote: from personal experience nothing is more annoying than subscribing to a list of a project you are only loosely associated with to discuss something and then getting drowned for a week by 7 different kinds of services also sending crap to the list. it

Re: Gitlab and plasma dev

2020-05-18 Thread Harald Sitter
On Mon, May 18, 2020 at 3:48 PM Nate Graham wrote: > > Personally I would prefer it if we don't automatically send everything > to the mailing list. That way people can subscribe to only what they > really care about using the web UI, which is very simple and > straightforward--and then the

Re: Gitlab and plasma dev

2020-05-18 Thread Nate Graham
On 5/18/20 8:07 AM, Luca Beltrame wrote: I'm of the opposite opinion: the mails don't affect me (they're sorted in subfolders by filters), but sometimes I've jumped in discussions and found regressions merely by reading mails as they arrived to the mailing lists. Subscribing to everything would

Re: Gitlab and plasma dev

2020-05-18 Thread Luca Beltrame
In data lunedì 18 maggio 2020 15:48:34 CEST, Nate Graham ha scritto: > discussions and announcements. That would help the signal-to-noise ratio > stay high for the mailing list. I'm of the opposite opinion: the mails don't affect me (they're sorted in subfolders by filters), but sometimes I've

Re: Gitlab and plasma dev

2020-05-18 Thread Nate Graham
Personally I would prefer it if we don't automatically send everything to the mailing list. That way people can subscribe to only what they really care about using the web UI, which is very simple and straightforward--and then the mailing list can just be used for discussions and

Gitlab and plasma dev

2020-05-18 Thread David Edmundson
Pasting relevant gitlab factoids from the meeting: All of Plasma is on gitlab now. New review requests should go there. New review requests are *not* currently coming to come to this mailing list. If you are a maintainer you can subscribe to all of plasma by going to: