Re: KPipeWire dependency
On Tue, May 31, 2022 at 5:48 PM Luca Beltrame wrote: > > In data martedì 31 maggio 2022 13:53:43 CEST, Aleix Pol ha scritto: > > Sorry didn't see your e-mail, I addressed it yesterday. > > With these changes I was able to package KPipeWire successfully. Two more > minor nits: > > - PROJECT_VERSION is not the same as the other Plasma projects in master > (instead of 5.25.xxx it's 5.24.xxx). Addressed, thanks! > - A very basic README would be useful. https://invent.kde.org/plasma/kpipewire/-/blob/master/README.md
Re: KPipeWire dependency
In data martedì 31 maggio 2022 13:53:43 CEST, Aleix Pol ha scritto: > Sorry didn't see your e-mail, I addressed it yesterday. With these changes I was able to package KPipeWire successfully. Two more minor nits: - PROJECT_VERSION is not the same as the other Plasma projects in master (instead of 5.25.xxx it's 5.24.xxx). - A very basic README would be useful. -- Luca Beltrame GPG key ID: A29D259B signature.asc Description: This is a digitally signed message part.
Re: KPipeWire dependency
Sorry didn't see your e-mail, I addressed it yesterday. Aleix On Mon, May 30, 2022 at 6:06 PM Luca Beltrame wrote: > > In data lunedì 30 maggio 2022 13:04:35 CEST, Aleix Pol ha scritto: > > Hello Aleix, > > > Addressed most "reuse lint" warnings in there. > > Thanks for pointing it out! > > Thanks for fixing. While packaging it for openSUSE I've noticed that it > installs libKPipeWire.so and libKPipeWireRecord.so, but the libraries don't > have any soversion set. Are they meant to be used as shared libraries? If so, > can this be addressed? > > -- > Luca Beltrame > GPG key ID: A29D259B
Re: KPipeWire dependency
In data lunedì 30 maggio 2022 13:04:35 CEST, Aleix Pol ha scritto: Hello Aleix, > Addressed most "reuse lint" warnings in there. > Thanks for pointing it out! Thanks for fixing. While packaging it for openSUSE I've noticed that it installs libKPipeWire.so and libKPipeWireRecord.so, but the libraries don't have any soversion set. Are they meant to be used as shared libraries? If so, can this be addressed? -- Luca Beltrame GPG key ID: A29D259B signature.asc Description: This is a digitally signed message part.
Re: KPipeWire dependency
Addressed most "reuse lint" warnings in there. Thanks for pointing it out! Aleix On Mon, May 30, 2022 at 5:57 AM Luca Beltrame wrote: > > In data lunedì 30 maggio 2022 02:08:25 CEST, Aleix Pol ha scritto: > > Hello Aleix, > > > This means it becomes a dependency for the master branch and thus the > > unstable builds. > > KiPipeWire does not ship a license in its repository: would you be able to add > one? Or packaging it would not be possible. > > -- > Luca Beltrame - KDE Forums team > GPG key ID: A29D259B
Re: KPipeWire dependency
In data lunedì 30 maggio 2022 02:08:25 CEST, Aleix Pol ha scritto: Hello Aleix, > This means it becomes a dependency for the master branch and thus the > unstable builds. KiPipeWire does not ship a license in its repository: would you be able to add one? Or packaging it would not be possible. -- Luca Beltrame - KDE Forums team GPG key ID: A29D259B signature.asc Description: This is a digitally signed message part.
KPipeWire dependency
Hi, Just a quick note that I've merged the plasma-desktop MR that switches to using KPipeWire instead of the components within plasma-workspace. https://invent.kde.org/plasma/plasma-desktop/-/merge_requests/949 https://invent.kde.org/plasma/plasma-mobile/-/merge_requests/242# This means it becomes a dependency for the master branch and thus the unstable builds. Cheers! Aleix
