---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106717/#review19976
---
plasma/declarativeimports/plasmacomponents/qml/Button.qml
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106717/#review19984
---
This review has been submitted with commit
On Oct. 4, 2012, 1:27 a.m., Aleix Pol Gonzalez wrote:
plasma/declarativeimports/plasmacomponents/qml/Button.qml, line 104
http://git.reviewboard.kde.org/r/106717/diff/1/?file=88339#file88339line104
unneeded change :)
It is actually good practice to systematically use semi-colons at
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106717/#review19873
---
Looks good to me.
- Aurélien Gâteau
On Oct. 3, 2012, 10:01
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106717/#review19875
---
Ship it!
looks good, just specify that those 2 properties are
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106717/
---
Review request for Plasma.
Description
---
Add minimumWidth and
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106717/#review19870
---
I like it, it's a good step :)