Re: Review Request: Add minimumWidth and minimumHeight properties to Plasma Button

2012-10-05 Thread Daker Pinheiro
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106717/#review19976 --- plasma/declarativeimports/plasmacomponents/qml/Button.qml

Re: Review Request: Add minimumWidth and minimumHeight properties to Plasma Button

2012-10-05 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106717/#review19984 --- This review has been submitted with commit

Re: Review Request: Add minimumWidth and minimumHeight properties to Plasma Button

2012-10-04 Thread Aurélien Gâteau
On Oct. 4, 2012, 1:27 a.m., Aleix Pol Gonzalez wrote: plasma/declarativeimports/plasmacomponents/qml/Button.qml, line 104 http://git.reviewboard.kde.org/r/106717/diff/1/?file=88339#file88339line104 unneeded change :) It is actually good practice to systematically use semi-colons at

Re: Review Request: Add minimumWidth and minimumHeight properties to Plasma Button

2012-10-04 Thread Aurélien Gâteau
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106717/#review19873 --- Looks good to me. - Aurélien Gâteau On Oct. 3, 2012, 10:01

Re: Review Request: Add minimumWidth and minimumHeight properties to Plasma Button

2012-10-04 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106717/#review19875 --- Ship it! looks good, just specify that those 2 properties are

Review Request: Add minimumWidth and minimumHeight properties to Plasma Button

2012-10-03 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106717/ --- Review request for Plasma. Description --- Add minimumWidth and

Re: Review Request: Add minimumWidth and minimumHeight properties to Plasma Button

2012-10-03 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106717/#review19870 --- I like it, it's a good step :)