---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105319/#review22118
---
plasma/desktop/shell/plasmaapp.cpp
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105319/#review18436
---
Can this be submitted ?
- Varun Herale
On July 1, 2012,
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105319/
---
(Updated July 1, 2012, 5:56 a.m.)
Review request for Plasma.
Changes
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105319/#review15226
---
plasma/desktop/shell/plasmaapp.cpp
On June 28, 2012, 4:48 p.m., Aaron J. Seigo wrote:
plasma/desktop/shell/plasmaapp.cpp, line 397
http://git.reviewboard.kde.org/r/105319/diff/5/?file=70293#file70293line397
i would prefer it if the plugin name and mode were not exposed. the use
case is setting a wallpaper image so
On June 24, 2012, 1:41 a.m., David Edmundson wrote:
I think you've overcomplicated this:
Everything after currentContainment could be replaced with simply:
---
currentContainment-setWallpaper(name, mode);
if (!path.isEmpty()) {
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105319/
---
(Updated June 24, 2012, 3:47 p.m.)
Review request for Plasma.
Changes
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105319/#review15062
---
Ship it!
Looks great.
It's a new feature though so don't
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105319/#review15052
---
I think you've overcomplicated this:
Everything after
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105319/#review14996
---
plasma/desktop/shell/plasmaapp.cpp
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105319/
---
(Updated June 22, 2012, 2:36 p.m.)
Review request for Plasma.
Changes
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105319/
---
Review request for Plasma.
Description
---
This patch is for hosting
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105319/
---
(Updated June 21, 2012, 7:15 p.m.)
Review request for Plasma.
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105319/#review14979
---
plasma/desktop/shell/plasmaapp.cpp
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105319/
---
(Updated June 22, 2012, 2:07 a.m.)
Review request for Plasma.
Changes
15 matches
Mail list logo
