Re: Review Request: Improve the QML RunnerModel

2012-02-16 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103806/#review10688 --- Ship it! - Marco Martin On Feb. 11, 2012, 11:41 a.m., Aleix

Re: Review Request: Improve the QML RunnerModel

2012-02-11 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103806/ --- (Updated Feb. 11, 2012, 11:41 a.m.) Review request for Plasma. Changes -

Re: Review Request: Improve the QML RunnerModel

2012-02-09 Thread Aaron J. Seigo
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103806/#review10471 --- components/runnermodel/runnermodel.cpp

Re: Review Request: Improve the QML RunnerModel

2012-02-07 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103806/ --- (Updated Feb. 7, 2012, 11:23 p.m.) Review request for Plasma. Changes --

Re: Review Request: Improve the QML RunnerModel

2012-01-29 Thread Aleix Pol Gonzalez
> On Jan. 27, 2012, 7:21 p.m., Marco Martin wrote: > > it looks good to me, (and proably you're right 90% of qml models a > > qabstractlistmodel could be enough) > > only thing that i am usire of is the runnerforid function Just that runnerForIndex thing, please comment on it and I'll submit an

Re: Review Request: Improve the QML RunnerModel

2012-01-27 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103806/#review10160 --- it looks good to me, (and proably you're right 90% of qml model

Review Request: Improve the QML RunnerModel

2012-01-27 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103806/ --- Review request for Plasma. Description --- Adds some features to the