Re: Review Request: Show album art in krunner results.

2013-01-12 Thread Emil Sedgh
> On Jan. 10, 2013, 10:09 p.m., Aaron J. Seigo wrote: > > very nice idea. > > > > as for the QPixmap error, one option is to do all the pixmap handling in > > the GUI thread by creating an object in the GUI thread and communicating > > with it via slots. the Places runner > > (kde-workspace/p

Re: Review Request: Show album art in krunner results.

2013-01-11 Thread Christoph Feck
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108316/#review25270 --- Regarding the QPixmap thread warning, there is a auxiliary icon

Re: Review Request: Show album art in krunner results.

2013-01-11 Thread Emil Sedgh
> On Jan. 10, 2013, 10:12 p.m., Vishesh Handa wrote: > > runners/audioplayercontrol/audioplayercontrolrunner.cpp, line 510 > > > > > > How about using 'toUrl().toLocalFile()' instead? That will remove the > > fil

Re: Review Request: Show album art in krunner results.

2013-01-11 Thread Emil Sedgh
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108316/ --- (Updated Jan. 11, 2013, 7:01 a.m.) Review request for Plasma. Changes --

Re: Review Request: Show album art in krunner results.

2013-01-11 Thread Emil Sedgh
> On Jan. 10, 2013, 10:09 p.m., Aaron J. Seigo wrote: > > very nice idea. > > > > as for the QPixmap error, one option is to do all the pixmap handling in > > the GUI thread by creating an object in the GUI thread and communicating > > with it via slots. the Places runner > > (kde-workspace/p

Re: Review Request: Show album art in krunner results.

2013-01-10 Thread Aleix Pol Gonzalez
> On Jan. 10, 2013, 10:12 p.m., Vishesh Handa wrote: > > runners/audioplayercontrol/audioplayercontrolrunner.cpp, line 510 > > > > > > How about using 'toUrl().toLocalFile()' instead? That will remove the > > fil

Re: Review Request: Show album art in krunner results.

2013-01-10 Thread Aleix Pol Gonzalez
> On Jan. 10, 2013, 10:12 p.m., Vishesh Handa wrote: > > runners/audioplayercontrol/audioplayercontrolrunner.cpp, line 510 > > > > > > How about using 'toUrl().toLocalFile()' instead? That will remove the > > fil

Re: Review Request: Show album art in krunner results.

2013-01-10 Thread Vishesh Handa
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108316/#review25196 --- runners/audioplayercontrol/audioplayercontrolrunner.cpp

Re: Review Request: Show album art in krunner results.

2013-01-10 Thread Aaron J. Seigo
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108316/#review25195 --- very nice idea. as for the QPixmap error, one option is to do

Review Request: Show album art in krunner results.

2013-01-10 Thread Emil Sedgh
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108316/ --- Review request for Plasma. Description --- Audio player controller ha