Re: Review Request: Stop DataContainer from discarding multiple values for a single key.

2010-06-08 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/4235/#review6040 --- this actually causes a memory escalation not actually a leak but in

Re: Review Request: Stop DataContainer from discarding multiple values for a single key.

2010-06-08 Thread Beat Wolf
On 2010-06-08 19:20:44, Marco Martin wrote: this actually causes a memory escalation not actually a leak but in systemmonitor for instance each time a new value arrives, will have a different one so the values will continue to pile up more and more i have here a patch that solves

Re: Review Request: Stop DataContainer from discarding multiple values for a single key.

2010-06-08 Thread Aaron J. Seigo
On June 8, 2010, Beat Wolf wrote: On 2010-06-08 19:20:44, Marco Martin wrote: this actually causes a memory escalation not actually a leak but in systemmonitor for instance each time a new value arrives, will have a different one so the values will continue to pile up more and

Re: Review Request: Stop DataContainer from discarding multiple values for a single key.

2010-06-08 Thread Aaron J. Seigo
On June 8, 2010, Aaron J. Seigo wrote: * revert the original commit completely; one key per hash ok, i've already done this... * make the calendar dataengine work properly: put a QStringList in for the duplicate dates. so instead of: looking at the calendar DataEngine, it is sending what is

Re: Review Request: Stop DataContainer from discarding multiple values for a single key.

2010-06-05 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/4235/#review5992 --- Ship it! good catch. could also have something to do wwith

Re: Review Request: Stop DataContainer from discarding multiple values for a single key.

2010-06-05 Thread John Layt
On 2010-06-05 09:29:07, Marco Martin wrote: good catch. could also have something to do wwith https://bugs.kde.org/show_bug.cgi?id=240462 ? Just tested that scenario, but I'm afraid it doesn't fix it. I'll try look at that, and there's another report duplicated entries and failures

Review Request: Stop DataContainer from discarding multiple values for a single key.

2010-06-04 Thread John Layt
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/4235/ --- Review request for Plasma. Summary --- If a DataEngine implementation uses