Re: Review Request: battery: change brightness on mouse wheel

2010-08-01 Thread John Layt
On 2010-08-01 01:53:17, Aaron Seigo wrote: you don't need to propagate wheel events (or most other events, for that matter, unless there is an underlying implementation that also needs to be called). i don't know why it would be crashing with looking at the backtrace. that said,

Re: Review Request: battery: change brightness on mouse wheel

2010-08-01 Thread Alex Fiestas
On 08/01/2010 03:53 AM, Aaron Seigo wrote: --- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/4810/#review6758 --- you don't need to

Re: Review Request: battery: change brightness on mouse wheel

2010-08-01 Thread Alex Fiestas
On 08/01/2010 04:05 PM, John Layt wrote: On 2010-08-01 01:53:17, Aaron Seigo wrote: you don't need to propagate wheel events (or most other events, for that matter, unless there is an underlying implementation that also needs to be called). i don't know why it would be crashing with

Re: Review Request: battery: change brightness on mouse wheel

2010-08-01 Thread John Layt
On Sunday 01 August 2010 16:52:07 Alex Fiestas wrote: Most laptops have specific keys (Fn+X) to change the brightness, so I'm not sure about add a second plasmoid just to do that by default. Anyway, I don't really see an issue with the current Battery plasmoid, it does what it has to imho.

Review Request: battery: change brightness on mouse wheel

2010-07-31 Thread Rafa? Mi?ecki
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/4810/ --- Review request for Plasma. Summary --- This implements feature requested

Re: Review Request: battery: change brightness on mouse wheel

2010-07-31 Thread Aaron Seigo
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/4810/#review6758 --- you don't need to propagate wheel events (or most other events, for